It's possible to paste a reference inside a wikilink, messing up the wikitext syntax
Closed, ResolvedPublic8 Estimated Story Points
Actions

Assigned To

Authored By

	matmarex
	Apr 5 2017, 3:48 PM

Description

It's possible to paste a reference inside a wikilink, messing up the wikitext syntax in fun and unexpected ways.

https://en.wikipedia.org/w/index.php?title=User:Matma_Rex/sandbox&diff=773980370&oldid=773980116

Recording of what I did:

20170405_1745_01.mp4854 KBDownload

Details

	Subject	Repo	Branch	Lines +/-
	Update VE core submodule to master (7b494035e)	mediawiki/extensions/VisualEditor	master	+1 -1
	Refactor newFromAnnotation & addAnnotationsToData	VisualEditor/VisualEditor	master	+86 -60

Customize query in gerrit

Related Objects

Mentioned In: T50720: VisualEditor: Paste of content does not use the context's annotation
Mentioned Here: rGVED7b494035e6a1: Localisation updates from https://translatewiki.net.

Event Timeline

matmarex created this task.Apr 5 2017, 3:48 PM

Restricted Application added a project: VisualEditor. · View Herald TranscriptApr 5 2017, 3:48 PM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

It's also possible to paste a link into a link… probably all kinds of other things are totally broken.

Testing with this revision: https://en.wikipedia.org/w/index.php?title=User:Matma_Rex/sandbox&oldid=773982287 (I didn't save the edit)

20170405_1800_48.mp41 MBDownload

matmarex mentioned this in T50720: VisualEditor: Paste of content does not use the context's annotation.Apr 5 2017, 4:12 PM

Jdforrester-WMF triaged this task as High priority.Apr 11 2017, 7:14 PM

Jdforrester-WMF set the point value for this task to 8.

Jdforrester-WMF moved this task from To Triage to TR0: Interrupt on the VisualEditor board.

Jdforrester-WMF merged a task: T162027: Add or move references on the visual editor creates superfluous wikitext or HTML markup (<span class="mw-reflink-text">).Apr 20 2017, 6:29 PM

Jdforrester-WMF added subscribers: Trizek-WMF, • Elitre, • Whatamidoing-WMF and 3 others.

For refs, we should try and respect blacklistedAnnotationTypes on paste.

Esanders claimed this task.Apr 21 2017, 12:57 PM

Change 349428 had a related patch set uploaded (by Esanders):
[VisualEditor/VisualEditor@master] Refactor newFromAnnotation & addAnnotationsToData

https://gerrit.wikimedia.org/r/349428

gerritbot added a project: Patch-For-Review.Apr 21 2017, 1:08 PM

Change 349428 merged by jenkins-bot:
[VisualEditor/VisualEditor@master] Refactor newFromAnnotation & addAnnotationsToData

https://gerrit.wikimedia.org/r/349428

Change 350001 had a related patch set uploaded (by Jforrester):
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (7b494035e)

https://gerrit.wikimedia.org/r/350001

Change 350001 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (7b494035e)

https://gerrit.wikimedia.org/r/350001

Jdforrester-WMF closed this task as Resolved.Apr 24 2017, 6:29 PM

Jdforrester-WMF removed a project: Patch-For-Review.

Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptApr 24 2017, 6:29 PM

ReleaseTaggerBot added a project: MW-1.29-release (WMF-deploy-2017-04-25_(1.29.0-wmf.21)).Apr 24 2017, 7:00 PM

Thanks @Jdforrester-WMF & @Esanders !

	F7267850: 20170405_1800_48.mp4
	Apr 5 2017, 4:04 PM

It's possible to paste a reference inside a wikilink, messing up the wikitext syntaxClosed, ResolvedPublic8 Estimated Story PointsActions

Description

Details

Related Objects

Event Timeline

It's possible to paste a reference inside a wikilink, messing up the wikitext syntax
Closed, ResolvedPublic8 Estimated Story Points
Actions