⚓ T162941 Undefined property: CategoryTreeCategoryViewer::$mName

Subject	Repo	Branch	Lines +/-
Fix bogus field reference in Category::getCountMessage() callback	mediawiki/core	wmf/1.29.0-wmf.20	+8 -10
Paper over "Notice: Undefined variable: wmgRelatedArticlesFooterWhitelistedSkins"	operations/mediawiki-config	master	+6 -3
Fix bogus field reference in Category::getCountMessage() callback	mediawiki/core	master	+8 -10

• demon created this task.Apr 13 2017, 7:29 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 13 2017, 7:29 PM

• mmodell added a commit: rMW922e68f739f1: Reduce contention during view-based category count refreshes.Apr 20 2017, 3:17 AM

@aaron: It looks like this was caused by rMW922e68f739f1: Reduce contention during view-based category count refreshes.

Should be mName of $category, or $category->getName(). The bug makes the lock global instead of per-category (not urgent itself but should be fixed).

Change 349144 had a related patch set uploaded (by Aaron Schulz):
[mediawiki/core@master] Fix bogus field reference in Category::getCountMessage() callback

https://gerrit.wikimedia.org/r/349144

gerritbot added a project: Patch-For-Review.Apr 20 2017, 3:44 AM

Krinkle assigned this task to aaron.Apr 20 2017, 4:08 AM

Krinkle added a project: Performance-Team.

Krinkle mentioned this in T162121: Contention on enwiki master-categorylinks on Category::refreshCounts.

Krinkle moved this task from Inbox, needs triage to To-do: Goals prioritized current Quarter on the Performance-Team board.

Krinkle closed this task as Resolved.Apr 20 2017, 4:37 AM

Change 349144 merged by jenkins-bot:
[mediawiki/core@master] Fix bogus field reference in Category::getCountMessage() callback

https://gerrit.wikimedia.org/r/349144

ReleaseTaggerBot added projects: MW-1.29-release (WMF-deploy-2017-04-25_(1.29.0-wmf.21)), MW-1.29-release-notes.Apr 20 2017, 5:00 AM

@aaron: Thanks!

• mmodell awarded a token.Apr 20 2017, 6:42 PM

Still happening. I noticed that today during SWAT (and filled duplicate T163686)

@hashar: I don't think this has been deployed (due to deployment freeze)

Change 350011 had a related patch set uploaded (by Hashar; owner: Aaron Schulz):
[mediawiki/core@wmf/1.29.0-wmf.20] Fix bogus field reference in Category::getCountMessage() callback

https://gerrit.wikimedia.org/r/350011

Change 350099 had a related patch set uploaded (by 20after4):
[operations/mediawiki-config@master] Paper over "Notice: Undefined variable: wmgRelatedArticlesFooterWhitelistedSkins"

https://gerrit.wikimedia.org/r/350099

Change 350099 merged by jenkins-bot:
[operations/mediawiki-config@master] Paper over "Notice: Undefined variable: wmgRelatedArticlesFooterWhitelistedSkins"

https://gerrit.wikimedia.org/r/350099

^ that was the wrong Bug: reference

Change 350011 merged by Hashar:
[mediawiki/core@wmf/1.29.0-wmf.20] Fix bogus field reference in Category::getCountMessage() callback

https://gerrit.wikimedia.org/r/350011

Mentioned in SAL (#wikimedia-operations) [2017-04-25T13:20:49Z] <hashar@naos> Synchronized php-1.29.0-wmf.20/includes: Fix bogus field reference in Category::getCountMessage() callback - T162941 (duration: 01m 14s)

hashar closed this task as Resolved.Apr 25 2017, 1:21 PM

ReleaseTaggerBot edited projects, added MW-1.29-release (WMF-deploy-2017-04-11_(1.29.0-wmf.20)); removed MW-1.29-release (WMF-deploy-2017-04-25_(1.29.0-wmf.21)).Apr 25 2017, 2:00 PM

It is no more showing in logstash \o/

Krinkle mentioned this in T163801: WikiPage::updateCategoryCounts caused 14 minutes of lag on enwiki.Apr 25 2017, 7:10 PM

Reedy removed a project: Patch-For-Review.May 17 2019, 9:47 PM

Krinkle moved this task from Dec2019/1.35.wmf.10+ to Resolved on the Wikimedia-production-error board.May 29 2019, 4:01 PM

• mmodell changed the subtype of this task from "Task" to "Production Error".Aug 28 2019, 11:10 PM

Undefined property: CategoryTreeCategoryViewer::$mName
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

Details

Revisions and Commits

Related Objects

Event Timeline

rMW MediaWiki
	rMW922e68f739f1 Reduce contention during view-based category count refreshes

Undefined property: CategoryTreeCategoryViewer::$mNameClosed, ResolvedPublicPRODUCTION ERRORActions