CX template editor's own HTML may end up in the published as an HTML blob
Closed, ResolvedPublic
Actions

Description

Look at this example:

https://ba.wikipedia.org/w/index.php?title=%D0%90%D2%93%D0%B8%D2%99%D0%B5%D0%BB_%D0%BC%D3%99%D2%99%D3%99%D0%BD%D0%B8%D3%99%D1%82%D0%B5&diff=674080&oldid=674076

This is a diff between the first revision of a page, which was created by CX, and the second revision, in which the translator removed a blob of HTML.

Right before the blob there is a correctly auto-adapted template, from ru.wikipedia's {{Книга}} (Kniga) to ba.wikipedia's {{Китап}} (Kitap; this is something like {{Cite book}}).

It looks like this HTML blob is the DOM of the template editor interface itself, which must have been removed before publishing.

I'm not aware of other examples of this happening, so I cannot say how frequent this is, but it definitely happened this one time.

Details

	Subject	Repo	Branch	Lines +/-
	Fix the container calculation for template editor	mediawiki/extensions/ContentTranslation	wmf/1.29.0-wmf.21	+5 -7
	Fix the container calculation for template editor	mediawiki/extensions/ContentTranslation	master	+5 -7

Customize query in gerrit

Related Objects

Mentioned In: T171700: content translation adds useless tags to the article
T164050: Enforce blob size limits for draft save API
T163344: Do a root-cause analysis on CX outage during dc switch and get it back online
T163985: Template editor causes page unresponsive when template has lot of parameters

Event Timeline

Amire80 created this task.Apr 17 2017, 11:27 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 17 2017, 11:27 AM

santhosh triaged this task as High priority.Apr 26 2017, 10:35 AM

santhosh subscribed.

KartikMistry subscribed.Apr 26 2017, 10:58 AM

Change 350408 had a related patch set uploaded (by Santhosh):
[mediawiki/extensions/ContentTranslation@master] Fix the container calculaiton for template editor

https://gerrit.wikimedia.org/r/350408

gerritbot added a project: Patch-For-Review.Apr 26 2017, 12:42 PM

santhosh added a project: Language-team April-June 2017 (Language-2017 Sprint 6).Apr 26 2017, 12:45 PM

This bug has more sever side effect. In a translation from ru to ba for source page Варна, the large amount of unwanted mark up ended up inside a section was attempted to save. The blob was so big and was resulting database failure. In my localhost testing, it was causing this error

Function: ContentTranslation\TranslationStorageManager::update
Error: 2006 MySQL server has gone away (localhost)

With the old buggy retry logic,(https://gerrit.wikimedia.org/r/349214) this much big data was attempted to save several times, resulting a query that was repeated lot of time and taking lot of network.

With https://gerrit.wikimedia.org/r/350408 and https://gerrit.wikimedia.org/r/349214 the issue was not observed.

KartikMistry moved this task from Backlog to In Review on the Language-team April-June 2017 (Language-2017 Sprint 6) board.Apr 27 2017, 10:35 AM

santhosh mentioned this in T163985: Template editor causes page unresponsive when template has lot of parameters.Apr 27 2017, 11:25 AM

Change 350408 merged by jenkins-bot:
[mediawiki/extensions/ContentTranslation@master] Fix the container calculation for template editor

https://gerrit.wikimedia.org/r/350408

• Nikerabbit moved this task from In Review to QA on the Language-team April-June 2017 (Language-2017 Sprint 6) board.Apr 28 2017, 6:29 AM

• Nikerabbit mentioned this in T163344: Do a root-cause analysis on CX outage during dc switch and get it back online.Apr 28 2017, 6:36 AM

• Nikerabbit moved this task from Needs Triage to Apr.–June 2017 on the ContentTranslation board.

• Nikerabbit mentioned this in T164050: Enforce blob size limits for draft save API.Apr 28 2017, 6:38 AM

ReleaseTaggerBot added a project: MW-1.30-release-notes (WMF-deploy-2017-05-09_(1.30.0-wmf.1)).Apr 28 2017, 7:00 AM

greg added a project: Wikimedia-Incident.Apr 28 2017, 4:53 PM

greg moved this task from Active investigation to Follow-up prevention on the Wikimedia-Incident board.

Change 351835 had a related patch set uploaded (by KartikMistry; owner: Santhosh):
[mediawiki/extensions/ContentTranslation@wmf/1.29.0-wmf.21] Fix the container calculation for template editor

https://gerrit.wikimedia.org/r/351835

Change 351835 merged by jenkins-bot:
[mediawiki/extensions/ContentTranslation@wmf/1.29.0-wmf.21] Fix the container calculation for template editor

https://gerrit.wikimedia.org/r/351835

Mentioned in SAL (#wikimedia-operations) [2017-05-09T13:25:53Z] <hashar@tin> Synchronized php-1.29.0-wmf.21/extensions/ContentTranslation/modules/tools/ext.cx.tools.template.js: Fix the container calculation for template editor - T163105 (duration: 00m 40s)

ReleaseTaggerBot added a project: MW-1.29-release (WMF-deploy-2017-04-25_(1.29.0-wmf.21)).May 9 2017, 2:00 PM

Krinkle removed projects: MW-1.29-release (WMF-deploy-2017-04-25_(1.29.0-wmf.21)), Patch-For-Review.May 25 2017, 12:55 PM

KartikMistry closed this task as Resolved.May 31 2017, 6:13 AM

KartikMistry moved this task from QA to Done on the Language-team April-June 2017 (Language-2017 Sprint 6) board.

Amire80 mentioned this in T171700: content translation adds useless tags to the article.Oct 27 2017, 6:18 AM

Krinkle edited projects, added Sustainability (Incident Followup); removed Wikimedia-Incident.Apr 28 2020, 9:50 PM

Restricted Application added a subscriber: Liuxinyu970226. · View Herald TranscriptApr 28 2020, 9:50 PM