Page MenuHomePhabricator
Create Task
Maniphest T163873

ORES errors on beta sites (dewp; zhwp)
Closed, ResolvedPublic
Actions

Description

Special:RecentChanges:

[WQBDogpEE4AAACe6OfMAAAAK] /wiki/Special:%E6%9C%80%E8%BF%91%E6%9B%B4%E6%94%B9 Exception from line 653 of /srv/mediawiki/php-master/extensions/ORES/includes/Hooks.php: Unknown damaging level: 'likelybad'

Backtrace:

#0 /srv/mediawiki/php-master/extensions/ORES/includes/Hooks.php(616): ORES\Hooks::getThreshold(string, User)
#1 /srv/mediawiki/php-master/extensions/ORES/includes/Hooks.php(448): ORES\Hooks::getScoreRecentChangesList(RecentChange, RequestContext)
#2 /srv/mediawiki/php-master/includes/Hooks.php(186): ORES\Hooks::onOldChangesListRecentChangesLine(OldChangesList, string, RecentChange, array)
#3 /srv/mediawiki/php-master/includes/changes/OldChangesList.php(55): Hooks::run(string, array)
#4 /srv/mediawiki/php-master/includes/specials/SpecialRecentchanges.php(396): OldChangesList->recentChangesLine(RecentChange, boolean, integer)
#5 /srv/mediawiki/php-master/includes/specialpage/ChangesListSpecialPage.php(1067): SpecialRecentChanges->outputChangesList(Wikimedia\Rdbms\ResultWrapper, FormOptions)
#6 /srv/mediawiki/php-master/includes/specialpage/ChangesListSpecialPage.php(506): ChangesListSpecialPage->webOutput(Wikimedia\Rdbms\ResultWrapper, FormOptions)
#7 /srv/mediawiki/php-master/includes/specials/SpecialRecentchanges.php(69): ChangesListSpecialPage->execute(NULL)
#8 /srv/mediawiki/php-master/includes/specialpage/SpecialPage.php(522): SpecialRecentChanges->execute(NULL)
#9 /srv/mediawiki/php-master/includes/specialpage/SpecialPageFactory.php(578): SpecialPage->run(NULL)
#10 /srv/mediawiki/php-master/includes/MediaWiki.php(287): SpecialPageFactory::executePath(Title, RequestContext)
#11 /srv/mediawiki/php-master/includes/MediaWiki.php(862): MediaWiki->performRequest()
#12 /srv/mediawiki/php-master/includes/MediaWiki.php(523): MediaWiki->main()
#13 /srv/mediawiki/php-master/index.php(43): MediaWiki->run()
#14 /srv/mediawiki/w/index.php(3): include(string)
#15 {main}

Special:Preferences:

[WQBDmwpEE4AAACXdI4oAAAAD] /wiki/Special:%E5%8F%82%E6%95%B0%E8%AE%BE%E7%BD%AE MWException from line 150 of /srv/mediawiki/php-master/includes/Preferences.php: Global default 'soft' is invalid for field oresDamagingPref

Backtrace:

#0 /srv/mediawiki/php-master/includes/Preferences.php(102): Preferences::loadPreferenceValues(User, RequestContext, array)
#1 /srv/mediawiki/php-master/includes/Preferences.php(1316): Preferences::getPreferences(User, RequestContext)
#2 /srv/mediawiki/php-master/includes/specials/SpecialPreferences.php(84): Preferences::getFormObject(User, RequestContext)
#3 /srv/mediawiki/php-master/includes/specialpage/SpecialPage.php(522): SpecialPreferences->execute(NULL)
#4 /srv/mediawiki/php-master/includes/specialpage/SpecialPageFactory.php(578): SpecialPage->run(NULL)
#5 /srv/mediawiki/php-master/includes/MediaWiki.php(287): SpecialPageFactory::executePath(Title, RequestContext)
#6 /srv/mediawiki/php-master/includes/MediaWiki.php(862): MediaWiki->performRequest()
#7 /srv/mediawiki/php-master/includes/MediaWiki.php(523): MediaWiki->main()
#8 /srv/mediawiki/php-master/index.php(43): MediaWiki->run()
#9 /srv/mediawiki/w/index.php(3): include(string)
#10 {main}

So I can't view RC or preferences or do anything more.

Details

SubjectRepoBranchLines +/-
Don't throw exception when "the" damaging threshold (for old code) can't be foundmediawiki/extensions/ORESmaster+6 -3
Customize query in gerrit

Related Objects

Event Timeline

vjudge404 created this task.Apr 26 2017, 6:55 AM
Restricted Application added subscribers: Stang, Aklapper. · View Herald TranscriptApr 26 2017, 6:55 AM
Aklapper added a project: ORES.Apr 26 2017, 12:01 PM
Restricted Application added a project: Machine-Learning-Team. · View Herald TranscriptApr 26 2017, 12:01 PM
Liuxinyu970226 subscribed.Apr 26 2017, 12:51 PM
Schnark subscribed.Apr 27 2017, 9:46 AM

This isn't limited to zhwiki (at least also dewiki), and affects changing preferences via the API, too (fails with the same internal error as above).

Liuxinyu970226 added a project: Chinese-Sites.Apr 27 2017, 9:56 AM
Halfak added a project: Edit-Review-Improvements.Apr 27 2017, 2:43 PM
Restricted Application added a project: Collaboration-Team-Triage. · View Herald TranscriptApr 27 2017, 2:43 PM
Halfak added subscribers: Catrope, Halfak.Apr 27 2017, 2:43 PM

@Catrope it looks like this is ERI stuff. Can you have a look at this to make sure it's triaged right?

Halfak edited projects, added Machine-Learning-Team (Active Tasks); removed Machine-Learning-Team.Apr 27 2017, 2:53 PM
Halfak moved this task from Parked to Monitor (long term) on the Machine-Learning-Team (Active Tasks) board.
SBisson subscribed.Apr 27 2017, 3:00 PM

I think https://gerrit.wikimedia.org/r/#/c/350316/ fixes it. It has been merged but not deployed yet.

Catrope added a comment.Apr 27 2017, 5:13 PM
In T163873#3217847, @SBisson wrote:

I think https://gerrit.wikimedia.org/r/#/c/350316/ fixes it. It has been merged but not deployed yet.

We're talking about beta, not production, so that change should have been deployed already.

vjudge404 added a comment.Apr 27 2017, 5:16 PM

RecentChanges and Contributions still crash, but Preferences worked. -- Apr 27, 17:14 (UTC) (zhwp beta)

Etonkovidova subscribed.EditedApr 27 2017, 6:28 PM

https://gerrit.wikimedia.org/r/#/c/350504/ fixed that - checked in previously affected betalabs wikis: cawiki, dewiki, zhwiki.

@vjudge404 yes, Contributions are still crashing.

Aklapper renamed this task from ORES errors on zhwp beta to ORES errors on beta sites (dewp; zhwp).Apr 27 2017, 6:29 PM
Aklapper merged a task: T164026: Internal Error on recent changes on dewiki.
Aklapper mentioned this in T164026: Internal Error on recent changes on dewiki.
Aklapper added a subscriber: Freddy2001.
Catrope edited projects, added Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), Edit-Review-Improvements-RC-Page; removed Collaboration-Team-Triage, Edit-Review-Improvements.Apr 27 2017, 8:53 PM
gerritbot subscribed.Apr 27 2017, 8:55 PM

Change 350724 had a related patch set uploaded (by Catrope; owner: Catrope):
[mediawiki/extensions/ORES@master] Don't throw exception when "the" damaging threshold (for old code) can't be found

https://gerrit.wikimedia.org/r/350724

gerritbot added a project: Patch-For-Review.Apr 27 2017, 8:55 PM
Catrope claimed this task.Apr 27 2017, 8:55 PM
Catrope moved this task from Untriaged to Needs Review on the Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017) board.
gerritbot added a comment.Apr 28 2017, 11:29 AM

Change 350724 merged by jenkins-bot:
[mediawiki/extensions/ORES@master] Don't throw exception when "the" damaging threshold (for old code) can't be found

https://gerrit.wikimedia.org/r/350724

ReleaseTaggerBot added a project: MW-1.30-release-notes (WMF-deploy-2017-05-09_(1.30.0-wmf.1)).Apr 28 2017, 12:00 PM
Etonkovidova added a comment.Apr 28 2017, 4:51 PM

Checked in betalabs - dewiki, zhwiki, cawiki - Contributions and Preferences work as expected.

SBisson moved this task from Needs Review to QA Review on the Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017) board.May 1 2017, 10:32 AM
Etonkovidova added a comment.May 1 2017, 4:00 PM

Re-checked the case when the beta feature "New filters for edit review" is on and off - Preferences, Watchlist, and Contribution pages work as expected.

Etonkovidova moved this task from QA Review to Product Review on the Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017) board.May 1 2017, 4:01 PM
• jmatazzoni closed this task as Resolved.May 3 2017, 4:59 PM
Shizhao moved this task from Backlog to Closed on the Chinese-Sites board.May 4 2017, 3:01 AM
Liuxinyu970226 unsubscribed.May 15 2017, 10:58 AM
awight moved this task from Monitor (long term) to Completed on the Machine-Learning-Team (Active Tasks) board.Jul 3 2017, 5:49 PM
Stang unsubscribed.Nov 14 2021, 12:03 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits