Page MenuHomePhabricator
Create Task
Maniphest T166153

Issues with oojs-ui dialogs after updating to jQuery 3
Closed, ResolvedPublic
Actions

Description

Promises behave slightly differently, this causes problems

Details

SubjectRepoBranchLines +/-
WindowManager: Add WindowInstance - a Promise-based lifecycle objectoojs/uimaster+223 -118
Customize query in gerrit

Related Objects
Search...

Event Timeline

Esanders created this task.May 23 2017, 4:57 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 23 2017, 4:57 PM
Esanders added a subtask: T166152: Can't use LanguageInputWidget after update to jQuery 3.May 23 2017, 4:57 PM
Esanders added a subtask: T166150: Template dialog doesn't focus input after update to jQuery 3.
Esanders added a subtask: T163510: OO.ui.alert|confirm|prompt don't work properly with jQuery 3.2.1.
DLynch subscribed.May 23 2017, 5:17 PM
Jdforrester-WMF added a parent task: T124742: Upgrade to jQuery 3.May 24 2017, 6:56 AM
gerritbot subscribed.May 24 2017, 9:09 PM

Change 350789 had a related patch set uploaded (by Krinkle; owner: Krinkle):
[oojs/ui@master] [WIP] WindowManager: Add WindowInstance - a Promise-based lifecycle object

https://gerrit.wikimedia.org/r/350789

gerritbot added a project: Patch-For-Review.May 24 2017, 9:09 PM
Volker_E moved this task from Backlog to Doing on the OOUI board.May 24 2017, 9:13 PM
gerritbot added a comment.May 29 2017, 4:09 PM

Change 350789 merged by jenkins-bot:
[oojs/ui@master] WindowManager: Add WindowInstance - a Promise-based lifecycle object

https://gerrit.wikimedia.org/r/350789

Volker_E moved this task from Doing to Reviewing on the OOUI board.May 29 2017, 4:10 PM
Jdforrester-WMF triaged this task as High priority.May 30 2017, 7:39 PM
Volker_E moved this task from Reviewing to Doing on the OOUI board.May 30 2017, 10:00 PM
Krinkle closed subtask T163510: OO.ui.alert|confirm|prompt don't work properly with jQuery 3.2.1 as Resolved.May 30 2017, 10:23 PM

Given T163510 is resolved, this parent task can also be closed - once the pull-through confirms T166150 and T166152 are also fixed in VisualEditor.

Jdforrester-WMF subscribed.Jun 1 2017, 12:53 AM
In T166153#3302445, @Krinkle wrote:

Given T163510 is resolved, this parent task can also be closed - once the pull-through confirms T166150 and T166152 are also fixed in VisualEditor.

Sadly not yet. T166729 may be necessary for VE at least first.

matmarex closed subtask T166152: Can't use LanguageInputWidget after update to jQuery 3 as Resolved.Jun 1 2017, 1:50 PM

Hopefully not. I mean, we have deprecation warning all over the place in VE now, so fixing them is high priority, but everything works as far as I can tell.

Jdforrester-WMF closed subtask T166150: Template dialog doesn't focus input after update to jQuery 3 as Resolved.Jun 1 2017, 6:37 PM

OK, everything now fixed?

Jdforrester-WMF moved this task from Doing to OOjs-UI-0.22.2 on the OOUI board.Jun 1 2017, 7:46 PM
Jdforrester-WMF edited projects, added OOUI (OOjs-UI-0.22.2); removed OOUI.
matmarex closed this task as Resolved.Jun 6 2017, 6:42 PM
matmarex claimed this task.
matmarex removed a project: Patch-For-Review.
Liuxinyu970226 moved this task from Tag to Transition completed / Archived on the Tracking-Neverending board.Jan 10 2019, 8:28 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL