⚓ T166150 Template dialog doesn't focus input after update to jQuery 3

	Subject	Repo	Branch	Lines +/-
	ve.ui.MWTemplateDialog: Use normal #getReadyProcess instead of custom stuff	mediawiki/extensions/VisualEditor	master	+20 -19

Status	Assigned	Task
Resolved	Krinkle	T127328 Optimise critical rendering path
Resolved	Krinkle	T124742 Upgrade to jQuery 3
Resolved	matmarex	T166153 Issues with oojs-ui dialogs after updating to jQuery 3
Resolved	matmarex	T166150 Template dialog doesn't focus input after update to jQuery 3

Esanders created this task.May 23 2017, 4:54 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 23 2017, 4:54 PM

Esanders added a parent task: T166153: Issues with oojs-ui dialogs after updating to jQuery 3.May 23 2017, 4:58 PM

Volker_E triaged this task as Medium priority.May 29 2017, 4:09 PM

Jdforrester-WMF moved this task from To Triage to TR0: Interrupt on the VisualEditor board.May 30 2017, 7:21 PM

Krinkle mentioned this in T166153: Issues with oojs-ui dialogs after updating to jQuery 3.May 30 2017, 10:25 PM

This is still reproducible after the upgrade to OOjs UI v0.22.1.

ve.ui.MWTemplateDialog tries to set the focus in its setup process. I'm not sure why this ever worked, the dialog is not supposed to be visible at this point, so you can't focus anything in it. It should use the ready process.

matmarex removed a project: OOUI.Jun 1 2017, 2:05 PM

Change 356595 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/VisualEditor@master] ve.ui.MWTemplateDialog: Use normal #getReadyProcess instead of custom stuff

https://gerrit.wikimedia.org/r/356595

gerritbot added a project: Patch-For-Review.Jun 1 2017, 2:32 PM

Change 356595 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] ve.ui.MWTemplateDialog: Use normal #getReadyProcess instead of custom stuff

https://gerrit.wikimedia.org/r/356595

Jdforrester-WMF closed this task as Resolved.Jun 1 2017, 6:37 PM

Jdforrester-WMF edited projects, added VisualEditor-MediaWiki-Templates; removed Patch-For-Review.

Jdforrester-WMF set the point value for this task to 1.

Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptJun 1 2017, 6:37 PM

ReleaseTaggerBot added a project: MW-1.30-release-notes (WMF-deploy-2017-06-06_(1.30.0-wmf.4)).Jun 1 2017, 7:00 PM

Pols12 mentioned this in T292371: Text input should still get focus when template insertion dialog opens.Oct 3 2021, 7:42 PM