Page MenuHomePhabricator
Create Task
Maniphest T292371

Text input should still get focus when template insertion dialog opens
Closed, ResolvedPublic2 Estimated Story PointsBUG REPORT
Actions

Description

List of steps to reproduce:

  • Open visual editor for a given page
  • Type {{ or click Insert→Template
  • “Insert a template” dialog opens.

Actually:
The user has to manually click on template name text field or to press 4 times Tab key before they can type the name of the template they wants to insert.

Expected:
Focus should be given to template name field, to allow user to directly type the name of the template they wants to insert.

Possible regression causes:

Similar previous regression:

Details

SubjectRepoBranchLines +/-
Move some logic into the TransclusionModel classmediawiki/extensions/VisualEditormaster+37 -30
Focus initial/single template placeholdermediawiki/extensions/VisualEditormaster+36 -32
Customize query in gerrit

Related Objects

Event Timeline

Pols12 created this task.Oct 3 2021, 7:42 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 3 2021, 7:42 PM
matmarex added subscribers: thiemowmde, matmarex.Oct 4 2021, 12:28 AM

@thiemowmde FYI, in case it's related to recent WMDE work. I'll investigate if it isn't.

matmarex merged a task: T292354: (Regression) Clicking "Insert>Template" no longer places the text cursor in the input box.Oct 4 2021, 12:28 AM
matmarex added subscribers: SUM1, Tgr.
thiemowmde added projects: WMDE-TechWish-Sprint-2021-09-29, Unplanned-Sprint-Work, WMDE-Templates-FocusArea.Oct 4 2021, 7:51 AM
thiemowmde added subscribers: awight, WMDE-Fisch, Lena_WMDE, Andrew-WMDE.

I did a git bisect. The issue was introduced by patch https://gerrit.wikimedia.org/r/723137. The patch is valid, I would not revert it. Instead we need to find a better place to focus the search input when the dialog initially opens. @awight, can you have a look and find a place for this line? This is where the placeholder is initialized, but this is not where we can focus it.

thiemowmde moved this task from Backlog to Ready for pickup on the WMDE-Templates-FocusArea board.Oct 4 2021, 7:51 AM
thiemowmde set the point value for this task to 2.
matmarex added a comment.Oct 4 2021, 1:42 PM

It probably has to happen somewhere in getReadyProcess(), because in getSetupProcess() the dialog contents are not attached to the DOM yet. But you can probably have different behavior for editing a template and inserting one.

WMDE-Fisch claimed this task.Oct 5 2021, 10:30 AM
WMDE-Fisch moved this task from Sprint Backlog to Doing on the WMDE-TechWish-Sprint-2021-09-29 board.
gerritbot added a comment.Oct 5 2021, 10:59 AM

Change 726575 had a related patch set uploaded (by WMDE-Fisch; author: WMDE-Fisch):

[mediawiki/extensions/VisualEditor@master] Focus initial/single template placeholder

https://gerrit.wikimedia.org/r/726575

gerritbot added a project: Patch-For-Review.Oct 5 2021, 10:59 AM
WMDE-Fisch moved this task from Doing to Review on the WMDE-TechWish-Sprint-2021-09-29 board.Oct 5 2021, 10:59 AM
awight moved this task from Ready for pickup to In sprint on the WMDE-Templates-FocusArea board.Oct 5 2021, 1:33 PM
awight moved this task from Review to Demo on the WMDE-TechWish-Sprint-2021-09-29 board.Oct 5 2021, 2:15 PM
gerritbot added a comment.Oct 5 2021, 2:33 PM

Change 726575 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Focus initial/single template placeholder

https://gerrit.wikimedia.org/r/726575

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.4; 2021-10-12).Oct 5 2021, 3:00 PM
Maintenance_bot removed a project: Patch-For-Review.Oct 5 2021, 3:10 PM
gerritbot added a comment.Oct 6 2021, 1:39 PM

Change 726906 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/VisualEditor@master] Move some logic into the TransclusionModel class

https://gerrit.wikimedia.org/r/726906

gerritbot added a project: Patch-For-Review.Oct 6 2021, 1:39 PM
gerritbot added a comment.Oct 7 2021, 7:51 AM

Change 726906 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Move some logic into the TransclusionModel class

https://gerrit.wikimedia.org/r/726906

Maintenance_bot removed a project: Patch-For-Review.Oct 7 2021, 8:10 AM
matmarex moved this task from To Triage to Triaged on the VisualEditor board.Oct 7 2021, 4:11 PM
awight moved this task from Demo to Done on the WMDE-TechWish-Sprint-2021-09-29 board.Oct 12 2021, 8:16 AM
Lena_WMDE closed this task as Resolved.Oct 13 2021, 10:13 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits