Insert/Template inspector should put focus on input text_field when invoked but no longer does
Closed, ResolvedPublic
Actions

Description

Seen in Firefox and Chrome:

Edit any page in VE, e.g. http://en.wikipedia.beta.wmflabs.org/wiki/Media_Interface_VisualEditor_Test?veaction=edit

Click Insert/Template

The input text field briefly shows a cursor and a blue bar indicating that the element has focus, but then the focus disappears. User should be able to type directly into text field without needing to click the text field element first, but no longer can.

This is the failure at https://integration.wikimedia.org/ci/view/BrowserTests/view/-All/job/browsertests-VisualEditor-en.wikipedia.beta.wmflabs.org-linux-chrome-sauce/423/testReport/(root)/VisualEditor%20Transclusion/Add_parameter_to_template/

Details

	Subject	Repo	Branch	Lines +/-
	Focus the add template input in the template dialog	mediawiki/extensions/VisualEditor	master	+4 -5

Customize query in gerrit

Related Objects

Mentioned In: T292371: Text input should still get focus when template insertion dialog opens
T88411: Various dialog windows gain and then lose the focus after opening
T86626: Deactivation of Edit summary dialog
rEVED34f93bef084d: Focus the add template input in the template dialog

Event Timeline

• Cmcmahon created this task.Dec 29 2014, 10:52 PM

• Cmcmahon raised the priority of this task from to Needs Triage.

• Cmcmahon updated the task description. (Show Details)

• Cmcmahon added projects: VisualEditor, Browser-test-bug.

• Cmcmahon subscribed.

This no longer happens

Still happening for me - Mac - betalabs FF, Chrome and Windows7 IE.

Etonkovidova reopened this task as Open.Dec 30 2014, 7:09 PM

Etonkovidova updated the task description. (Show Details)

Etonkovidova set Security to None.

Jdforrester-WMF triaged this task as Medium priority.Jan 5 2015, 12:29 PM

Jdforrester-WMF added a project: VisualEditor-MediaWiki-Templates.

Jdforrester-WMF moved this task from To Triage to TR6: Visual diffs on the VisualEditor board.

Duplicate to https://phabricator.wikimedia.org/T86040

Jdforrester-WMF merged a task: T86040: "Add Template" Overlay: Input isn't pre-selected.Jan 10 2015, 3:21 AM

Jdforrester-WMF added a subscriber: Florian.

Lokal_Profil subscribed.Jan 21 2015, 9:25 AM

Jdforrester-WMF reassigned this task from • Cmcmahon to Mooeypoo.Jan 23 2015, 10:04 PM

Jdforrester-WMF moved this task from TR6: Visual diffs to Blocked on the VisualEditor board.

Change 186505 had a related patch set uploaded (by Mooeypoo):
Focus the add template input in the template dialog

https://gerrit.wikimedia.org/r/186505

Patch-For-Review

Jdforrester-WMF moved this task from Blocked to FY 18-19 Q3/Q4 on the VisualEditor board.Jan 24 2015, 3:07 AM

Change 186505 merged by jenkins-bot:
Focus the add template input in the template dialog

https://gerrit.wikimedia.org/r/186505

Mooeypoo mentioned this in rEVED34f93bef084d: Focus the add template input in the template dialog.Jan 24 2015, 3:25 AM

Jdforrester-WMF closed this task as Resolved.Jan 24 2015, 5:03 AM

Jdforrester-WMF edited projects, added WMF-deploy-2015-02-04_(1.25wmf16); removed Patch-For-Review.

matmarex mentioned this in T86626: Deactivation of Edit summary dialog.Jan 25 2015, 12:47 AM

Jdforrester-WMF merged a task: T87777: Focus should be on input field when opening template dialog with {{ key combo .Jan 28 2015, 7:59 PM

Jdforrester-WMF added subscribers: Catrope, TheDJ.

Fixed/checked in beta.

Jdforrester-WMF mentioned this in T88411: Various dialog windows gain and then lose the focus after opening.Feb 3 2015, 7:57 PM

Etonkovidova added a project: Verified-in-Phase0.Feb 6 2015, 5:04 PM

Nnemo subscribed.Feb 9 2015, 2:31 PM

On Firefox 35 Mac, I am editing Wikipedia with the Visual Editor.

By habit, I type "{{cit". This brings a dialog for choosing a template with one field for typing the name. But the "cit" went nowhere. And typing the name does nothing. I have to click in the field first. It would be nice to have the focus in the field. Thus, when we type, by habit, "{{cit", the characters "cit" would go in the field for the template name.

Thank you.

Jdforrester-WMF merged a task: T88411: Various dialog windows gain and then lose the focus after opening.Feb 11 2015, 10:51 PM

Jdforrester-WMF added subscribers: matmarex, Jdforrester-WMF, Juandev.

Etonkovidova added a project: Verified-in-Phase2.Feb 13 2015, 1:10 AM

Jdforrester-WMF added a project: VisualEditor 2014/15 Q3 blockers.Aug 5 2015, 1:08 AM

Pols12 mentioned this in T292371: Text input should still get focus when template insertion dialog opens.Oct 3 2021, 7:42 PM