Page MenuHomePhabricator
Create Task
Maniphest T168900

Notice: Undefined index: dsr in /extensions/Linter/includes/ApiRecordLint.php on line 65
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

Undefined index notices are Wikimedia-production-error

Full error message:

Notice: Undefined index: dsr in /srv/mediawiki/php-1.30.0-wmf.6/extensions/Linter/includes/ApiRecordLint.php on line 65

Details

SubjectRepoBranchLines +/-
Drop lints w/o dsr infomediawiki/extensions/Lintermaster+1 -0
Add debug logging for missing 'dsr'mediawiki/extensions/Linterwmf/1.30.0-wmf.6+11 -0
Add debug logging for missing 'dsr'mediawiki/extensions/Lintermaster+11 -0
Customize query in gerrit

Related Objects

Event Timeline

• mmodell created this task.Jun 26 2017, 6:02 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 26 2017, 6:02 PM
• mmodell triaged this task as High priority.Jun 26 2017, 6:02 PM
• mmodell added a parent task: T167536: MW-1.30.0-wmf.7 deployment blockers.
gerritbot subscribed.Jun 26 2017, 10:23 PM

Change 361587 had a related patch set uploaded (by Legoktm; owner: Legoktm):
[mediawiki/extensions/Linter@master] Add debug logging for missing 'dsr'

https://gerrit.wikimedia.org/r/361587

gerritbot added a project: Patch-For-Review.Jun 26 2017, 10:23 PM
Legoktm mentioned this in rELINT60e608d47f3e: Add debug logging for missing 'dsr'.Jun 26 2017, 10:24 PM
gerritbot added a comment.Jun 26 2017, 10:25 PM

Change 361588 had a related patch set uploaded (by Legoktm; owner: Legoktm):
[mediawiki/extensions/Linter@wmf/1.30.0-wmf.6] Add debug logging for missing 'dsr'

https://gerrit.wikimedia.org/r/361588

gerritbot added a comment.Jun 26 2017, 10:26 PM

Change 361587 merged by jenkins-bot:
[mediawiki/extensions/Linter@master] Add debug logging for missing 'dsr'

https://gerrit.wikimedia.org/r/361587

Legoktm mentioned this in rELINT0c7cc71cd4ab: Add debug logging for missing 'dsr'.Jun 26 2017, 10:26 PM
gerritbot added a comment.Jun 26 2017, 10:31 PM

Change 361588 merged by jenkins-bot:
[mediawiki/extensions/Linter@wmf/1.30.0-wmf.6] Add debug logging for missing 'dsr'

https://gerrit.wikimedia.org/r/361588

Stashbot subscribed.Jun 26 2017, 10:34 PM

Mentioned in SAL (#wikimedia-operations) [2017-06-26T22:34:35Z] <legoktm@tin> Synchronized php-1.30.0-wmf.6/extensions/Linter/includes/ApiRecordLint.php: Add debug logging for missing 'dsr' - T168900 (duration: 00m 43s)

• mmodell added a comment.Jun 26 2017, 10:58 PM

Now we are getting this:

Warning: Invalid operand type was used: array_slice expects an array or collection as argument 1 in /srv/mediawiki/php-1.30.0-wmf.6/extensions/Linter/includes/ApiRecordLint.php on line 76

But no sign of the debug message.

ReleaseTaggerBot added a project: MW-1.30-release-notes (WMF-deploy-2017-06-20_(1.30.0-wmf.6)).Jun 26 2017, 11:00 PM
Legoktm subscribed.Jun 26 2017, 11:02 PM

The debug message is in a different log file. But yeah, that is to be expected.

• mmodell added a comment.Jun 26 2017, 11:04 PM

ok I found one:

dsr for Проект:Переводы/Запросы_на_перевод @ rev 86208206, for lint: obsolete-tag is missing
ssastry subscribed.Jun 26 2017, 11:58 PM

Why is this be a deployment blocker? These messages should really be rare (can happen on pages with some kinds of broken tables in templates). But, in any case, we can suppress these in Parsoid by not sending them to Linter in the first place.

Legoktm added a comment.Jun 27 2017, 1:11 AM

After discussion in #mediawiki-parsoid I'm going to remove this as a deployment blocker since log entries make it seem like this has been happening basically ever since Linter was deployed.

Legoktm removed a parent task: T167536: MW-1.30.0-wmf.7 deployment blockers.Jun 27 2017, 1:11 AM
gerritbot added a comment.Jun 27 2017, 1:53 AM

Change 361591 had a related patch set uploaded (by Legoktm; owner: Subramanya Sastry):
[mediawiki/services/parsoid@master] T168900: Linter: Log error when DSR is missing

https://gerrit.wikimedia.org/r/361591

• mmodell added a comment.Jun 27 2017, 4:01 PM

@ssastry: The reason it was marked as a deployment blocker is because of the new policy of halting deployments for anything which increases log spam ( Wikimedia-production-error ). Sometimes a log message appears more often after deploying a new branch. Sometimes it's coincidence rather than causation, as may be the case here.

• mmodell added a comment.EditedJun 27 2017, 4:04 PM

In this instance, the reason it was treated as a bug is because all undefined index notices are considered buggy code as they add noise to the logs: the code should always use isset() before accessing an index that isn't guaranteed to exist.

see https://wikitech.wikimedia.org/wiki/Deployments/Holding_the_train#Logspam

• demon moved this task from Untriaged to Dec2019/1.35.wmf.10+ on the Wikimedia-production-error board.Jun 29 2017, 12:02 AM
Arlolra merged a task: T162397: array_slice() expects an array in ApiRecordLint.Jun 29 2017, 5:05 PM
Arlolra added a subscriber: • demon.
Stashbot added a comment.Jun 29 2017, 5:28 PM

Mentioned in SAL (#wikimedia-operations) [2017-06-29T17:28:25Z] <arlolra> Updated Parsoid to b4187f18 (T168900, T168675, T168404, T153203)

Stashbot mentioned this in T168675: Param in template argument gets parsed incorrectly.Jun 29 2017, 5:28 PM
Stashbot mentioned this in T168404: BUG: Snippets of styling code for certain East-Asian text styles are shown in the app .
Stashbot mentioned this in T153203: Improve detection of missing quotes in HTML tag attributes.
Arlolra closed this task as Resolved.Jun 29 2017, 5:32 PM
Arlolra claimed this task.
Arlolra subscribed.

Parsoid won't be sending lints w/o dsr anymore. Please reopen if that's found not to be the case.

• demon added a comment.Jun 29 2017, 5:37 PM

That's great, but Linter should protect against bogus input in a way that doesn't send errors to logstash either.

gerritbot added a comment.Jun 29 2017, 6:24 PM

Change 362258 had a related patch set uploaded (by Arlolra; owner: Arlolra):
[mediawiki/extensions/Linter@master] T168900: Drop lints w/o dsr info

https://gerrit.wikimedia.org/r/362258

Arlolra added a comment.Jun 29 2017, 6:25 PM

That's great, but Linter should protect against bogus input in a way that doesn't send errors to logstash either.

Ok, see the above.

Arlolra mentioned this in rELINT68d09cc817a9: T168900: Drop lints w/o dsr info.Jun 29 2017, 6:26 PM
gerritbot added a comment.Jun 29 2017, 8:30 PM

Change 362258 had a related patch set uploaded (by Legoktm; owner: Arlolra):
[mediawiki/extensions/Linter@master] Drop lints w/o dsr info

https://gerrit.wikimedia.org/r/362258

Legoktm mentioned this in rELINTc08469e87d96: Drop lints w/o dsr info.Jun 29 2017, 8:31 PM
gerritbot added a comment.Jun 29 2017, 8:32 PM

Change 362258 merged by jenkins-bot:
[mediawiki/extensions/Linter@master] Drop lints w/o dsr info

https://gerrit.wikimedia.org/r/362258

ReleaseTaggerBot edited projects, added MW-1.30-release-notes (WMF-deploy-2017-07-11_(1.30.0-wmf.9)); removed MW-1.30-release-notes (WMF-deploy-2017-06-20_(1.30.0-wmf.6)).Jun 29 2017, 9:00 PM
Arlolra mentioned this in rELINT1153c4d6a605: Create change.Jun 11 2018, 2:20 PM
Reedy removed a project: Patch-For-Review.May 17 2019, 9:45 PM
• mmodell changed the subtype of this task from "Task" to "Production Error".Aug 28 2019, 11:10 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL