I have the bug on Mediawiki wiki. I don't have this bug on Hebrew Wikipedia ATM, which means it is due to something in the deployment train.
|mediawiki/extensions/VisualEditor : master||Update VE core submodule to master (c9b0d1a23)|
|VisualEditor/VisualEditor : master||Workaround for Flow bottom toolbars conflicting with inspectors|
- Mentioned In
- T170027: [Regression pre-wmf.8] The bottom bar (Scrollbar area?) of Ace editor is overlapping with the language drop down
T169617: Find and replace menu overlaps editor switch
- Mentioned Here
- rGVEDc9b0d1a232fa: Workaround for nested toolbars hack being terrible
T128088: Flow editing toolbar should be at the top of the edit window
T167616: Edit notice renders behind content instead of on top (FOUC)
To check after the fix: since it's possible to do VE insert in Flow via cmd+?, the following needs to be checked.
(1) In Flow post, do additional checking for some other insert (hieroglyph, chemical or math formulas etc).
(2) Check for editing to see if the following has been fixed.
(3) the link inspector cannot be dismissed
This is actually more difficult than it looks like, since inspectors are in the same z-index "layer" as e.g. surface highlights and context menus. If we were to simply change the order so that toolbar (.ve-ui-toolbar > .oo-ui-toolbar-bar) has lower z-index than the overlay (.ve-ui-overlay), we'd instead get this:
|Inspector looks okay…|
|The context menu looks okay…|
|But toolbar menus are not okay|
Generally, the more I think about this, the more I feel that bottom-positioned toolbars are just fundamentally a bad idea. Consider the case in the third screenshot above – should we have the context menu cover the bottom toolbar (potentially making its tools inaccessible when the cursor is in the wrong place), or should we have the bottom toolbar cut off the context menu (potentially making its actions inaccessible)? Toolbars on top do not have this problem.
Actually, as far as I can tell, the broken behavior I described above is what was happening before my changes from T167616, and apparently everyone was happy with it in spite of the fundamental brokenness, so who am I to argue. I don't have Flow set up locally, so I'd appreciate if someone could verify that it was broken that way before (surface highlights appearing above open toolbar menus). If it was somehow working correctly, then we should revert the fixes for T167616 and then cry.