Page MenuHomePhabricator
Create Task
Maniphest T169132

Argument 2 passed to VisualEditorHooks::onDiffViewHeader() must be an instance of Revision, null given
Closed, ResolvedPublic1 Estimated Story PointsPRODUCTION ERROR
Actions

Description

In VisualEditorHooks:

Catchable fatal error: Argument 2 passed to VisualEditorHooks::onDiffViewHeader() must be an instance of Revision, null given in /srv/mediawiki/php-1.30.0-wmf.7/includes/Hooks.php on line 186

And RevisionSliderHooks:

Catchable fatal error: Argument 2 passed to RevisionSliderHooks::onDiffViewHeader() must be an instance of Revision, null given in /srv/mediawiki/php-1.30.0-wmf.7/includes/Hooks.php on line 186

The hook has a type hint but it needs to accept null for the revision arguments.

Details

SubjectRepoBranchLines +/-
Set onDiffViewHeader argument defaults = nullmediawiki/extensions/VisualEditorwmf/1.30.0-wmf.7+2 -2
Set onDiffViewHeader argument defaults = nullmediawiki/extensions/RevisionSliderwmf/1.30.0-wmf.7+2 -2
Set onDiffViewHeader argument defaults = nullmediawiki/extensions/VisualEditormaster+2 -2
VisualEditorHooks#onDiffViewHeader: Don't add type hint as the hook sucksmediawiki/extensions/VisualEditormaster+2 -2
VisualEditorHooks#onDiffViewHeader: Don't add type hint as the hook sucksmediawiki/extensions/VisualEditorwmf/1.30.0-wmf.7+2 -2
Customize query in gerrit

Related Objects
Search...

Event Timeline

• mmodell created this task.Jun 28 2017, 7:36 PM
Restricted Application added subscribers: Jay8g, TerraCodes, Aklapper. · View Herald TranscriptJun 28 2017, 7:36 PM
• mmodell added a parent task: T167536: MW-1.30.0-wmf.7 deployment blockers.Jun 28 2017, 7:36 PM
gerritbot subscribed.Jun 28 2017, 7:43 PM

Change 361938 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/VisualEditor@master] VisualEditorHooks#onDiffViewHeader: Don't add type hint as the hook sucks

https://gerrit.wikimedia.org/r/361938

gerritbot added a project: Patch-For-Review.Jun 28 2017, 7:43 PM
gerritbot added a comment.Jun 28 2017, 7:54 PM

Change 361941 had a related patch set uploaded (by 20after4; owner: Jforrester):
[mediawiki/extensions/VisualEditor@wmf/1.30.0-wmf.7] VisualEditorHooks#onDiffViewHeader: Don't add type hint as the hook sucks

https://gerrit.wikimedia.org/r/361941

gerritbot added a comment.Jun 28 2017, 8:01 PM

Change 361938 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] VisualEditorHooks#onDiffViewHeader: Don't add type hint as the hook sucks

https://gerrit.wikimedia.org/r/361938

gerritbot added a comment.Jun 28 2017, 8:12 PM

Change 361941 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@wmf/1.30.0-wmf.7] VisualEditorHooks#onDiffViewHeader: Don't add type hint as the hook sucks

https://gerrit.wikimedia.org/r/361941

• mmodell closed this task as Resolved.Jun 28 2017, 8:16 PM
• mmodell claimed this task.
Restricted Application added projects: User-Ryasmeen, Release-Engineering-Team (Kanban). · View Herald TranscriptJun 28 2017, 8:16 PM
Stashbot subscribed.Jun 28 2017, 8:17 PM

Mentioned in SAL (#wikimedia-operations) [2017-06-28T20:17:07Z] <twentyafterfour@tin> Synchronized php-1.30.0-wmf.7/extensions/VisualEditor/VisualEditor.hooks.php: sync https://gerrit.wikimedia.org/r/#/c/361941/ refs T169132 T167536 (duration: 00m 47s)

Stashbot mentioned this in T167536: MW-1.30.0-wmf.7 deployment blockers.Jun 28 2017, 8:17 PM
• mmodell reassigned this task from • mmodell to Jdforrester-WMF.Jun 28 2017, 8:23 PM
ReleaseTaggerBot added a project: MW-1.30-release-notes (WMF-deploy-2017-07-11_(1.30.0-wmf.9)).Jun 28 2017, 9:00 PM
gerritbot added a comment.Jun 28 2017, 9:16 PM

Change 362064 had a related patch set uploaded (by 20after4; owner: 20after4):
[mediawiki/extensions/VisualEditor@master] Set onDiffViewHeader argument defaults = null

https://gerrit.wikimedia.org/r/362064

gerritbot added a comment.Jun 28 2017, 9:21 PM

Change 362080 had a related patch set uploaded (by 20after4; owner: 20after4):
[mediawiki/extensions/RevisionSlider@master] Set onDiffViewHeader argument defaults = null

https://gerrit.wikimedia.org/r/362080

• mmodell mentioned this in rERSL048f7f9ff3fd: Set onDiffViewHeader argument defaults = null.Jun 28 2017, 9:21 PM
• mmodell added a comment.Jun 28 2017, 9:22 PM

Note this is also happening in Revision-Slider

• mmodell reopened this task as Open.Jun 28 2017, 9:24 PM
• mmodell lowered the priority of this task from Unbreak Now! to High.
• mmodell added a project: Revision-Slider.
• mmodell updated the task description. (Show Details)
Restricted Application added a project: TCB-Team (now WMDE-TechWish). · View Herald TranscriptJun 28 2017, 9:24 PM
• mmodell added a subscriber: matmarex.Jun 28 2017, 9:25 PM

A better fix as suggested by @matmarex:

VE:
https://gerrit.wikimedia.org/r/#/c/362064/
RevisionSlider:
https://gerrit.wikimedia.org/r/#/c/362080/

• mmodell claimed this task.Jun 28 2017, 9:26 PM
• mmodell added a subscriber: Jdforrester-WMF.
• mmodell moved this task from Backlog to In-progress on the Release-Engineering-Team (Kanban) board.Jun 28 2017, 9:31 PM
gerritbot added a comment.Jun 28 2017, 10:16 PM

Change 362064 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Set onDiffViewHeader argument defaults = null

https://gerrit.wikimedia.org/r/362064

gerritbot added a comment.Jun 29 2017, 4:44 AM

Change 362130 had a related patch set uploaded (by 20after4; owner: 20after4):
[mediawiki/extensions/VisualEditor@wmf/1.30.0-wmf.7] Set onDiffViewHeader argument defaults = null

https://gerrit.wikimedia.org/r/362130

gerritbot added a comment.Jun 29 2017, 5:03 AM

Change 362131 had a related patch set uploaded (by 20after4; owner: 20after4):
[mediawiki/extensions/RevisionSlider@wmf/1.30.0-wmf.7] Set onDiffViewHeader argument defaults = null

https://gerrit.wikimedia.org/r/362131

• mmodell mentioned this in rERSL05aa44c78472: Set onDiffViewHeader argument defaults = null.Jun 29 2017, 5:04 AM
Addshore mentioned this in rERSL0e04d903fb5b: Set onDiffViewHeader argument defaults = null.Jun 29 2017, 9:46 AM
gerritbot added a comment.Jun 29 2017, 3:52 PM

Change 362131 merged by jenkins-bot:
[mediawiki/extensions/RevisionSlider@wmf/1.30.0-wmf.7] Set onDiffViewHeader argument defaults = null

https://gerrit.wikimedia.org/r/362131

• mmodell closed this task as Resolved.Jun 29 2017, 7:12 PM
Jdforrester-WMF removed a project: Patch-For-Review.Jul 2 2017, 6:22 AM
Jdforrester-WMF set the point value for this task to 1.
Jdforrester-WMF moved this task from To Triage to TR0: Interrupt on the VisualEditor board.
gerritbot added a comment.Jul 8 2017, 12:23 AM

Change 362130 abandoned by Jforrester:
Set onDiffViewHeader argument defaults = null

Reason:
Not worth doing now.

https://gerrit.wikimedia.org/r/362130

• Phabricator_maintenance edited projects, added RelEng-Archive-FY201718-Q1; removed Release-Engineering-Team (Kanban).Sep 26 2017, 11:45 PM
Tobi_WMDE_SW moved this task from Incoming to Revision Slider on the TCB-Team (now WMDE-TechWish) board.Oct 10 2017, 9:39 AM
20after4 mentioned this in rERSL89c951c08cb4: Final NoteDb migration updates.Jun 10 2018, 3:30 AM
20after4 mentioned this in rERSL59d44f044cdf: Update patch set 1.
• mmodell changed the subtype of this task from "Task" to "Production Error".Aug 28 2019, 11:10 PM
thiemowmde removed a project: TCB-Team (now WMDE-TechWish).Jan 7 2022, 3:09 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL