I noticed a missing page in "On this day" endpoint event for 2008 on June 26:
https://en.wikipedia.org/api/rest_v1/feed/onthisday/events/06/26
Just load the link above and search for "pages": []
However, if you look at the page https://en.wikipedia.org/wiki/June_26 that event *does* have one link.
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Fix 'year page' identification bug. | mediawiki/services/mobileapps | master | +47 -8 |
@Mhurd The issue is that isAnchorNotForYear() filters out the anchor ./2008_Karmah_Bombing because it's starting with the same number as the year of the event.
function isAnchorNotForYear(anchor) {
return Math.abs(parseInt(anchor.title, 10)) !== Math.abs(year);
}parseInt('2008_Karmah_Bombing', 10) = 2008@bearND your diagnosis was correct! Thanks again for the tip! The gerrit commit above fixes the issue and adds tests as well.
Change 372909 had a related patch set uploaded (by Mhurd; owner: Mhurd):
[mediawiki/services/mobileapps@master] Fix 'year page' identification bug.
Change 372909 merged by jenkins-bot:
[mediawiki/services/mobileapps@master] Fix 'year page' identification bug.
Tested on iPad Pro with iOS 10.3.3, iPhone 7+ with iOS 10.3.3, and iPhone 4 with iOS 9.3.5 on App 5.6.1 (1206)
I'm not sure I did it right, but... I was able to find/click the "2008" links on the page listed in the original description.