Page MenuHomePhabricator

Expand "On this day" endpoint language support
Open, LowPublic1 Estimated Story Points

Description

Presently it supports English, German, Swedish and French.

Goal:

  • Add remaining 'top 10' wiki langs

Stretch goal:

  • Add at least one RTL lang

Also, audit added langs for missing 'date' pages. (Note: I have script for this somewhere...)


Added so far as part of this ticket:

  • Portuguese
  • Russian
  • Spanish
  • Arabic

Event Timeline

Also, audit added langs for missing 'date' pages. (Note: I have script for this somewhere...)

I've got a test for that in the repo. Needs to be enabled using an env variable.

There are a couple small-ish refactors I'll probably need to make before adding other langs.

(in on-this-day-languages.js I'll prob need to pass nameFormatter methods the monthNumber - Polish day and anniversary pages use month number not name. also should probably factor out the unicode dash character class which I added for Portuguese and use it for the other langs yearListElementRegEx too.)

There's also a parsoid bug https://phabricator.wikimedia.org/T173384#3542235 which will need to resolve before adding Polish.

Change 373159 had a related patch set uploaded (by Mhurd; owner: Mhurd):
[mediawiki/services/mobileapps@master] Add Portuguese to on this day endpoint.

https://gerrit.wikimedia.org/r/373159

Change 373159 merged by jenkins-bot:
[mediawiki/services/mobileapps@master] Add Portuguese to on this day endpoint.

https://gerrit.wikimedia.org/r/373159

Change 373748 had a related patch set uploaded (by Mhurd; owner: Mhurd):
[mediawiki/services/mobileapps@master] Add Russian to 'On this day' endpoint.

https://gerrit.wikimedia.org/r/373748

There's a test failing, but it doesn't appear to be related to On this day.

JMinor added a subscriber: JMinor.

Parked in Waiting for Build until updates are deployed to MCS. Please move back into QA once the updates are deployed/testable.

Change 373748 merged by jenkins-bot:
[mediawiki/services/mobileapps@master] Add Russian, Spanish and Arabic to 'On this day' endpoint.

https://gerrit.wikimedia.org/r/373748

It'll have to wait until Tuesday (9/5) at the earliest.

Mentioned in SAL (#wikimedia-operations) [2017-09-06T22:06:32Z] <bsitzmann@tin> Started deploy [mobileapps/deploy@507a479]: Update mobileapps to 2cb6281 (T168848 T169277 T169274 T162179 T164033 T167921 T174698 T168848 T174808)

Mentioned in SAL (#wikimedia-operations) [2017-09-06T22:11:25Z] <bsitzmann@tin> Finished deploy [mobileapps/deploy@507a479]: Update mobileapps to 2cb6281 (T168848 T169277 T169274 T162179 T164033 T167921 T174698 T168848 T174808) (duration: 04m 53s)

@ABorbaWMF @JMinor

Portuguese, Russian, Spanish and Arabic went live!

Testing criteria for each language above

  • switch device lang
  • clean install of app
  • should see an "On this day" item in the Explore feed for respective lang

@Mhurd I took a look at this on 5.6.1 (1212). Russian and Spanish looks good. Portuguese and Arabic still have some English characters: On this Day, Dates, etc

RussianSpanish
PostugueseArabic

Maybe it is still rolling out? Or maybe cached data?

@ABorbaWMF I think those are just strings TWN folks haven't translated yet, but I can double check tomorrow. Thanks!

Testing on iPhone 7 (iOS 10.3.1) and Wikipedia app 5.6.1 (1212). I'll post screencaps and let the staff decide if the results are fixed.

The fix for T173384 is deployed. Now we could add Polish, too.

LGoto raised the priority of this task from Low to Medium.Aug 1 2018, 3:45 PM

FWIW, bswiki has also been added since then due to some help from a volunteer.

JMinor raised the priority of this task from Medium to Needs Triage.Feb 11 2019, 7:53 PM

carolyn found an android mailing list post asking about on-this-day for other langs.

added details in a reply here:
https://www.mediawiki.org/w/index.php?title=Topic:Ulh3p09eog4w6z1y&topic_showPostId=veyjnt131crupooi#flow-post-veyjnt131crupooi

Mhurd removed Mhurd as the assignee of this task.Jul 23 2020, 8:46 PM