As was discussed in T170156: Should we indicate to users that visual diffs are in beta?, we should inform users that visual diffs are in beta, and provide users a way to give feedback.
A mockup of the solution decided in that task:
As was discussed in T170156: Should we indicate to users that visual diffs are in beta?, we should inform users that visual diffs are in beta, and provide users a way to give feedback.
A mockup of the solution decided in that task:
Status | Subtype | Assigned | Task | ||
---|---|---|---|---|---|
Resolved | Tchanders | T170665 Inform users inside the editor that visual diffs are in beta | |||
Resolved | • Whatamidoing-WMF | T174964 Support the Editing team with communications about the beta status of visual diffs |
Thinking about implement this - dialog headers and footers are currently reserved for dialog actions - which trigger a specific bit of code (#getActionProcess). Trying to turn one of those buttons into an external link might be a bit tricky, and inconsistent with how the dialogs were designed to work. Pinging @matmarex.
If you put a 'href' key in a .static.actions item, I'm pretty sure that will work. Although you might need to do something weird to remove the event handlers from the ActionWidget…
Alternatively, just create a normal ButtonWidget and stick it inside this.$foot in initialize()?
That's going to be a pain because we make use of dialog modes to hide/show various buttons on various pages.
If it's going to be difficult to add the button at the bottom, we can add the beta label first then add the button later. That's not ideal, but it is an improvement over the current situation where users are not informed at all.
We could also be lazy and just give the button an action that does window.open( … )… shrug.
Change 371517 had a related patch set uploaded (by Tchanders; owner: Tchanders):
[mediawiki/extensions/VisualEditor@master] Inform users visual diffs are in beta
Change 371517 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Inform users visual diffs are in beta
Change 374636 had a related patch set uploaded (by Tchanders; owner: Tchanders):
[mediawiki/extensions/VisualEditor@master] WIP Add feedback link for visual diff
@Whatamidoing-WMF Should the feedback link go here? https://www.mediawiki.org/wiki/Talk:VisualEditor/Diffs
Change 374636 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Add feedback link for visual diff inside save dialog