⚓ T171636 Some areas of Query Service are not translatable

	Subject	Repo	Branch	Lines +/-
	Make charts, placeholder and summary translatable	wikidata/query/gui	master	+118 -20

		Status	Subtype	Assigned	Task
		Resolved		Albert221	T171636 Some areas of Query Service are not translatable
		Resolved		None	T168655 Query service UI editor placeholder is not translated

Lea_Lacroix_WMDE created this task.Jul 25 2017, 6:29 PM

Restricted Application added a project: Discovery-ARCHIVED. · View Herald TranscriptJul 25 2017, 6:29 PM

Restricted Application added subscribers: PokestarFan, Aklapper. · View Herald Transcript

Smalyshev moved this task from Incoming to GUI on the Wikidata-Query-Service board.Jul 25 2017, 6:52 PM

Aklapper added a project: I18n.Jul 27 2017, 11:38 PM

• Jonas added projects: good first task, patch-welcome.Jul 31 2017, 9:45 AM

Restricted Application added a subscriber: TerraCodes. · View Herald TranscriptJul 31 2017, 9:45 AM

Lea_Lacroix_WMDE renamed this task from Two areas of Query Service are not translatable to Some areas of Query Service are not translatable.Aug 2 2017, 11:13 AM

Lea_Lacroix_WMDE updated the task description. (Show Details)

Lucas_Werkmeister_WMDE added a subtask: T168655: Query service UI editor placeholder is not translated.Aug 2 2017, 11:27 AM

Lucas_Werkmeister_WMDE updated the task description. (Show Details)

The "ms" part of "some results in some ms" seems to be from CLDR?

In T171636#3864248, @Liuxinyu970226 wrote:

The "ms" part of "some results in some ms" seems to be from CLDR?

I don’t think so – it seems to be entirely hardcoded in index.html and embed.html:

<span class="label label-default"><span id="total-results"></span> Results in <span id="query-time"></span> ms </span></span> &nbsp;

• Jonas added a project: Google-Code-in-2017.Jan 4 2018, 5:52 PM

• Jonas added a subscriber: eflyjason.

Aklapper moved this task from Proposed tasks to Imported in GCI Site on the Google-Code-in-2017 board.Jan 4 2018, 11:04 PM

Albert221 claimed this task.Jan 5 2018, 12:18 AM

Change 402391 had a related patch set uploaded (by Albert221; owner: Albert221):
[wikidata/query/gui@master] Make charts, placeholder and summary translatable

https://gerrit.wikimedia.org/r/402391

gerritbot added a project: Patch-For-Review.Jan 5 2018, 5:13 PM

I've fixed everything that was mentioned and also improved capitalizations of letters for chart types.

Editor placeholder is set 1 second after initialization of Editor (on change too), because it occurs before $.i18n populates placeholder attribute with internationalized string. I tested this on *Fast 3G* network throttling on Chrome and it works fine. On *Slow 3G* it doesn't work, but website loads for 2.5 minutes and is so slow that's unusable so I don't think it's an issue.

Albert221 mentioned this in rWDQGc6dd4cf5143f: Make charts, placeholder and summary translatable.Jan 5 2018, 5:17 PM

Albert221 mentioned this in rWDQG2ec80ec6bef1: Make charts, placeholder and summary translatable.Jan 5 2018, 6:02 PM

Albert221 mentioned this in rWDQGdced31a6fe0f: Make charts, placeholder and summary translatable.Jan 5 2018, 10:35 PM

Albert221 mentioned this in rWDQGe6d20abb3478: Make charts, placeholder and summary translatable.Jan 5 2018, 10:45 PM

Albert221 mentioned this in rWDQGe53557668e2d: Make charts, placeholder and summary translatable.

Albert221 mentioned this in rWDQG48a99124e9a0: Make charts, placeholder and summary translatable.Jan 6 2018, 12:57 PM

Albert221 mentioned this in rWDQGa4b3b69ff9a5: Make charts, placeholder and summary translatable.Jan 7 2018, 12:17 AM

Albert221 mentioned this in rWDQG08ffae04da4f: Make charts, placeholder and summary translatable.Jan 8 2018, 1:59 PM

• Jonas triaged this task as Low priority.Jan 9 2018, 10:48 AM

• Jonas edited projects, added Wikidata Query UI; removed Wikidata-Query-Service.

• Jonas moved this task from Backlog to Done on the Wikidata Query UI board.

Change 402391 merged by jenkins-bot:
[wikidata/query/gui@master] Make charts, placeholder and summary translatable