Page MenuHomePhabricator

Timeless skin uses deprecated/removed $.event.props.concat
Closed, ResolvedPublic

Description

I noticed a jQuery 3 migrate warning which seems to be due to the usage of $.event.props in skins.timeless.mobile module.

$.event.props was removed in jQuery 3 (although restored as deprecated by jQuery Migrate)

https://github.com/jquery/jquery-migrate/blob/3516868c56456b3d1c9de0bbe50de636a328fab7/warnings.md#jqmigrate-jqueryeventprops-are-deprecated-and-removed

Event Timeline

Change 371508 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/skins/Timeless@master] Update jQuery Mobile to 1.5 (alpha)

https://gerrit.wikimedia.org/r/371508

Krinkle renamed this task from Timeless skin uses deprecated $.event.props.concat to Timeless skin uses deprecated/removed $.event.props.concat.Aug 30 2017, 3:34 PM
Krinkle updated the task description. (Show Details)
Krinkle added a subscriber: Krinkle.

Re-parenting because this property is restored by jQuery Migrate, thus not blocking jQuery 3 upgrade.

Change 371508 merged by jenkins-bot:
[mediawiki/skins/Timeless@master] Update jQuery Mobile to 1.5 (alpha)

https://gerrit.wikimedia.org/r/371508

matmarex claimed this task.