Page MenuHomePhabricator

jQuery 3 migration warnings
Closed, ResolvedPublic

Description

Following the upgrade to jQuery 3 and jQuery Migrate 3, this task will track sub tasks for addressing one or more migration warnings about functionality that was deprecated or removed in jQuery 3, but remains functional with the migrate plugin.

See also:

Details

SubjectRepoBranchLines +/-
mediawiki/coremaster+14 -9
mediawiki/extensions/TimedMediaHandlermaster+2 -1
mediawiki/extensions/TimedMediaHandlermaster+10 -10
mediawiki/corewmf/1.31.0-wmf.2+8 -4
mediawiki/extensions/TimedMediaHandlermaster+50 -50
mediawiki/coremaster+8 -4
mediawiki/extensions/TimedMediaHandlerwmf/1.31.0-wmf.2+1 -1
mediawiki/extensions/TimedMediaHandlermaster+1 -1
mediawiki/extensions/LiquidThreadsmaster+4 -4
mediawiki/extensions/PageTriagemaster+4 -4
mediawiki/extensions/TimedMediaHandlerwmf/1.31.0-wmf.2+1 -1
mediawiki/extensions/TimedMediaHandlermaster+1 -1
mediawiki/extensions/EventLoggingmaster+20 -9
mediawiki/extensions/Wikibasemaster+3 -3
mediawiki/extensions/SVGEditmaster+4 -4
mediawiki/extensions/Collectionmaster+9 -9
mediawiki/extensions/CodeReviewmaster+6 -6
mediawiki/extensions/MwEmbedSupportmaster+9 -9
mediawiki/extensions/Translatemaster+3 -3
mediawiki/extensions/AbuseFiltermaster+2 -2
Show related patches Customize query in gerrit

Related Objects

StatusSubtypeAssignedTask
ResolvedKrinkle
ResolvedCatrope
ResolvedJdforrester-WMF
Resolvedmatmarex
DeclinedNone
ResolvedNikerabbit
ResolvedKrinkle
DeclinedNone
ResolvedKrinkle
ResolvedNikerabbit
Resolvedmatmarex
ResolvedNikerabbit
ResolvedPcoombe
Resolvedrafidaslam
ResolvedABorbaWMF
ResolvedLucas_Werkmeister_WMDE
ResolvedLadsgroup
InvalidDannyS712

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes

Change 371017 had a related patch set uploaded (by Alex Monk; owner: Alex Monk):
[mediawiki/extensions/Collection@master] Use prop instead of removeAttr

https://gerrit.wikimedia.org/r/371017

Change 371018 had a related patch set uploaded (by Alex Monk; owner: Alex Monk):
[mediawiki/extensions/MwEmbedSupport@master] Use .length instead of .size() as it's getting removed in jQuery 3.0

https://gerrit.wikimedia.org/r/371018

Change 371019 had a related patch set uploaded (by Alex Monk; owner: Alex Monk):
[mediawiki/extensions/SVGEdit@master] Use prop instead of removeAttr

https://gerrit.wikimedia.org/r/371019

Change 371024 had a related patch set uploaded (by Alex Monk; owner: Alex Monk):
[mediawiki/extensions/Translate@master] Use .length instead of .size() as it's getting removed in jQuery 3.0

https://gerrit.wikimedia.org/r/371024

Change 371026 had a related patch set uploaded (by Alex Monk; owner: Alex Monk):
[mediawiki/extensions/Wikibase@master] Use prop instead of removeAttr

https://gerrit.wikimedia.org/r/371026

Change 371024 merged by jenkins-bot:
[mediawiki/extensions/Translate@master] Use .length instead of .size() as it's getting removed in jQuery 3.0

https://gerrit.wikimedia.org/r/371024

Change 371026 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Use prop instead of removeAttr

https://gerrit.wikimedia.org/r/371026

Change 371018 merged by jenkins-bot:
[mediawiki/extensions/MwEmbedSupport@master] Use .length instead of .size() as it's getting removed in jQuery 3.0

https://gerrit.wikimedia.org/r/371018

Change 371016 merged by jenkins-bot:
[mediawiki/extensions/CodeReview@master] Use .length instead of .size() as it's getting removed in jQuery 3.0

https://gerrit.wikimedia.org/r/371016

Change 371017 merged by jenkins-bot:
[mediawiki/extensions/Collection@master] Use prop instead of removeAttr

https://gerrit.wikimedia.org/r/371017

Change 371019 merged by jenkins-bot:
[mediawiki/extensions/SVGEdit@master] Use prop instead of removeAttr

https://gerrit.wikimedia.org/r/371019

Change 378804 had a related patch set uploaded (by Krinkle; owner: Krinkle):
[mediawiki/extensions/EventLogging@master] ext.eventLogging.subscriber: Don't wait for "load" if it already happened

https://gerrit.wikimedia.org/r/378804

Change 379452 had a related patch set uploaded (by Krinkle; owner: Krinkle):
[mediawiki/extensions/TimedMediaHandler@master] Use jQuery on/off instead of deprecated bind/unbind

https://gerrit.wikimedia.org/r/379452

Change 379452 merged by jenkins-bot:
[mediawiki/extensions/TimedMediaHandler@master] Use jQuery on/off instead of deprecated bind/unbind

https://gerrit.wikimedia.org/r/379452

Change 378804 merged by jenkins-bot:
[mediawiki/extensions/EventLogging@master] ext.eventLogging.subscriber: Don't wait for "load" if it already happened

https://gerrit.wikimedia.org/r/378804

Change 382087 had a related patch set uploaded (by Krinkle; owner: Krinkle):
[mediawiki/extensions/TimedMediaHandler@master] Fix jQuery.fn.bind() call in mw.MediaWikiPlayer.loader.js

https://gerrit.wikimedia.org/r/382087

Change 382088 had a related patch set uploaded (by Krinkle; owner: Krinkle):
[mediawiki/extensions/TimedMediaHandler@wmf/1.30.0-wmf.19] Fix jQuery.fn.bind() call in mw.MediaWikiPlayer.loader.js

https://gerrit.wikimedia.org/r/382088

Change 382088 abandoned by Krinkle:
Fix jQuery.fn.bind() call in mw.MediaWikiPlayer.loader.js

https://gerrit.wikimedia.org/r/382088

Change 382089 had a related patch set uploaded (by Krinkle; owner: Krinkle):
[mediawiki/extensions/TimedMediaHandler@wmf/1.31.0-wmf.2] Fix jQuery.fn.bind() call in mw.MediaWikiPlayer.loader.js

https://gerrit.wikimedia.org/r/382089

Change 382087 merged by jenkins-bot:
[mediawiki/extensions/TimedMediaHandler@master] Fix jQuery.fn.bind() call in mw.MediaWikiPlayer.loader.js

https://gerrit.wikimedia.org/r/382087

Change 382089 merged by jenkins-bot:
[mediawiki/extensions/TimedMediaHandler@wmf/1.31.0-wmf.2] Fix jQuery.fn.bind() call in mw.MediaWikiPlayer.loader.js

https://gerrit.wikimedia.org/r/382089

Change 382191 had a related patch set uploaded (by Krinkle; owner: Krinkle):
[mediawiki/extensions/TimedMediaHandler@master] Use prop(, false) instead of removeAttr() to change properties

https://gerrit.wikimedia.org/r/382191

Change 382194 had a related patch set uploaded (by Krinkle; owner: Krinkle):
[mediawiki/extensions/LiquidThreads@master] Use on() instead of deprecated on()

https://gerrit.wikimedia.org/r/382194

Change 382196 had a related patch set uploaded (by Krinkle; owner: Krinkle):
[mediawiki/extensions/PageTriage@master] Change use of deprecated jQuery.fn.hover() to on()

https://gerrit.wikimedia.org/r/382196

Change 382196 merged by jenkins-bot:
[mediawiki/extensions/PageTriage@master] Change use of deprecated jQuery.fn.hover() to on()

https://gerrit.wikimedia.org/r/382196

Change 382194 merged by jenkins-bot:
[mediawiki/extensions/LiquidThreads@master] Use on() instead of deprecated bind()

https://gerrit.wikimedia.org/r/382194

Change 382191 merged by jenkins-bot:
[mediawiki/extensions/TimedMediaHandler@master] Use prop(, false) instead of removeAttr() to change properties

https://gerrit.wikimedia.org/r/382191

Change 382319 had a related patch set uploaded (by Krinkle; owner: Krinkle):
[mediawiki/extensions/TimedMediaHandler@wmf/1.31.0-wmf.2] Use prop(, false) instead of removeAttr() to change properties

https://gerrit.wikimedia.org/r/382319

Change 382319 merged by jenkins-bot:
[mediawiki/extensions/TimedMediaHandler@wmf/1.31.0-wmf.2] Use prop(, false) instead of removeAttr() to change properties

https://gerrit.wikimedia.org/r/382319

Mentioned in SAL (#wikimedia-operations) [2017-10-04T23:53:49Z] <catrope@tin> Synchronized php-1.31.0-wmf.2/extensions/TimedMediaHandler/MwEmbedModules/EmbedPlayer/resources/jquery.embedPlayer.js: Fix jqmigrate warning (T169385) (duration: 00m 50s)

Change 382553 had a related patch set uploaded (by Krinkle; owner: Krinkle):
[mediawiki/core@master] jquery.ui: Fix various jQuery Migrate warnings

https://gerrit.wikimedia.org/r/382553

Change 382553 merged by jenkins-bot:
[mediawiki/core@master] jquery.ui: Fix various jQuery Migrate warnings

https://gerrit.wikimedia.org/r/382553

Change 382768 had a related patch set uploaded (by Krinkle; owner: Krinkle):
[mediawiki/core@wmf/1.31.0-wmf.2] jquery.ui: Fix various jQuery Migrate warnings

https://gerrit.wikimedia.org/r/382768

Change 382768 merged by jenkins-bot:
[mediawiki/core@wmf/1.31.0-wmf.2] jquery.ui: Fix various jQuery Migrate warnings

https://gerrit.wikimedia.org/r/382768

Change 391991 had a related patch set uploaded (by Krinkle; owner: Krinkle):
[mediawiki/extensions/TimedMediaHandler@master] mw.MediaWikiPlayerSupport: Fix more .bind() deprecation warnings

https://gerrit.wikimedia.org/r/391991

Change 391991 merged by jenkins-bot:
[mediawiki/extensions/TimedMediaHandler@master] mw.MediaWikiPlayerSupport: Fix more jQuery 3 deprecation warnings

https://gerrit.wikimedia.org/r/391991

Change 392574 had a related patch set uploaded (by Brion VIBBER; owner: Brion VIBBER):
[mediawiki/extensions/TimedMediaHandler@master] Fix audio/video player regression

https://gerrit.wikimedia.org/r/392574

Change 392574 merged by jenkins-bot:
[mediawiki/extensions/TimedMediaHandler@master] Fix audio/video player regression

https://gerrit.wikimedia.org/r/392574

Change 429534 had a related patch set uploaded (by Krinkle; owner: Krinkle):
[mediawiki/core@master] jquery.ui: Use on() instead of deprecated bind() in jquery.ui.mouse

https://gerrit.wikimedia.org/r/429534

Change 429534 merged by jenkins-bot:
[mediawiki/core@master] jquery.ui: Use on() instead of deprecated bind() in jquery.ui.mouse

https://gerrit.wikimedia.org/r/429534

Krinkle claimed this task.

Closing this out for now as it has become an open-ended tracking task which has outlives its usefulness I think. Some of the sub tasks are still open and we can continue to file new tasks as-needed and organise those on the workboards where they belong and can be worked on. I fear the tracking task gives a false sense of progress and ownership.