Popups should not use deprecated method jQuery.fn.hover()
Closed, ResolvedPublic
Actions

Description

This task is about MediaWiki's Popups extension (which is sometimes also called "Page-Previews" or "Hovercards").

The line preview.el.hover( behavior.previewDwell, behavior.previewAbandon ); in the file src/ui/renderer.js causes a warning in the console of your web browser's developer tools:

JQMIGRATE: jQuery.fn.hover() is deprecated

See https://github.com/jquery/jquery-migrate/blob/3.0.1/warnings.md for documentation how to replace it.
For anyone who plans to work on this, https://gerrit.wikimedia.org/r/#/c/381780/ and https://gerrit.wikimedia.org/r/#/c/382196/ are similar merged patches.

Developer notes

The Popups extension uses a build process.
After making your change you'll need to run the following code

npm install
npm run build

and commit the dist folder as part of your patch.

Testing criteria

Test that page previews:

appear and disappear normally
settings open and close
note any strange behavior

note: for this, it's not necessary to go through the entirety of the test cases

Details

	Subject	Repo	Branch	Lines +/-
	Fix $.fn.hover is deprecated	mediawiki/extensions/Popups	master	+4 -3

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		Krinkle	T169385 jQuery 3 migration warnings
		Resolved		ABorbaWMF	T180861 Popups should not use deprecated method jQuery.fn.hover()

Event Timeline

He7d3r created this task.Nov 18 2017, 12:10 AM

Restricted Application added subscribers: Enterprisey, Aklapper. · View Herald TranscriptNov 18 2017, 12:10 AM

Aklapper added a project: Technical-Debt.Nov 19 2017, 9:49 PM

Aklapper added a parent task: T169385: jQuery 3 migration warnings.Nov 20 2017, 12:58 PM

Would someone volunteer to mentor this task in Google-Code-in-2017 ? If so, please see https://www.mediawiki.org/wiki/Google_Code-in/2017 - thanks!

Aklapper moved this task from Proposed tasks to Missing mentors on the Google-Code-in-2017 board.Nov 20 2017, 1:01 PM

Aklapper added a project: good first task.

Restricted Application added a subscriber: TerraCodes. · View Herald TranscriptNov 20 2017, 1:01 PM

This might also be related to T118124: Stop using jquery.tipsy for HTMLCheckMatrix labels (seen on Special:Preferences with Echo) (both deal with the popups on Special:Preferences)

I would like to volunteer as a mentor for this task. Google-Code-in-2017

Move to the right popups/preview tag.

@Abhi_hk95: Thanks. For GCI, we welcome experienced community members who are already familiar with our workflows and infrastructure, and who can guide new contributors. I cannot find your activity in Phabricator, on Wikimedia wikis, or in Wikimedia code repositories. If there is, please let us know where to find it. :)

Jdlrobson added a project: Web-Team-Backlog.Nov 30 2017, 5:11 PM

Jdlrobson updated the task description. (Show Details)

Jdlrobson moved this task from Incoming to Triaged but Future on the Web-Team-Backlog board.Nov 30 2017, 6:54 PM

@Aklapper I can mentor this task for GCI. I'll import it.

Aklapper updated the task description. (Show Details)Dec 5 2017, 3:46 PM

@Harjotsingh: Thanks! Imported as https://codein.withgoogle.com/tasks/6694438434766848/

Change 395651 had a related patch set uploaded (by Albert221; owner: Albert221):
[mediawiki/extensions/Popups@master] Fix $.fn.hover is deprecated

https://gerrit.wikimedia.org/r/395651

gerritbot added a project: Patch-For-Review.Dec 5 2017, 10:35 PM

Adding to sprint for visibility. Task is being worked on my Google Code in student.

Change 395651 merged by jenkins-bot:
[mediawiki/extensions/Popups@master] Fix $.fn.hover is deprecated

https://gerrit.wikimedia.org/r/395651

ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2017-12-12 (1.31.0-wmf.12)).Dec 6 2017, 1:00 AM

ovasileva triaged this task as Medium priority.Dec 6 2017, 10:26 AM

• Niedzielski subscribed.Dec 6 2017, 6:02 PM

Jdlrobson assigned this task to ABorbaWMF.Dec 6 2017, 6:10 PM

Jdlrobson moved this task from To Do to Needs QA on the Readers-Web-Kanbanana-Board-Old board.

Jdlrobson removed a project: Patch-For-Review.

Jdlrobson updated the task description. (Show Details)

ovasileva removed ABorbaWMF as the assignee of this task.Dec 6 2017, 6:12 PM

ovasileva assigned this task to ABorbaWMF.

ovasileva updated the task description. (Show Details)

ovasileva added a subscriber: ABorbaWMF.

Jdlrobson moved this task from Triaged but Future to 2017-18 Q2 on the Web-Team-Backlog board.Dec 11 2017, 5:54 PM

Resolving based on beta cluster testing from T182399: QA html previews on beta cluster

Jdlrobson moved this task from Needs QA to Ready for Signoff on the Readers-Web-Kanbanana-Board-Old board.Dec 11 2017, 6:15 PM

Popups should not use deprecated method jQuery.fn.hover()Closed, ResolvedPublicActions