| matmarex | |
| Nov 8 2015, 4:22 PM |
| F36972783: image.png | |
| May 2 2023, 7:22 PM |
| F25275421: image.png | |
| Aug 23 2018, 10:43 PM |
| F8610968: firefox_2017-07-03_10-59-56.png | |
| Jul 3 2017, 7:00 PM |
| F8610920: firefox_2017-07-03_10-54-15.png | |
| Jul 3 2017, 6:54 PM |
| F2946835: pasted_file | |
| Nov 10 2015, 2:15 AM |
Stop using jquery.tipsy for HTMLCheckMatrix labels.
$matrixTooltips = $root.find( '.mw-htmlform-matrix .mw-htmlform-tooltip' );
if ( $matrixTooltips.length ) {
mw.loader.using( 'jquery.tipsy', function () {
$matrixTooltips.tipsy( { gravity: 's' } );
} );
}| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Remove last usage of jquery.tipsy in core | mediawiki/core | master | +0 -17 |
@matmarex: What else to use, if someone wanted to work on this? Is this an good first task / GCI task or rather not? Technical-Debt?
Replicating the current behavior using OOjs UI would require T88630 first (or a custom solution).
Is Echo currently the only user of this? We could probably surface this info in a different way...
Is this what causes the warning
This page is using the deprecated ResourceLoader module "jquery.tipsy".
This is Resolved in OOUI mode by way of T199946: Checkboxes for local overrides added by GlobalPrefs extension do not work as expected with OOUI:
Should we keep this open until the non-OOUI code is deleted?
I think it can be ported to OOUI at any moment, provided someone does the work.
As far as I know there isn't any remaining use of 'checkmatrix' field in non-OOUI mode on Wikimedia wikis, so this wasn't a priority for anyone.
In case someone wants to work on this now, here's the minimal code to test this feature (on a special page etc.):
$form = HTMLForm::factory( 'table', [ 'foo' => [ 'type' => 'checkmatrix', 'rows' => [ 'A' => 'a' ], 'columns' => [ 'B' => 'b' ], 'tooltips' => [ 'A' => 'aaaa' ], ] ], $this->getContext() ); $form->show();
Which displays a tiny form like this, currently still using a 'jquery.tipsy' tooltip:
Considering that (probably) nothing uses this code now, it might be acceptable to just remove the JS code that adds the tipsy tooltips, and leave behind plain HTML title attributes.
Change 915866 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):
[mediawiki/core@master] Remove last usage of jquery.tipsy in core
Change 915866 merged by jenkins-bot:
[mediawiki/core@master] Remove last usage of jquery.tipsy in core
