Page MenuHomePhabricator

Remove use of jquery.tipsy from Wikimedia-maintained code
Closed, ResolvedPublic

Description

jquery.tipsy is pretty old, pretty awkward and pretty ugly. We should stop using it in our interfaces. OOUI's popups implement most of the features we'd want.
For simple contents a title attribute without payload of an extra JS dependency is sufficient as well.

We deprecated the module in 2017 as part of T142418

(Old/minimal documentation page at https://www.mediawiki.org/wiki/Tipsy )

Related Objects

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes
Jdforrester-WMF renamed this task from Stop using jquery.tipsy to Stop using jquery.tipsy in Wikimedia-maintained code.Aug 15 2016, 6:57 PM
Jdforrester-WMF triaged this task as Low priority.
Jdforrester-WMF set Security to None.

Gadgets (and possibly even user scripts) should be taken into consideration as well before tipsy is completely removed. Will require Notice.

Krinkle renamed this task from Stop using jquery.tipsy in Wikimedia-maintained code to Remove use of jquery.tipsy from Wikimedia-maintained code.Aug 15 2016, 10:51 PM
Krinkle moved this task from Unsorted to Migrate / Replace on the Technical-Debt board.

As the on Commons:MediaWiki in time most active competent script user @Rillke is now inactive and he used $.tipsy widely on some gadgets, it needs a real documentation for replacement!? It is a bit annoying that gadgets get not working, for example https://commons.wikimedia.org/wiki/MediaWiki:Gadget-GlobalUsage.js

I really hope tipsy support will stay until a good replacement comes, because it can do something beautiful that title attribute can't, tooltip in desktop browser version on mobiles and tablets. And because wikimedia registered users usually work there on desktop version, knowing that mobile version is good for anonym readers, but has not enough functionality for editors, it can be a very breaking change.

Jdlrobson added a subscriber: Jdlrobson.

I'm hoping to remove jquery.tipsy from MMV soon which means Wikibase would be the only remaining consuming. Wikibase can maintain a local version of the library if moving away from it is too difficult.

That will leave 722 gadgets that need updating:
https://global-search.toolforge.org/?q=jquery%5C.tipsy&regex=1&namespaces=&title=

So suggested remaining work:

  1. Merge fix for https://phabricator.wikimedia.org/T77402
  2. Run user notice for communities to copy across their own module.
  3. Update Wikibase
  4. Fix T118124
  5. Remove in MediaWiki 1.41

Change 915867 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/core@master] Remove jquery.tipsy from core

https://gerrit.wikimedia.org/r/915867

Change 915868 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/Wikibase@master] Add local version of jquery.tipsy

https://gerrit.wikimedia.org/r/915868

Change 915868 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Add local version of jquery.tipsy

https://gerrit.wikimedia.org/r/915868

Announcement is in: T336019
I'm looking to merge https://gerrit.wikimedia.org/r/915867 on the 18th May.

Change 915867 merged by jenkins-bot:

[mediawiki/core@master] resources: Remove jquery.tipsy, deprecated since 1.28

https://gerrit.wikimedia.org/r/915867

Jdlrobson closed this task as Resolved.EditedMay 16 2023, 6:32 PM
Jdlrobson claimed this task.

Now done. I've updated T336019 with details on mitigation strategies for broken gadgets.

Skin style removal tracked in T282547.

Change 991053 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/core@master] .eslintignore: Remove jquery.tipsy reference

https://gerrit.wikimedia.org/r/991053

Change 991053 merged by jenkins-bot:

[mediawiki/core@master] .eslintignore: Remove jquery.tipsy reference

https://gerrit.wikimedia.org/r/991053