jquery.tipsy is referenced by Wikidata Add link interface
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

Authored By

	stjn
	Jun 28 2023, 12:40 AM

Description

In Add link interface of Wikidata on the page https://ru.wikipedia.org/wiki/Feelings?uselang=en —
(I entered https://en.wikipedia.org/wiki/Feelings_(disambiguation) in both fields and tried to submit the form)

jQuery.Deferred exception: this.element.tipsy is not a function 
_create@https://ru.wikipedia.org/wiki/Feelings line 10 > injectedScript:21:385
$.widget/</prototype[prop]@https://ru.wikipedia.org/w/load.php?lang=ru&modules=jquery%2Coojs-ui-core%2Coojs-ui-widgets%7Cjquery.ui&skin=vector&version=13d05:415:310
_createWidget@https://ru.wikipedia.org/w/load.php?lang=ru&modules=jquery%2Coojs-ui-core%2Coojs-ui-widgets%7Cjquery.ui&skin=vector&version=13d05:418:389
$.widget/$[namespace][name]@https://ru.wikipedia.org/w/load.php?lang=ru&modules=jquery%2Coojs-ui-core%2Coojs-ui-widgets%7Cjquery.ui&skin=vector&version=13d05:414:667
$.widget.bridge/$.fn[name]/<@https://ru.wikipedia.org/w/load.php?lang=ru&modules=jquery%2Coojs-ui-core%2Coojs-ui-widgets%7Cjquery.ui&skin=vector&version=13d05:417:491
each@https://ru.wikipedia.org/w/load.php?lang=ru&modules=jquery%2Coojs-ui-core%2Coojs-ui-widgets%7Cjquery.ui&skin=vector&version=13d05:5:285
each@https://ru.wikipedia.org/w/load.php?lang=ru&modules=jquery%2Coojs-ui-core%2Coojs-ui-widgets%7Cjquery.ui&skin=vector&version=1…

Caused by T117720: Remove use of jquery.tipsy from Wikimedia-maintained code in some way that I cannot debug at the current moment.

Details

	Subject	Repo	Branch	Lines +/-
	Create a local copy of jQuery.tipsy for wbtooltip	mediawiki/extensions/Wikibase	master	+368 -0

Customize query in gerrit

Related Objects

Mentioned In: T117720: Remove use of jquery.tipsy from Wikimedia-maintained code
Mentioned Here: T337081: "Add interlanguage link" shows a bubble: "An unknown error occurred"
T117720: Remove use of jquery.tipsy from Wikimedia-maintained code

Event Timeline

stjn created this task.Jun 28 2023, 12:40 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 28 2023, 12:40 AM

stjn mentioned this in T117720: Remove use of jquery.tipsy from Wikimedia-maintained code.Jun 28 2023, 12:40 AM

Were you logged in or out? T337081#8926604 may be relevant.

It may also be caching? Everything functioned as expected for me.

Logged in of course. Same problem with caching disabled via devtools, so probably not caching.

Edit: also with ?safemode=1, so not a gadget issue either.

stjn updated the task description. (Show Details)Jun 28 2023, 1:57 AM

I think this is related to T337081: "Add interlanguage link" shows a bubble: "An unknown error occurred". Wikibase has a local copy of jquery.tipsy in view/, but we try to use it from both view/ and client/, so the client/ version is broken because it’s missing the local copy. We probably need to add the local copy to the jquery.wikibase.linkitem module? cc @hoo

Change 934327 had a related patch set uploaded (by Hoo man; author: Hoo man):

[mediawiki/extensions/Wikibase@master] Create a local copy of jQuery.tipsy for wbtooltip

https://gerrit.wikimedia.org/r/934327

gerritbot added a project: Patch-For-Review.Jun 29 2023, 1:00 PM

In T340602#8970944, @Lucas_Werkmeister_WMDE wrote:

I think this is related to T337081: "Add interlanguage link" shows a bubble: "An unknown error occurred". Wikibase has a local copy of jquery.tipsy in view/, but we try to use it from both view/ and client/, so the client/ version is broken because it’s missing the local copy. We probably need to add the local copy to the jquery.wikibase.linkitem module? cc @hoo

Indeed, we have a local copy of our wbtooltip in client, but didn't provide it with its dependency ($.tipsy).

Also worth mentioning that, as far as I can tell, linkitem only uses wbtooltip in error handlers. So only the error case would’ve been affected (users wouldn’t see the error message properly), but successful linking should still be possible.

Change 934327 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Create a local copy of jQuery.tipsy for wbtooltip

https://gerrit.wikimedia.org/r/934327

ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.16; 2023-07-04).Jun 29 2023, 5:00 PM

Maintenance_bot removed a project: Patch-For-Review.Jun 29 2023, 5:10 PM

I think this is done? Please reopen if the problem persists.

Restricted Application added a subscriber: Base. · View Herald TranscriptMar 6 2024, 9:30 AM

jquery.tipsy is referenced by Wikidata Add link interfaceClosed, ResolvedPublicBUG REPORTActions

Description

Details

Related Objects

Event Timeline

jquery.tipsy is referenced by Wikidata Add link interface
Closed, ResolvedPublicBUG REPORT
Actions