| Amire80 | |
| May 20 2023, 6:20 AM |
| F37102347: image.png | |
| Jun 13 2023, 8:30 AM |
Steps to replicate the issue (include links if applicable):
What happens?:
A bubble saying "An unknown error occurred" appears at the top.
What should have happened instead?:
The interlanguage link dialog is supposed to appear.
The skin doesn't seem to matter.
The actual error:
Unknown module: jquery.wikibase.wbtooltip
Fun. query.wikibase.wbtooltip is now supposed to be used as a replacement for jquery.tipsy (including in Wikibase Client, since Add local version of jquery.tipsy) – but it’s defined in Wikibase View, and Wikibase Client doesn’t depend on Wikibase View (View is only used by Repo).
And of course jquery.tipsy is already gone from MediaWiki core in the meantime (git grep jquery.tipsy only shows two references that were not cleaned up properly), so we can’t just fix this by reverting the Wikibase change.
Change 921436 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/Wikibase@master] Move jquery.wikibase.wbtooltip and dependencies to Lib
Change 921436 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Move jquery.wikibase.wbtooltip and dependencies to Lib
Change 921164 had a related patch set uploaded (by Zabe; author: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/Wikibase@wmf/1.41.0-wmf.9] Move jquery.wikibase.wbtooltip and dependencies to Lib
As a workaround, adding sitelinks with the AutosuggestSitelink gadget
https://meta.wikimedia.org/wiki/AutosuggestSitelink
seems to work.
Change 921164 abandoned by Zabe:
[mediawiki/extensions/Wikibase@wmf/1.41.0-wmf.9] Move jquery.wikibase.wbtooltip and dependencies to Lib
Reason:
Change 921581 had a related patch set uploaded (by Hoo man; author: Hoo man):
[mediawiki/extensions/Wikibase@master] Remove linkitem dependency on jquery.wikibase.wbtooltip
Change 921549 had a related patch set uploaded (by Hoo man; author: Hoo man):
[mediawiki/extensions/Wikibase@wmf/1.41.0-wmf.9] Remove linkitem dependency on jquery.wikibase.wbtooltip
Change 921549 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@wmf/1.41.0-wmf.9] Remove linkitem dependency on jquery.wikibase.wbtooltip
Mentioned in SAL (#wikimedia-operations) [2023-05-20T15:08:57Z] <hoo@deploy1002> Started scap: Backport for [[gerrit:921549|Remove linkitem dependency on jquery.wikibase.wbtooltip (T337081)]]
Mentioned in SAL (#wikimedia-operations) [2023-05-20T15:10:24Z] <hoo@deploy1002> hoo: Backport for [[gerrit:921549|Remove linkitem dependency on jquery.wikibase.wbtooltip (T337081)]] synced to the testservers: mwdebug2001.codfw.wmnet, mwdebug1002.eqiad.wmnet, mwdebug1001.eqiad.wmnet, mwdebug2002.codfw.wmnet
Mentioned in SAL (#wikimedia-operations) [2023-05-20T15:17:45Z] <hoo@deploy1002> Finished scap: Backport for [[gerrit:921549|Remove linkitem dependency on jquery.wikibase.wbtooltip (T337081)]] (duration: 08m 47s)
Fixed in production, thus lowering the priority (final patches for master are still pending).
Fixed in production? Where I came from “production” means what’s already deployed in the field; from what I can see this is not fixed in the field.
We backported and deployed the fix to production yesterday. The old version might still be in your browser's cache, but hard-reloading the page (Ctrl + Shift + R in most browsers) should solve that.
Change 921581 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Remove linkitem dependency on jquery.wikibase.wbtooltip
Change 921548 had a related patch set uploaded (by Hoo man; author: Hoo man):
[mediawiki/extensions/Wikibase@master] Revert "Move jquery.wikibase.wbtooltip and dependencies to Lib"
Re: Tech News - please provide details on
My best guess is something like:
For a few days earlier this month, the "Add interlanguage link" item in the Tools menu did not work properly. This has now been fixed.
Thanks.
This sounds okay to me, but IMHO this doesn’t need to be in Tech News at all. (The unmerged patches are cleanup, IIUC, so if it should be included, it can probably be at any time now.)
Change 921548 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Revert "Move jquery.wikibase.wbtooltip and dependencies to Lib"
It's a widely visible feature across projects, and it was broken for hours if not more. It definitely deserves an entry in Tech News.
It looks like the link is still not working (unless you right click and open it in a new tab/window), so I am going to remove this from the verification and the sprint workboard
Ok, but while logged out, clicking the link does nothing. Maybe we don’t want to offer this functionality to anonymous visitors, but there should probably be some kind of feedback…?
