Page MenuHomePhabricator
Create Task
Maniphest T175828

[wmf.18] VisualEditor accidentally requires ES6 syntax support (for editing and visual diffs)
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

VisualEditor accidentally requires ES6 syntax support (for editing and visual diffs). We have some ES6 code in /lib/ve/src/ve.utils-es6.js that is not supposed to be loaded except when running the rebaser, but it's loaded always.

Details

SubjectRepoBranchLines +/-
Make ve.dm.Change part of core modulemediawiki/extensions/VisualEditorwmf/1.30.0-wmf.18+6 -6
Update VE core submodule to master (7028f79aa)mediawiki/extensions/VisualEditormaster+2 -1
Make ve.dm.Change part of core modulemediawiki/extensions/VisualEditormaster+6 -6
Remove server-only scripts from visualEditor.rebaseVisualEditor/VisualEditormaster+15 -7
Customize query in gerrit

Related Objects

Event Timeline

matmarex created this task.Sep 13 2017, 1:51 PM
Restricted Application added a project: VisualEditor. · View Herald TranscriptSep 13 2017, 1:51 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
gerritbot subscribed.Sep 13 2017, 2:00 PM

Change 377761 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/VisualEditor@master] Make ve.dm.Change part of core module

https://gerrit.wikimedia.org/r/377761

gerritbot added a project: Patch-For-Review.Sep 13 2017, 2:01 PM
• Esanders added subscribers: dchan, • Esanders.Sep 13 2017, 2:03 PM

We should separate rebaser server and client code, and ensure there is no ES6-ness in the client. ve.dm.TestRebaseClient.prototype.deliverOne also contains ES6 code. Pinging @dchan

gerritbot added a comment.Sep 13 2017, 2:14 PM

Change 377768 had a related patch set uploaded (by Esanders; owner: Esanders):
[VisualEditor/VisualEditor@master] Remove server-only scripts from visualEditor.rebase

https://gerrit.wikimedia.org/r/377768

• Esanders triaged this task as Unbreak Now! priority.Sep 13 2017, 2:25 PM
• Esanders added a project: Browser-Support-Internet-Explorer.
• Esanders set the point value for this task to 1.
Restricted Application added subscribers: Liuxinyu970226, Jay8g, TerraCodes. · View Herald TranscriptSep 13 2017, 2:25 PM
gerritbot added a comment.Sep 13 2017, 2:51 PM

Change 377761 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Make ve.dm.Change part of core module

https://gerrit.wikimedia.org/r/377761

• Deskana moved this task from To Triage to TR0: Interrupt on the VisualEditor board.Sep 13 2017, 2:57 PM
gerritbot added a comment.Sep 13 2017, 3:12 PM

Change 377768 merged by jenkins-bot:
[VisualEditor/VisualEditor@master] Remove server-only scripts from visualEditor.rebase

https://gerrit.wikimedia.org/r/377768

• Deskana subscribed.Sep 13 2017, 3:19 PM

Does the merging of the two tasks above mean this is resolved? Is there anything else outstanding?

gerritbot added a comment.Sep 13 2017, 3:29 PM

Change 377785 had a related patch set uploaded (by Jforrester; owner: Esanders):
[mediawiki/extensions/VisualEditor@wmf/1.30.0-wmf.18] Make ve.dm.Change part of core module

https://gerrit.wikimedia.org/r/377785

gerritbot added a comment.Sep 13 2017, 3:30 PM

Change 377766 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (7028f79aa)

https://gerrit.wikimedia.org/r/377766

Jdforrester-WMF subscribed.Sep 13 2017, 3:31 PM
In T175828#3604709, @Deskana wrote:

Does the merging of the two tasks above mean this is resolved? Is there anything else outstanding?

I think 377785 (back-port of 377761) needs to be deployed.

gerritbot added a comment.Sep 13 2017, 3:50 PM

Change 377766 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (7028f79aa)

https://gerrit.wikimedia.org/r/377766

dchan added a comment.Sep 13 2017, 4:01 PM
In T175828#3604435, @Esanders wrote:

We should separate rebaser server and client code, and ensure there is no ES6-ness in the client. ve.dm.TestRebaseClient.prototype.deliverOne also contains ES6 code. Pinging @dchan

It would be ... challenging ... to rewrite that unit test not to use ES6 code: it is really a test of the logic in both RebaseServer and RebaseClient (and how they interact in different scenarios), so therefore the ES6 server-side code does need to run within the unit test. TestRebaseClient#deliverOne is fundamentally ES6 because this is where the async server code gets called.

matmarex added a comment.Sep 13 2017, 4:06 PM

Scheduled for SWAT: https://wikitech.wikimedia.org/wiki/Deployments#deploycal-item-20170913T1800

gerritbot added a comment.Sep 13 2017, 6:11 PM

Change 377785 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@wmf/1.30.0-wmf.18] Make ve.dm.Change part of core module

https://gerrit.wikimedia.org/r/377785

Stashbot subscribed.Sep 13 2017, 6:26 PM

Mentioned in SAL (#wikimedia-operations) [2017-09-13T18:26:30Z] <niharika29@tin> Synchronized php-1.30.0-wmf.18/extensions/VisualEditor/: Make ve.dm.Change part of core module T175828 (duration: 00m 50s)

ReleaseTaggerBot added a project: MW-1.30-release-notes (WMF-deploy-2017-09-12_(1.30.0-wmf.18)).Sep 13 2017, 6:37 PM
matmarex closed this task as Resolved.Sep 13 2017, 6:37 PM
matmarex assigned this task to • Esanders.
matmarex edited projects, added MW-1.30-release-notes (WMF-deploy-2017-09-19 (1.30.0-wmf.19)); removed MW-1.30-release-notes (WMF-deploy-2017-09-12_(1.30.0-wmf.18)), Patch-For-Review.

Fixed and deployed.

Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptSep 13 2017, 6:37 PM
valhallasw mentioned this in T175626: @ReleaseTaggerBot not working for wmf/1.30.0-wmf.18 et seq..Sep 13 2017, 6:38 PM
Jdforrester-WMF edited projects, added MW-1.30-release-notes (WMF-deploy-2017-09-12_(1.30.0-wmf.18)); removed MW-1.30-release-notes (WMF-deploy-2017-09-19 (1.30.0-wmf.19)).Sep 13 2017, 7:58 PM

Yup, deployed in wmf.18.

matmarex added a comment.Sep 13 2017, 8:28 PM

(Didn't mean to remove the wmf.18 tag, looks like I had a mid-air collision with ReleaseTaggerBot.)

Liuxinyu970226 unsubscribed.Sep 15 2017, 3:22 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits