[wmf.18] VisualEditor accidentally requires ES6 syntax support (for editing and visual diffs)
Closed, ResolvedPublic1 Story Points

Description

VisualEditor accidentally requires ES6 syntax support (for editing and visual diffs). We have some ES6 code in /lib/ve/src/ve.utils-es6.js that is not supposed to be loaded except when running the rebaser, but it's loaded always.

matmarex created this task.Sep 13 2017, 1:51 PM
Restricted Application added a project: VisualEditor. · View Herald TranscriptSep 13 2017, 1:51 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Change 377761 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/VisualEditor@master] Make ve.dm.Change part of core module

https://gerrit.wikimedia.org/r/377761

We should separate rebaser server and client code, and ensure there is no ES6-ness in the client. ve.dm.TestRebaseClient.prototype.deliverOne also contains ES6 code. Pinging @dchan

Change 377768 had a related patch set uploaded (by Esanders; owner: Esanders):
[VisualEditor/VisualEditor@master] Remove server-only scripts from visualEditor.rebase

https://gerrit.wikimedia.org/r/377768

Esanders triaged this task as Unbreak Now! priority.Sep 13 2017, 2:25 PM
Esanders set the point value for this task to 1.
Restricted Application added subscribers: Liuxinyu970226, Jay8g, TerraCodes. · View Herald TranscriptSep 13 2017, 2:25 PM

Change 377761 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Make ve.dm.Change part of core module

https://gerrit.wikimedia.org/r/377761

Change 377768 merged by jenkins-bot:
[VisualEditor/VisualEditor@master] Remove server-only scripts from visualEditor.rebase

https://gerrit.wikimedia.org/r/377768

Does the merging of the two tasks above mean this is resolved? Is there anything else outstanding?

Change 377785 had a related patch set uploaded (by Jforrester; owner: Esanders):
[mediawiki/extensions/VisualEditor@wmf/1.30.0-wmf.18] Make ve.dm.Change part of core module

https://gerrit.wikimedia.org/r/377785

Change 377766 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (7028f79aa)

https://gerrit.wikimedia.org/r/377766

Does the merging of the two tasks above mean this is resolved? Is there anything else outstanding?

I think 377785 (back-port of 377761) needs to be deployed.

Change 377766 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (7028f79aa)

https://gerrit.wikimedia.org/r/377766

dchan added a comment.Sep 13 2017, 4:01 PM

We should separate rebaser server and client code, and ensure there is no ES6-ness in the client. ve.dm.TestRebaseClient.prototype.deliverOne also contains ES6 code. Pinging @dchan

It would be ... challenging ... to rewrite that unit test not to use ES6 code: it is really a test of the logic in both RebaseServer and RebaseClient (and how they interact in different scenarios), so therefore the ES6 server-side code does need to run within the unit test. TestRebaseClient#deliverOne is fundamentally ES6 because this is where the async server code gets called.

Change 377785 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@wmf/1.30.0-wmf.18] Make ve.dm.Change part of core module

https://gerrit.wikimedia.org/r/377785

Mentioned in SAL (#wikimedia-operations) [2017-09-13T18:26:30Z] <niharika29@tin> Synchronized php-1.30.0-wmf.18/extensions/VisualEditor/: Make ve.dm.Change part of core module T175828 (duration: 00m 50s)

Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptSep 13 2017, 6:37 PM

(Didn't mean to remove the wmf.18 tag, looks like I had a mid-air collision with ReleaseTaggerBot.)