Page MenuHomePhabricator

Minerva causes Special:JavaScriptTest to fail in debug mode
Closed, ResolvedPublic

Description

In trying to load tests/qunit/skins.minerva.notifications.badge/test_NotificationBadge.js the client requests extensions/MinervaNeue/tests/... when in fact the skin in installed in core/skins/MinervaNeue. The resulting 404 causes the page to stop loading. The file loads correctly when resourceLoaderDebug is disabled.

Event Timeline

Esanders created this task.Sep 13 2017, 8:22 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 13 2017, 8:22 PM
Krinkle added a subscriber: Krinkle.

Looks like the tests are explicitly registered with a remote path for extensions/ instead of skins/. Untagging ResourceLoader.

Problematic code is around Minerva.hooks.php#L63 where the FileModule's (localBasePath, remoteBasePath) pair is defined using the remoteExtPath shortcut, instead of the remoteSkinPath shortcut.

Krinkle removed a subscriber: Krinkle.Sep 13 2017, 9:05 PM

Change 377957 had a related patch set uploaded (by Legoktm; owner: Legoktm):
[mediawiki/skins/MinervaNeue@master] Use 'remoteSkinPath' for qunit tests

https://gerrit.wikimedia.org/r/377957

Change 377957 merged by jenkins-bot:
[mediawiki/skins/MinervaNeue@master] Use 'remoteSkinPath' for qunit tests

https://gerrit.wikimedia.org/r/377957

pmiazga added subscribers: pmiazga, phuedx.

Bringing it us unplanned worked, Task is ready and got reviewed by @pmiazga and @phuedx.

phuedx closed this task as Resolved.Sep 19 2017, 10:41 AM
phuedx claimed this task.

I'm seeing the MinervaNeue test passing after vagrant git-updateing 🎉

TheDJ added a subscriber: TheDJ.