In trying to load tests/qunit/skins.minerva.notifications.badge/test_NotificationBadge.js the client requests extensions/MinervaNeue/tests/... when in fact the skin in installed in core/skins/MinervaNeue. The resulting 404 causes the page to stop loading. The file loads correctly when resourceLoaderDebug is disabled.
Description
Description
Details
Details
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Use 'remoteSkinPath' for qunit tests | mediawiki/skins/MinervaNeue | master | +1 -1 |
Event Timeline
Comment Actions
Looks like the tests are explicitly registered with a remote path for extensions/ instead of skins/. Untagging ResourceLoader.
Problematic code is around Minerva.hooks.php#L63 where the FileModule's (localBasePath, remoteBasePath) pair is defined using the remoteExtPath shortcut, instead of the remoteSkinPath shortcut.
Comment Actions
Change 377957 had a related patch set uploaded (by Legoktm; owner: Legoktm):
[mediawiki/skins/MinervaNeue@master] Use 'remoteSkinPath' for qunit tests
Comment Actions
Change 377957 merged by jenkins-bot:
[mediawiki/skins/MinervaNeue@master] Use 'remoteSkinPath' for qunit tests