Page MenuHomePhabricator
Create Task
Maniphest T176390

LocalisationUpdate GitHub backend fails if it cannot find a i18n dir
Closed, ResolvedPublic
Actions

Description

When LocalisationUpdate is run I get the following error:

[92b5ad9c1eec7433c835aa4d] [no req] Exception from line 27 of /var/www/extensions/LocalisationUpdate/fetcher/GitHubFetcher.php: Unable to get directory listing for wikimedia/mediawiki-skins-foreground Backtrace:

0 /var/www/extensions/LocalisationUpdate/Updater.php(117): LocalisationUpdate\GitHubFetcher->fetchDirectory(string)
1 /var/www/extensions/LocalisationUpdate/Updater.php(139): LocalisationUpdate\Updater->fetchFiles(LocalisationUpdate\FetcherFactory, string)
2 /var/www/extensions/LocalisationUpdate/update.php(62): LocalisationUpdate\Updater->execute(LocalisationUpdate\Finder, LocalisationUpdate\ReaderFactory, LocalisationUpdate\FetcherFactory, array)
3 /var/www/maintenance/doMaintenance.php(111): LU->execute()
4 /var/www/extensions/LocalisationUpdate/update.php(80): require_once(string)
5 {main}

The whole update should not fail in case some of the equivalent files cannot be found.

Details

SubjectRepoBranchLines +/-
Handle exceptions from GitHubFetchermediawiki/extensions/LocalisationUpdateREL1_31+25 -3
Handle exceptions from GitHubFetchermediawiki/extensions/LocalisationUpdateREL1_32+25 -3
Handle exceptions from GitHubFetchermediawiki/extensions/LocalisationUpdatemaster+25 -3
Customize query in gerrit

Related Objects

Event Timeline

Curlybracket created this task.Sep 21 2017, 7:28 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 21 2017, 7:28 AM
Curlybracket added a comment.Sep 25 2017, 9:27 AM

An option to exclude certain skins or better error handling would be nice.

Aklapper removed a subscriber: MediaWiki-extensions-LocalisationUpdate.Sep 25 2017, 10:15 AM

What would "better error handling" be?

Curlybracket added a comment.Sep 25 2017, 10:22 AM

The updater not crapping out with a fatal exception.

Nikerabbit renamed this task from LocalisationUpdate fails if foreground skin is installed to LocalisationUpdate fails if non-gerrit skin or extension is installed.Dec 4 2017, 4:28 PM
Nikerabbit triaged this task as High priority.
Nikerabbit added a project: User-Nikerabbit.
Lens0021 mentioned this in T206460: MediaWiki 1.31 and earlier can't use LocalisationUpdate with GitHub now.Oct 8 2018, 1:25 PM
Nikerabbit renamed this task from LocalisationUpdate fails if non-gerrit skin or extension is installed to LocalisationUpdate GitHub backend fails if it cannot find a i18n dir.Oct 11 2018, 8:14 AM
Nikerabbit added a project: MediaWiki Language Extension Bundle.
Nikerabbit moved this task from Backlog to 2018.10 on the MediaWiki Language Extension Bundle board.Oct 11 2018, 8:55 AM
Pginer-WMF added a project: Language-Team (Language-2018-October-December).Oct 15 2018, 7:21 AM
Nikerabbit merged a task: T206460: MediaWiki 1.31 and earlier can't use LocalisationUpdate with GitHub now.Oct 15 2018, 7:35 AM
Nikerabbit added subscribers: Lens0021, Krinkle, Paladox.
Nikerabbit removed a project: User-Nikerabbit.Oct 15 2018, 7:38 AM
Nikerabbit updated the task description. (Show Details)
Pginer-WMF moved this task from Backlog to Maintenance backlog on the Language-Team (Language-2018-October-December) board.Oct 15 2018, 7:58 AM
Nikerabbit claimed this task.Oct 24 2018, 8:35 AM
Nikerabbit moved this task from Maintenance backlog to In Review on the Language-Team (Language-2018-October-December) board.

Test plan:

  • Use a stable version of MediaWiki
  • Add wfLoadExtension( 'LocalisationUpdate' ); to LocalSettings.php
  • Execute php extensions/LocalisationUpdate/update.php
gerritbot subscribed.Oct 24 2018, 8:37 AM

Change 469386 had a related patch set uploaded (by Nikerabbit; owner: Nikerabbit):
[mediawiki/extensions/LocalisationUpdate@master] Handle exceptions from GitHubFetcher

https://gerrit.wikimedia.org/r/469386

gerritbot added a project: Patch-For-Review.Oct 24 2018, 8:37 AM
gerritbot added a comment.Oct 25 2018, 5:45 PM

Change 469386 merged by jenkins-bot:
[mediawiki/extensions/LocalisationUpdate@master] Handle exceptions from GitHubFetcher

https://gerrit.wikimedia.org/r/469386

ReleaseTaggerBot added a project: MW-1.33-notes (1.33.0-wmf.2; 2018-10-30).Oct 25 2018, 6:00 PM
gerritbot added a comment.Oct 25 2018, 7:11 PM

Change 469674 had a related patch set uploaded (by Paladox; owner: Nikerabbit):
[mediawiki/extensions/LocalisationUpdate@REL1_32] Handle exceptions from GitHubFetcher

https://gerrit.wikimedia.org/r/469674

gerritbot added a comment.Oct 25 2018, 7:11 PM

Change 469675 had a related patch set uploaded (by Paladox; owner: Nikerabbit):
[mediawiki/extensions/LocalisationUpdate@REL1_31] Handle exceptions from GitHubFetcher

https://gerrit.wikimedia.org/r/469675

Nikerabbit moved this task from In Review to QA on the Language-Team (Language-2018-October-December) board.Oct 26 2018, 6:00 AM
Legoktm added projects: MW-1.32-release, MW-1.31-release.Oct 26 2018, 6:22 AM
gerritbot added a comment.Oct 30 2018, 9:33 AM

Change 469674 merged by jenkins-bot:
[mediawiki/extensions/LocalisationUpdate@REL1_32] Handle exceptions from GitHubFetcher

https://gerrit.wikimedia.org/r/469674

gerritbot added a comment.Oct 31 2018, 9:46 AM

Change 469675 merged by jenkins-bot:
[mediawiki/extensions/LocalisationUpdate@REL1_31] Handle exceptions from GitHubFetcher

https://gerrit.wikimedia.org/r/469675

Etonkovidova closed this task as Resolved.Nov 2 2018, 7:05 PM
Nikerabbit moved this task from QA to Done on the Language-Team (Language-2018-October-December) board.Nov 2 2018, 8:42 PM
c_schmitz awarded a token.Nov 3 2018, 7:17 AM
• Petar.petkovic removed a project: Patch-For-Review.Nov 5 2018, 9:54 PM
• Petar.petkovic removed a subscriber: gerritbot.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL