Page MenuHomePhabricator
Create Task
Maniphest T176936

Clicking to the right of a table in Firefox puts the cursor inside the last cell (but not in cell editing mode)
Closed, ResolvedPublic8 Estimated Story Points
Actions

Description

Typing in this position causes model & view corruption:

image.png (286×149 px, 4 KB)

Chrome puts the cursor in the next paragraph, although it may be just good luck that this usually ends up being a valid cursor position.

Other acceptable results would be selecting the table, or clearing the selection (NullSelection).

Details

SubjectRepoBranchLines +/-
Update VE core submodule to master (e8188bac8)mediawiki/extensions/VisualEditormaster+1 -1
ce.Surface: handle table-adjacent observed selection changes betterVisualEditor/VisualEditormaster+23 -9
Update VE core submodule to master (cb52d8b7a)mediawiki/extensions/VisualEditormaster+1 -1
ce.Surface: in observed selection changes, only make cursorable selectionsVisualEditor/VisualEditormaster+21 -1
Customize query in gerrit

Related Objects

Event Timeline

Esanders created this task.Sep 28 2017, 8:34 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 28 2017, 8:34 AM
Esanders mentioned this in T148679: Uncaught Error: Inserted data is trying to close the root node (at index 0) appears when pressing returen after deselecting some nodes.Sep 28 2017, 8:37 AM
gerritbot subscribed.Sep 28 2017, 4:24 PM

Change 381235 had a related patch set uploaded (by DLynch; owner: DLynch):
[VisualEditor/VisualEditor@master] ce.Surface: in observed selection changes, only make cursorable selections

https://gerrit.wikimedia.org/r/381235

gerritbot added a project: Patch-For-Review.Sep 28 2017, 4:24 PM
gerritbot added a comment.Sep 29 2017, 9:48 PM

Change 381235 merged by jenkins-bot:
[VisualEditor/VisualEditor@master] ce.Surface: in observed selection changes, only make cursorable selections

https://gerrit.wikimedia.org/r/381235

gerritbot added a comment.Oct 2 2017, 4:53 PM

Change 381805 had a related patch set uploaded (by DLynch; owner: DLynch):
[VisualEditor/VisualEditor@master] ce.Surface: handle table-adjacent observed selection changes better

https://gerrit.wikimedia.org/r/381805

gerritbot added a comment.Oct 2 2017, 5:56 PM

Change 381814 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (cb52d8b7a)

https://gerrit.wikimedia.org/r/381814

gerritbot added a comment.Oct 3 2017, 5:06 AM

Change 381814 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (cb52d8b7a)

https://gerrit.wikimedia.org/r/381814

ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2017-10-03 (1.31.0-wmf.2)).Oct 3 2017, 6:00 AM
gerritbot added a comment.Oct 11 2017, 12:34 PM

Change 381805 merged by jenkins-bot:
[VisualEditor/VisualEditor@master] ce.Surface: handle table-adjacent observed selection changes better

https://gerrit.wikimedia.org/r/381805

gerritbot added a comment.Oct 11 2017, 4:55 PM

Change 383612 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (e8188bac8)

https://gerrit.wikimedia.org/r/383612

gerritbot added a comment.Oct 11 2017, 5:18 PM

Change 383612 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (e8188bac8)

https://gerrit.wikimedia.org/r/383612

ReleaseTaggerBot edited projects, added MW-1.31-release-notes (WMF-deploy-2017-10-17 (1.31.0-wmf.4)); removed MW-1.31-release-notes (WMF-deploy-2017-10-03 (1.31.0-wmf.2)).Oct 11 2017, 6:00 PM
Jdforrester-WMF closed this task as Resolved.Oct 11 2017, 7:31 PM
Jdforrester-WMF assigned this task to DLynch.
Jdforrester-WMF triaged this task as Medium priority.
Jdforrester-WMF removed a project: Patch-For-Review.
Jdforrester-WMF set the point value for this task to 8.
Jdforrester-WMF subscribed.

Sorry, RTB got confused.

Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptOct 11 2017, 7:31 PM
Ryasmeen added a project: Verified.Oct 12 2017, 12:23 AM
• Elitre renamed this task from Clicking to the right of a table in Firefox puts the cursor inside the last the cell (but not in cell editing mode) to Clicking to the right of a table in Firefox puts the cursor inside the last cell (but not in cell editing mode).Oct 18 2017, 9:51 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL