Page MenuHomePhabricator
Create Task
Maniphest T177764

[Task] Make Wikibase JavaScript unit tests QUnit 2 compatible
Closed, ResolvedPublic
Actions

Description

Patch-For-Review:

Details

SubjectRepoBranchLines +/-
Update ValueView dependency to 0.21.0mediawiki/extensions/Wikibasemaster+1 -1
Switch from setup/teardown to before/afterEach in QUnit testsdata-values/value-viewmaster+11 -11
Remove QUnit.Parameterize dependency and make tests pass with QUnit 2data-values/value-viewmaster+172 -166
Make tests compatible with QUnit 2mediawiki/extensions/WikibaseLexememaster+1 -1
Make tests QUnit 2 compatiblemediawiki/extensions/Wikibasemaster+89 -224
Simplify QUnit assertions a littledata-values/value-viewmaster+10 -36
Customize query in gerrit

Related Objects
Search...

Event Timeline

thiemowmde created this task.Oct 9 2017, 1:06 PM
Restricted Application removed a project: Patch-For-Review. · View Herald TranscriptOct 9 2017, 1:06 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
thiemowmde moved this task from Proposed to Review on the Wikidata-Former-Sprint-Board board.Oct 9 2017, 1:07 PM
thiemowmde added a project: Patch-For-Review.
thiemowmde moved this task from incoming to in progress on the Wikidata board.
thiemowmde added subscribers: aude, hoo, Addshore and 2 others.
gerritbot subscribed.Oct 9 2017, 1:08 PM

Change 383117 had a related patch set uploaded (by Thiemo Mättig (WMDE); owner: Thiemo Mättig (WMDE)):
[data-values/value-view@master] Simplify QUnit assertions a little

https://gerrit.wikimedia.org/r/383117

gerritbot added a comment.Oct 9 2017, 1:08 PM

Change 370300 had a related patch set uploaded (by Thiemo Mättig (WMDE); owner: Krinkle):
[mediawiki/extensions/Wikibase@master] Make tests QUnit 2 compatible

https://gerrit.wikimedia.org/r/370300

gerritbot added a comment.Oct 9 2017, 5:34 PM

Change 383117 merged by jenkins-bot:
[data-values/value-view@master] Simplify QUnit assertions a little

https://gerrit.wikimedia.org/r/383117

Krinkle updated the task description. (Show Details)Oct 9 2017, 9:06 PM
Krinkle awarded a token.Oct 9 2017, 9:10 PM
gerritbot added a comment.Oct 9 2017, 9:20 PM

Change 370300 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Make tests QUnit 2 compatible

https://gerrit.wikimedia.org/r/370300

ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2017-10-10 (1.31.0-wmf.3)).Oct 9 2017, 10:00 PM
Krinkle removed projects: MW-1.31-release-notes (WMF-deploy-2017-10-10 (1.31.0-wmf.3)), Patch-For-Review.Oct 10 2017, 4:55 AM
WMDE-leszek moved this task from Review to Done on the Wikidata-Former-Sprint-Board board.Oct 10 2017, 7:32 AM
WMDE-leszek updated the task description. (Show Details)Oct 10 2017, 7:53 AM
gerritbot added a comment.Oct 10 2017, 2:11 PM

Change 383363 had a related patch set uploaded (by Thiemo Mättig (WMDE); owner: Thiemo Mättig (WMDE)):
[mediawiki/extensions/WikibaseLexeme@master] Make tests compatible with QUnit 2

https://gerrit.wikimedia.org/r/383363

gerritbot added a project: Patch-For-Review.Oct 10 2017, 2:11 PM
thiemowmde mentioned this in rEWLE87a09f5e70e9: Make tests compatible with QUnit 2.Oct 10 2017, 2:12 PM
gerritbot added a comment.Oct 10 2017, 5:02 PM

Change 383383 had a related patch set uploaded (by Thiemo Mättig (WMDE); owner: Thiemo Mättig (WMDE)):
[data-values/value-view@master] Remove QUnit.Parameterize dependency and make tests pass with QUnit 2

https://gerrit.wikimedia.org/r/383383

thiemowmde moved this task from Done to Review on the Wikidata-Former-Sprint-Board board.Oct 10 2017, 5:03 PM
thiemowmde updated the task description. (Show Details)Oct 10 2017, 5:05 PM
thiemowmde updated the task description. (Show Details)Oct 10 2017, 5:29 PM
gerritbot added a comment.Oct 10 2017, 5:30 PM

Change 383363 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] Make tests compatible with QUnit 2

https://gerrit.wikimedia.org/r/383363

Krinkle updated the task description. (Show Details)Oct 10 2017, 7:32 PM
gerritbot added a comment.Oct 11 2017, 6:16 AM

Change 383383 merged by jenkins-bot:
[data-values/value-view@master] Remove QUnit.Parameterize dependency and make tests pass with QUnit 2

https://gerrit.wikimedia.org/r/383383

thiemowmde closed this task as Resolved.Oct 11 2017, 9:55 AM
thiemowmde removed a project: Patch-For-Review.
thiemowmde updated the task description. (Show Details)
thiemowmde moved this task from Review to Done on the Wikidata-Former-Sprint-Board board.
Krinkle added a comment.Oct 11 2017, 9:00 PM

@thiemowmde The tests still fail with QUnit 2 at https://gerrit.wikimedia.org/r/#/c/367838/13. Failures come from data-values/value-view.

In T177764#3674594, @gerritbot wrote:

Change 383383 merged by jenkins-bot:
[data-values/value-view@master] Remove QUnit.Parameterize dependency and make tests pass with QUnit 2

https://gerrit.wikimedia.org/r/383383

This would fix those failures, but it seems that while merged before the mediawiki/extensions/Wikidata build this morning, it is not included. I guess it needs to be released and pulled through?

https://github.com/wikimedia/mediawiki-extensions-Wikidata/commits/master/extensions/ValueView/tests/src/jquery.valueview.tests.testExpert.js

WMDE-leszek added a comment.Oct 12 2017, 6:50 AM

@Krinkle I am currently preparing the release of this component (as part of npmizing Wikibase JS stuff). This is going to include fixes @thiemowmde made (plus some teardown -> afterEach changes I spotted yesterday). Hopefully we'll get this released today.

thiemowmde added a comment.Oct 12 2017, 7:00 AM

Thats right. We are in the middle of releasing a new version of ValueView, tracked in T177816. We plan to finish this the next two or three days.

gerritbot added a comment.Oct 12 2017, 7:08 AM

Change 383786 had a related patch set uploaded (by WMDE-leszek; owner: WMDE-leszek):
[data-values/value-view@master] Switch from setup/teardown to before/afterEach in QUnit tests

https://gerrit.wikimedia.org/r/383786

gerritbot added a project: Patch-For-Review.Oct 12 2017, 7:08 AM
WMDE-leszek added a comment.Oct 12 2017, 7:15 AM

Sorry for the noise, I've changed my mind. I don't want to be a bottleneck here. Let's release it now @thiemowmde , so it is pulled in today's build and we unblock QUnit upgrade work. npm package will be 0.22 then.

gerritbot added a comment.Oct 12 2017, 9:24 AM

Change 383786 merged by jenkins-bot:
[data-values/value-view@master] Switch from setup/teardown to before/afterEach in QUnit tests

https://gerrit.wikimedia.org/r/383786

WMDE-leszek added a comment.Oct 12 2017, 9:38 AM

Apparently I can't push tags to https://gerrit.wikimedia.org/r/#/admin/projects/data-values/value-view, so cannot release it now...

gerritbot added a comment.Oct 12 2017, 9:50 AM

Change 383806 had a related patch set uploaded (by Thiemo Mättig (WMDE); owner: Thiemo Mättig (WMDE)):
[mediawiki/extensions/Wikibase@master] Update ValueView dependency to 0.21.0

https://gerrit.wikimedia.org/r/383806

thiemowmde reopened this task as Open.Oct 12 2017, 10:02 AM
thiemowmde updated the task description. (Show Details)
thiemowmde moved this task from Done to Review on the Wikidata-Former-Sprint-Board board.
gerritbot added a comment.Oct 12 2017, 10:26 AM

Change 383806 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Update ValueView dependency to 0.21.0

https://gerrit.wikimedia.org/r/383806

ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2017-10-17 (1.31.0-wmf.4)).Oct 12 2017, 11:00 AM
WMDE-leszek added a comment.Oct 12 2017, 11:09 AM

The release and new build including it https://gerrit.wikimedia.org/r/#/c/383816/ apparently didn't help: https://integration.wikimedia.org/ci/job/mediawiki-extensions-qunit-jessie/42516/console

• Jonas moved this task from Review to Done on the Wikidata-Former-Sprint-Board board.Oct 12 2017, 1:26 PM
Lydia_Pintscher subscribed.Oct 16 2017, 4:41 PM

Can this be closed?

WMDE-leszek closed this task as Resolved.Oct 17 2017, 7:30 AM

If I read the log of the latest qunit job of https://gerrit.wikimedia.org/r/#/c/367838/, there is no failing tests on our side, so looks like we're finally good here.

@Krinkle: please re-open if there is still something on Wikibase side which is blocking you!

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits