[1.31.0-wmf.3] False 'Missing in English' label is displayed for articles existing in enwiki
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Etonkovidova
	Oct 12 2017, 11:01 PM

Description

This bug is consistently present in different language wikis. Here are the steps to reproduce the issue (enwiki used as example):

Go to the main page of your preferred wiki.
From the top-right navigation bar hover over "Contributions" and choose "Translations".
Open "New translation" dialog.
Choose the source language to be same as current wiki you are on (for enwiki, it would be English, for ruwiki - Russian, etc...).
Reload the page.
Open "New translation" dialog again.
Now, there are two ways to see the issue:
- If you have some recent edits, articles you've edited recently would display when you open the dialog, where you can see the issue.
- If you don't have any recent edits, just enter something in search input bar (e.g. "Japan" or "Robot")

Here are some screenshots showing the issues, where source and target language are the same, which leads to labels like "Missing in English" showing, even though you are searching for pages in English Wikipedia.

Screen Shot 2017-10-12 at 2.59.46 PM.png (562×872 px, 89 KB)

Screen Shot 2017-10-12 at 2.58.26 PM.png (537×1 px, 140 KB)

ruwiki displays articles that exist but, with the label "Missing in Russian".

Screen Shot 2017-10-06 at 4.00.53 PM.png (283×893 px, 65 KB)

Details

	Subject	Repo	Branch	Lines +/-
	Fix same source and target language	mediawiki/extensions/ContentTranslation	master	+1 -1
	Fix same source and target language	mediawiki/extensions/ContentTranslation	master	+2 -2

Customize query in gerrit

Related Objects

Mentioned In: T181002: Duplicate suggestion when a white space is added to the search criteria
Mentioned Here: T181002: Duplicate suggestion when a white space is added to the search criteria
T50476: VisualEditor: MWLinkTargetInputWidget should grok case sensitivity of suggested page title vs. the inputed text

Event Timeline

Etonkovidova created this task.Oct 12 2017, 11:01 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 12 2017, 11:01 PM

Etonkovidova updated the task description. (Show Details)Oct 12 2017, 11:01 PM

Change 385179 had a related patch set uploaded (by Petar.petkovic; owner: Petar.petkovic):
[mediawiki/extensions/ContentTranslation@master] Fix same source and target language

https://gerrit.wikimedia.org/r/385179

gerritbot added a project: Patch-For-Review.Oct 19 2017, 12:54 PM

• Petar.petkovic claimed this task.Oct 19 2017, 12:55 PM

• Petar.petkovic added a project: Language-2017-Oct-Dec.

• Petar.petkovic moved this task from Backlog to In Review on the Language-2017-Oct-Dec board.

santhosh moved this task from Needs Triage to Bugs on the ContentTranslation board.Oct 27 2017, 5:38 AM

Arrbee moved this task from Bugs to Oct-Dec 2017 on the ContentTranslation board.Oct 27 2017, 6:17 AM

santhosh updated the task description. (Show Details)Oct 31 2017, 5:10 AM

Change 385179 merged by jenkins-bot:
[mediawiki/extensions/ContentTranslation@master] Fix same source and target language

https://gerrit.wikimedia.org/r/385179

ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2017-10-31 (1.31.0-wmf.6)).Oct 31 2017, 6:00 AM

• Petar.petkovic moved this task from In Review to QA on the Language-2017-Oct-Dec board.Oct 31 2017, 8:11 AM

Checked in enwiki (wmf.6) and cx-testing - the issue is fixed.

Etonkovidova closed this task as Resolved.Nov 3 2017, 10:28 PM

Nikerabbit moved this task from QA to Done on the Language-2017-Oct-Dec board.Nov 7 2017, 7:04 AM

Reopening the ticket because this bug isn't resolved, found it again in production.

• Petar.petkovic updated the task description. (Show Details)Nov 13 2017, 12:56 PM

Change 390997 had a related patch set uploaded (by Petar.petkovic; owner: Petar.petkovic):
[mediawiki/extensions/ContentTranslation@master] Fix same source and target language

https://gerrit.wikimedia.org/r/390997

gerritbot added a project: Patch-For-Review.Nov 13 2017, 1:44 PM

• Petar.petkovic moved this task from Backlog to QA on the Language-2017-Oct-Dec board.Nov 13 2017, 1:48 PM

Change 390997 merged by jenkins-bot:
[mediawiki/extensions/ContentTranslation@master] Fix same source and target language

https://gerrit.wikimedia.org/r/390997

ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2017-11-14 (1.31.0-wmf.8)).Nov 13 2017, 2:01 PM

@Petar.petkovic: The fix seems to be working - and besides, it is not possible to have a situation when you have, for example, English->English translation in New translation dialog:
(the screenshot is from wmf.7)

However, checking cawiki (wmf.8) I saw a tricky case of incorrect "Missing in English" displayed. It could be a different issue.
Steps to reproduce:

On cawiki, repeat the steps listed in this ticket
After typing, for example, "Robot" in step #7 (and see the correctly displayed suggestions), press the spacebar to add a white space - a strange entry for Robot article will be displayed with "Missing in English".

The screen recording shows that for catala->English suggested translations, Robot article becomes marked with "Missing in English" after adding a white space in the text field. When I click on it, I see "The article already exists in English".

missing_English.mov2 MBDownload

This extra article item appears with many search entries - e.g. Tor, Japan, Test. After clicking on such suggestion, you'll redirected to the article that was displayed below on the list.

Screen Shot 2017-11-17 at 6.10.59 PM.png (459×941 px, 78 KB)

The link associated with the extra item is exactly the same:

<div class="oo-ui-widget oo-ui-widget-enabled oo-ui-labelElement oo-ui-optionWidget oo-ui-iconElement oo-ui-decoratedOptionWidget oo-ui-menuOptionWidget mw-widget-titleOptionWidget mw-cx-widget-titleOptionWidget" aria-disabled="false" tabindex="-1" role="option" aria-selected="false" id="oojsui-8"><span class="oo-ui-iconElement-icon oo-ui-icon-page-existing"></span><a class="oo-ui-labelElement-label"** href="//ca.wikipedia.org/wiki/Robot_" **tabindex="-1" title="Robot">Robot</a><span class="oo-ui-indicatorElement-indicator"></span><span class="mw-cx-widget-titleOptionWidget-numOfLanguages"><span class="oo-ui-widget oo-ui-widget-enabled oo-ui-iconElement oo-ui-iconElement-icon oo-ui-icon-language oo-ui-iconWidget" aria-disabled="false" title="Number of languages"></span><label class="oo-ui-widget oo-ui-widget-enabled oo-ui-labelElement oo-ui-labelElement-label oo-ui-labelWidget" aria-disabled="false">1</label></span><span class="mw-cx-widget-titleOptionWidget-missing">Missing in English</span></div>

And for the below item, some image will be included:

<div class="oo-ui-widget oo-ui-widget-enabled oo-ui-labelElement oo-ui-optionWidget oo-ui-iconElement oo-ui-decoratedOptionWidget oo-ui-menuOptionWidget mw-widget-titleOptionWidget mw-cx-widget-titleOptionWidget" aria-disabled="false" tabindex="-1" role="option" aria-selected="false" id="oojsui-9"><span class="oo-ui-iconElement-icon oo-ui-icon-page-existing mw-widget-titleOptionWidget-hasImage" style="background-image: url(&quot;https://upload.wikimedia.org/wikipedia/commons/thumb/8/80/Paris_Air_Show_2007-06-24_n20.jpg/80px-Paris_Air_Show_2007-06-24_n20.jpg&quot;);"></span><a class="oo-ui-labelElement-label"** href="//ca.wikipedia.org/wiki/Robot" **tabindex="-1" title="Robot">Robot</a><span class="oo-ui-indicatorElement-indicator"></span><span class="mw-widget-titleOptionWidget-description" title="mechanical or virtual artificial agent">mechanical or virtual artificial agent</span><span class="mw-cx-widget-titleOptionWidget-numOfLanguages"><span class="oo-ui-widget oo-ui-widget-enabled oo-ui-iconElement oo-ui-iconElement-icon oo-ui-icon-language oo-ui-iconWidget" aria-disabled="false" title="Number of languages"></span><label class="oo-ui-widget oo-ui-widget-enabled oo-ui-labelElement oo-ui-labelElement-label oo-ui-labelWidget" aria-disabled="false">107</label></span></div>

That bug is related to how search results are added while user types the query. After query results are fetched from server, one additional result is added as first result, matching the exact user input. So, the same problem would be surfaced if you use lowercase "robot", with or without the space character after the letters.

This is inherited from OOJS UI widget's way of processesing results. The ticket for which this behavior may have been introduced is this one: T50476: VisualEditor: MWLinkTargetInputWidget should grok case sensitivity of suggested page title vs. the inputed text.

@Etonkovidova, we have already discussed this addition of exact user input during offsite. Thank you for reporting it, I will look into fixing the issue.

Etonkovidova mentioned this in T181002: Duplicate suggestion when a white space is added to the search criteria.Nov 20 2017, 9:47 PM

The issue with a duplicate suggestion is filed as a separate issue: T181002: Duplicate suggestion when a white space is added to the search criteria

Nikerabbit removed a project: Patch-For-Review.Nov 21 2017, 7:01 AM

Nikerabbit moved this task from QA to Done on the Language-2017-Oct-Dec board.

	F10857275: Screen Shot 2017-11-17 at 6.10.59 PM.png
	Nov 18 2017, 2:19 AM

	F10856625: Screen Shot 2017-11-17 at 5.44.33 PM.png
	Nov 18 2017, 2:19 AM

	F10168127: Screen Shot 2017-10-12 at 2.58.26 PM.png
	Oct 12 2017, 11:01 PM

	F10168148: Screen Shot 2017-10-06 at 4.00.53 PM.png
	Oct 12 2017, 11:01 PM

	F10168122: Screen Shot 2017-10-12 at 2.59.46 PM.png
	Oct 12 2017, 11:01 PM

[1.31.0-wmf.3] False 'Missing in English' label is displayed for articles existing in enwiki Closed, ResolvedPublicActions

Description

Details

Related Objects

Event Timeline

[1.31.0-wmf.3] False 'Missing in English' label is displayed for articles existing in enwiki
Closed, ResolvedPublic
Actions