Earlier today @awight had issues deploying ORES in beta. Their repository is based in Phabricator. Two things were happening
It looks like this is a regression.
Confirming this bug: scap is failing to rewrite URLs like https://phabricator.wikimedia.org/source/editquality.git, for the /srv/deployment/ores/deploy repo.
seems like deployment-sca03 has the correct remote URLs:
twentyafterfour@deployment-sca03:/srv/deployment/ores/deploy/submodules$ git submodule foreach git remote -v Entering 'draftquality' origin http://deployment-tin.eqiad.wmflabs/ores/deploy/.git/modules/submodules/draftquality (fetch) origin http://deployment-tin.eqiad.wmflabs/ores/deploy/.git/modules/submodules/draftquality (push) Entering 'editquality' origin http://deployment-tin.eqiad.wmflabs/ores/deploy/.git/modules/submodules/editquality (fetch) origin http://deployment-tin.eqiad.wmflabs/ores/deploy/.git/modules/submodules/editquality (push) Entering 'ores' origin http://deployment-tin.eqiad.wmflabs/ores/deploy/.git/modules/submodules/ores (fetch) origin http://deployment-tin.eqiad.wmflabs/ores/deploy/.git/modules/submodules/ores (push) Entering 'wheels' origin http://deployment-tin.eqiad.wmflabs/ores/deploy/.git/modules/submodules/wheels (fetch) origin http://deployment-tin.eqiad.wmflabs/ores/deploy/.git/modules/submodules/wheels (push) Entering 'wikiclass' origin http://deployment-tin.eqiad.wmflabs/ores/deploy/.git/modules/submodules/wikiclass (fetch) origin http://deployment-tin.eqiad.wmflabs/ores/deploy/.git/modules/submodules/wikiclass (push) twentyafterfour@deployment-sca03:/srv/deployment/ores/deploy/submodules$ ls
@awight Did you fix this manually?
@thcipriani: I'm at a loss for why this isn't working. D826: Cache submodules and use --reference to save space + D849: sync submodules after git submodule update + D854: Sync submodules for the cache AND the rev directory are the relevant changes.