Clicking on the {{meetupsig}} button not enough for the Save button to be active
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

Per report:
"Today I clicked the blue button and it showed my four tildes but Save was greyed out until I added and deleted some letters. So, it's still broken. "

Details

	Subject	Repo	Branch	Lines +/-
	ArticleTarget: remember whether we preloaded, so it can affect the save button	mediawiki/extensions/VisualEditor	master	+15 -1

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		DLynch	T51622 Add support for (the equivalent of?) editintro and preload
		Resolved		DLynch	T179063 Clicking on the {{meetupsig}} button not enough for the Save button to be active

Event Timeline

• Elitre created this task.Oct 26 2017, 11:05 AM

Restricted Application removed a project: Patch-For-Review. · View Herald TranscriptOct 26 2017, 11:05 AM

• Elitre renamed this task from Clicking on the {{meetupsig}} button requires further changes for the Save button to be active to Clicking on the {{meetupsig}} button not enough for the Save button to be active.Oct 26 2017, 11:06 AM

Removing all the extraneous stuff that happened here.

I guess the new preload functionality doesn't take in to account that the page is saveable, unlike when you're editing normally.

• Deskana moved this task from To Triage to TR1: Releases on the VisualEditor board.Oct 26 2017, 11:16 AM

jhsoby unsubscribed.Oct 26 2017, 12:12 PM

jeremyb-phone added a subscriber: Jim.henderson.Oct 26 2017, 1:14 PM

Change 386644 had a related patch set uploaded (by DLynch; owner: DLynch):
[mediawiki/extensions/VisualEditor@master] ArticleTarget: remember whether we preloaded, so it can affect the save button

https://gerrit.wikimedia.org/r/386644

gerritbot added a project: Patch-For-Review.Oct 26 2017, 4:36 PM

Change 386644 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] ArticleTarget: remember whether we preloaded, so it can affect the save button

https://gerrit.wikimedia.org/r/386644

ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2017-10-31 (1.31.0-wmf.6)).Oct 30 2017, 11:00 PM

• Deskana closed this task as Resolved.Oct 31 2017, 12:33 AM

• Deskana assigned this task to DLynch.

Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptOct 31 2017, 12:33 AM