Regular search box doesn't appear on deployment.beta
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Addshore
	Nov 10 2017, 9:59 AM

Description

deployment.beta (broken) https://deployment.wikimedia.beta.wmflabs.org/w/index.php?search=FooBar&title=Special:Search&go=Go&searchToken=5o574ab4kc8326k74aq66pdfr
de.wikipedia.beta (working) https://de.wikipedia.beta.wmflabs.org/w/index.php?search=FooBar&title=Special:Search&go=Go&searchToken=e5rar0kjf3h4tyzuxv03m2eva

The search text box field does not appear on deployment.wikimedia.beta for some reason.
We first thought this was due to an interaction with AdvancedSearch, but after disabling the issue remains, also AdvancedSearch works just find on other beta sites.

Details

	Subject	Repo	Branch	Lines +/-
	Disable AdvancedSearch on deployment.beta	operations/mediawiki-config	master	+1 -0

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Resolved	Addshore	T180201 Regular search box doesn't appear on deployment.beta
Open	None	T183498 MwWidgetsTitleInputWidget throws error on invalid content language
Resolved	Addshore	T183499 Fix wgContentLanguage on deployment.wikimedia.beta

Event Timeline

Addshore created this task.Nov 10 2017, 9:59 AM

Restricted Application added projects: TCB-Team (now WMDE-TechWish), Design. · View Herald TranscriptNov 10 2017, 9:59 AM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

This project was archived https://phabricator.wikimedia.org/project/manage/808/#40659 by @Aklapper. Is the extension active again?

@MarcoAurelio no, this was mislabeled. We use the same name, since the other project was archived and it just describes so well what we do :) The active one is Advanced-Search

Lea_WMDE moved this task from Backlog to Doing (others) on the Advanced-Search board.Nov 10 2017, 10:23 AM

In T180201#3750280, @MarcoAurelio wrote:

This project was archived https://phabricator.wikimedia.org/project/manage/808/#40659 by @Aklapper. Is the extension active again?

Hmm, it seems that tag might be for an old project / the old advanced search.
It might be worth renaming it / removing the hashtag so that it doesn't accidently get used for the code that is now in MediaWiki-extensions-AdvancedSearch

Addshore renamed this task from AdvancedSearch magnifying glass images seems out of place or has bad margins to Regular search box doesn't appear alongside AdvancedSearch on deployment.beta.Nov 10 2017, 11:15 AM

Addshore updated the task description. (Show Details)

Change 390392 had a related patch set uploaded (by Addshore; owner: Addshore):
[operations/mediawiki-config@master] Disable AdvancedSearch on deployment.beta

https://gerrit.wikimedia.org/r/390392

gerritbot added a project: Patch-For-Review.Nov 10 2017, 11:16 AM

Change 390392 merged by jenkins-bot:
[operations/mediawiki-config@master] Disable AdvancedSearch on deployment.beta

https://gerrit.wikimedia.org/r/390392

Mentioned in SAL (#wikimedia-operations) [2017-11-10T11:21:41Z] <addshore@tin> Synchronized wmf-config/InitialiseSettings-labs.php: [[gerrit:390392|Disable AdvancedSearch on deployment.beta]] BETA ONLY T180201 (duration: 00m 46s)

So even after disabling AdvancedSearch it appears that this is still an issue on deployment.beta

Addshore renamed this task from Regular search box doesn't appear alongside AdvancedSearch on deployment.beta to Regular search box doesn't appear on deployment.beta.Nov 10 2017, 11:27 AM

Addshore edited projects, added Beta-Cluster-Infrastructure; removed Patch-For-Review, WMDE-TechWish, WMDE-Design, Advanced-Search, Design, TCB-Team (now WMDE-TechWish).

Addshore updated the task description. (Show Details)

Addshore mentioned this in T180208: On beta, the advancedSearch does not work.

Addshore mentioned this in T180204: AdvancedSearch does not reliably show up on beta.

I get the following in the JS console on deployment.beta and not on other beta sites

load.php?debug=true&lang=en&modules=jquery%2Cmediawiki|mediawiki.legacy.wikibits&only=scripts&skin=vector&version=1b46sjy:3860 jQuery.Deferred exception: Invalid language tag: deployment RangeError: Invalid language tag: deployment
    at new Collator (native)
    at MwWidgetsSearchInputWidget.MwWidgetsTitleWidget (https://deployment.wikimedia.beta.wmflabs.org/w/resources/src/mediawiki.widgets/mw.widgets.TitleWidget.js?0e056:55:4)
    at MwWidgetsSearchInputWidget.MwWidgetsTitleInputWidget (https://deployment.wikimedia.beta.wmflabs.org/w/resources/src/mediawiki.widgets/mw.widgets.TitleInputWidget.js?ca1e3:32:26)
    at new MwWidgetsSearchInputWidget (https://deployment.wikimedia.beta.wmflabs.org/w/resources/src/mediawiki.widgets/mw.widgets.SearchInputWidget.js?80ca9:40:39)
    at Object.OO.ui.Element.static.unsafeInfuse (https://deployment.wikimedia.beta.wmflabs.org/w/resources/lib/oojs-ui/oojs-ui-core.js?b969b:797:8)
    at Object.OO.ui.Element.static.infuse (https://deployment.wikimedia.beta.wmflabs.org/w/resources/lib/oojs-ui/oojs-ui-core.js?b969b:664:33)
    at Object.OO.ui.infuse (https://deployment.wikimedia.beta.wmflabs.org/w/resources/lib/oojs-ui/oojs-ui-core.js?b969b:340:30)
    at HTMLDocument.<anonymous> (https://deployment.wikimedia.beta.wmflabs.org/w/resources/src/mediawiki.special/mediawiki.special.search.js?78212:36:24)
    at mightThrow (https://deployment.wikimedia.beta.wmflabs.org/w/load.php?debug=true&lang=en&modules=jquery%2Cmediawiki%7Cmediawiki.legacy.wikibits&only=scripts&skin=vector&version=1b46sjy:3583:29)
    at process (https://deployment.wikimedia.beta.wmflabs.org/w/load.php?debug=true&lang=en&modules=jquery%2Cmediawiki%7Cmediawiki.legacy.wikibits&only=scripts&skin=vector&version=1b46sjy:3651:12) undefined
jQuery.Deferred.exceptionHook @ load.php?debug=true&lang=en&modules=jquery%2Cmediawiki|mediawiki.legacy.wikibits&only=scripts&skin=vector&version=1b46sjy:3860
process @ load.php?debug=true&lang=en&modules=jquery%2Cmediawiki|mediawiki.legacy.wikibits&only=scripts&skin=vector&version=1b46sjy:3655
setTimeout (async)
(anonymous) @ load.php?debug=true&lang=en&modules=jquery%2Cmediawiki|mediawiki.legacy.wikibits&only=scripts&skin=vector&version=1b46sjy:3689
fire @ load.php?debug=true&lang=en&modules=jquery%2Cmediawiki|mediawiki.legacy.wikibits&only=scripts&skin=vector&version=1b46sjy:3317
add @ load.php?debug=true&lang=en&modules=jquery%2Cmediawiki|mediawiki.legacy.wikibits&only=scripts&skin=vector&version=1b46sjy:3376
(anonymous) @ load.php?debug=true&lang=en&modules=jquery%2Cmediawiki|mediawiki.legacy.wikibits&only=scripts&skin=vector&version=1b46sjy:3709
jQuery.Deferred @ load.php?debug=true&lang=en&modules=jquery%2Cmediawiki|mediawiki.legacy.wikibits&only=scripts&skin=vector&version=1b46sjy:10866
then @ load.php?debug=true&lang=en&modules=jquery%2Cmediawiki|mediawiki.legacy.wikibits&only=scripts&skin=vector&version=1b46sjy:3694
jQuery.fn.ready @ load.php?debug=true&lang=en&modules=jquery%2Cmediawiki|mediawiki.legacy.wikibits&only=scripts&skin=vector&version=1b46sjy:3882
jQuery.fn.init @ load.php?debug=true&lang=en&modules=jquery%2Cmediawiki|mediawiki.legacy.wikibits&only=scripts&skin=vector&version=1b46sjy:3050
jQuery.fn.init @ load.php?debug=true&lang=en&modules=jquery%2Cmediawiki|mediawiki.legacy.wikibits&only=scripts&skin=vector&version=1b46sjy:10393
jQuery @ load.php?debug=true&lang=en&modules=jquery%2Cmediawiki|mediawiki.legacy.wikibits&only=scripts&skin=vector&version=1b46sjy:98
(anonymous) @ mediawiki.special.search.js?78212:5
(anonymous) @ mediawiki.special.search.js?78212:60

load.php?debug=true&lang=en&modules=jquery%2Cmediawiki|mediawiki.legacy.wikibits&only=scripts&skin=vector&version=1b46sjy:3869 Uncaught RangeError: Invalid language tag: deployment
    at new Collator (native)
    at MwWidgetsSearchInputWidget.MwWidgetsTitleWidget (https://deployment.wikimedia.beta.wmflabs.org/w/resources/src/mediawiki.widgets/mw.widgets.TitleWidget.js?0e056:55:4)
    at MwWidgetsSearchInputWidget.MwWidgetsTitleInputWidget (https://deployment.wikimedia.beta.wmflabs.org/w/resources/src/mediawiki.widgets/mw.widgets.TitleInputWidget.js?ca1e3:32:26)
    at new MwWidgetsSearchInputWidget (https://deployment.wikimedia.beta.wmflabs.org/w/resources/src/mediawiki.widgets/mw.widgets.SearchInputWidget.js?80ca9:40:39)
    at Object.OO.ui.Element.static.unsafeInfuse (https://deployment.wikimedia.beta.wmflabs.org/w/resources/lib/oojs-ui/oojs-ui-core.js?b969b:797:8)
    at Object.OO.ui.Element.static.infuse (https://deployment.wikimedia.beta.wmflabs.org/w/resources/lib/oojs-ui/oojs-ui-core.js?b969b:664:33)
    at Object.OO.ui.infuse (https://deployment.wikimedia.beta.wmflabs.org/w/resources/lib/oojs-ui/oojs-ui-core.js?b969b:340:30)
    at HTMLDocument.<anonymous> (https://deployment.wikimedia.beta.wmflabs.org/w/resources/src/mediawiki.special/mediawiki.special.search.js?78212:36:24)
    at mightThrow (https://deployment.wikimedia.beta.wmflabs.org/w/load.php?debug=true&lang=en&modules=jquery%2Cmediawiki%7Cmediawiki.legacy.wikibits&only=scripts&skin=vector&version=1b46sjy:3583:29)
    at process (https://deployment.wikimedia.beta.wmflabs.org/w/load.php?debug=true&lang=en&modules=jquery%2Cmediawiki%7Cmediawiki.legacy.wikibits&only=scripts&skin=vector&version=1b46sjy:3651:12)

Addshore added a project: MediaWiki-Search.Nov 10 2017, 11:36 AM

Restricted Application added projects: Discovery-ARCHIVED, Discovery-Search. · View Herald TranscriptNov 10 2017, 11:36 AM

Addshore edited projects, added Beta-Cluster-reproducible; removed Beta-Cluster-Infrastructure.Nov 10 2017, 11:37 AM

Addshore merged a task: T180208: On beta, the advancedSearch does not work.

Addshore added projects: User-Addshore, JavaScript.Nov 10 2017, 11:42 AM

Addshore moved this task from Unsorted 💣 to Watching 👀 on the User-Addshore board.

debt removed projects: Discovery-Search, Discovery-ARCHIVED.Nov 16 2017, 6:20 PM

Tgr added subtasks: T183498: MwWidgetsTitleInputWidget throws error on invalid content language, T183499: Fix wgContentLanguage on deployment.wikimedia.beta.Dec 21 2017, 8:42 PM

Addshore closed this task as Resolved.Dec 23 2017, 12:20 PM

Addshore claimed this task.

Addshore closed subtask T183499: Fix wgContentLanguage on deployment.wikimedia.beta as Resolved.

Addshore moved this task from Watching 👀 to Closing ✔️ on the User-Addshore board.Dec 23 2017, 12:30 PM