Page MenuHomePhabricator
Create Task
Maniphest T180332

Syntax highlighting missing in mobile app
Open, Needs TriagePublic
Actions

Description

At least the iOS, but likely also the Android app, do not apply syntax highlighting to articles or Modules containing code.

Example, the article Lua (programming language)

Details

ProjectBranchLines +/-Subject
apps/android/wikipediamaster+4 -4Include syntax highlighting CSS styles.
Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 OpenNoneT180332 Syntax highlighting missing in mobile app
 ResolvedMhurdT180846 Fix code highlight theme-ing

Event Timeline

TheDJ created this task.Nov 13 2017, 10:30 AM
Restricted Application added a project: Wikipedia-Android-App-Backlog. · View Herald TranscriptNov 13 2017, 10:30 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
H78c67c added a subscriber: H78c67c.Nov 13 2017, 11:36 AM
Liuxinyu970226 added a subscriber: Liuxinyu970226.Nov 15 2017, 1:46 PM
gerritbot added a subscriber: gerritbot.Nov 17 2017, 4:41 PM

Change 392067 had a related patch set uploaded (by Dbrant; owner: Dbrant):
[apps/android/wikipedia@master] Include syntax highlighting CSS styles.

https://gerrit.wikimedia.org/r/392067

gerritbot added a project: Patch-For-Review.Nov 17 2017, 4:42 PM
Dbrant claimed this task.Nov 17 2017, 5:21 PM
Dbrant added a project: Wikipedia-iOS-App-Backlog.
Mhurd created subtask T180846: Fix code highlight theme-ing.Nov 17 2017, 8:59 PM
gerritbot added a comment.Nov 27 2017, 1:24 PM

Change 392067 merged by jenkins-bot:
[apps/android/wikipedia@master] Include syntax highlighting CSS styles.

https://gerrit.wikimedia.org/r/392067

JMinor moved this task from Needs Triage to Product Backlog on the Wikipedia-iOS-App-Backlog board.Nov 27 2017, 8:21 PM
Tacsipacsi added a subscriber: Tacsipacsi.Dec 3 2017, 7:29 PM

<syntaxhighlight> works well in the latest alpha, but modules (e.g. Module:String) and CSS/JS pages (MediaWiki:Common.css/js) not. I suppose it doesn’t check the content type. Modules also don’t show documentation.

Dbrant moved this task from Needs Triage to Tracking on the Wikipedia-Android-App-Backlog board.Dec 6 2017, 1:53 PM
rafidaslam added a subscriber: rafidaslam.Dec 30 2017, 3:13 PM
JMinor closed subtask T180846: Fix code highlight theme-ing as Resolved.Jan 8 2018, 10:32 PM
LGoto removed a project: Wikipedia-iOS-App-Backlog.Mar 26 2019, 9:32 PM
Dbrant closed this task as Resolved.Apr 16 2019, 2:47 PM

Please reopen if still an issue.

Tacsipacsi reopened this task as Open.Apr 17 2019, 3:48 PM
In T180332#5114997, @Dbrant wrote:

Please reopen if still an issue.

Content model-based syntax highlight still doesn’t work.

DannyS712 removed a project: Patch-For-Review.Apr 27 2020, 1:20 AM
DannyS712 added a subscriber: DannyS712.
In T180332#5119345, @Tacsipacsi wrote:
In T180332#5114997, @Dbrant wrote:

Please reopen if still an issue.

Content model-based syntax highlight still doesn’t work.

@Dbrant are you still working on this?

Dbrant removed Dbrant as the assignee of this task.Apr 27 2020, 12:25 PM
Dbrant added a subscriber: Dbrant.

Nope.

Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL