Decision should be documented here
Description
Description
Details
Details
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Make all Form IDs absolute, including the parents Lexeme ID | mediawiki/extensions/WikibaseLexeme | master | +84 -45 |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Open | None | T194253 Configure the CI job that runs WikibaseLexeme's browser tests against test wikidata | |||
| Resolved | Addshore | T168260 Deploy WikibaseLexeme extension on Wikimedia cluster | |||
| Resolved | Addshore | T191457 Deploy WikibaseLexeme on www.wikidata.org | |||
| Resolved | Addshore | T191458 Deploy WikibaseLexeme on test.wikidata.org | |||
| Resolved | Lydia_Pintscher | T168263 WikibaseLexeme functional baseline | |||
| Resolved | Lydia_Pintscher | T159703 [Tracking] Support for Forms and Senses | |||
| Resolved | Lydia_Pintscher | T150178 Wikidata 2017 Q2 goals | |||
| Resolved | Lydia_Pintscher | T169708 Wikidata 2017 Q3 goals | |||
| Resolved | Lydia_Pintscher | T160052 [Epic] Support for Forms | |||
| Resolved | Lydia_Pintscher | T160526 [Story] List of Statements for a Form | |||
| Resolved | thiemowmde | T163724 persistently addable/editable/removable statements on a Form via the UI (L) | |||
| Resolved | thiemowmde | T180464 Investigation: If and how form IDs like F1 and L1-F1 should co-exist in the code base |
Event Timeline
Comment Actions
Change 391244 had a related patch set uploaded (by Thiemo Mättig (WMDE); owner: Thiemo Mättig (WMDE)):
[mediawiki/extensions/WikibaseLexeme@master] Make all Form IDs absolute, including the parents Lexeme ID
Comment Actions
Investigation concluded: IDs like L1-F1 are to be used everywhere in the code. @daniel and @thiemowmde claimed there is no motivation to have a different object that would only repesent F1-alike IDs, so it is not going to be introduced.
Comment Actions
The patch https://gerrit.wikimedia.org/r/391244 was a direct result of this task. But since this ticket got closed before the patch was merged, the patch is "orphaned" now. How would anybody ever look at it again?
- It's in a chain of patches that block T180469: Make Forms and FormId implement Entity interfaces, which can't be closed without also reviewing the "orphaned" patch.
- Or somebody needs to create a Phabricator ticket for the sole purpose of splitting "investigation" and "realization" into two different tickets, assign the patch to that new ticket, move that to the sprint, probably discuss it first (because we never said we will actually work on this, or did we?), and probably close the ticket ten minutes later when the review is done. Holy cow.
Comment Actions
we never said we will actually work on this, or did we?)
We said we will do this work. In the notes from the sprint start it reads that we will "make a decision and implement the decision".
Comment Actions
Change 391244 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] Make all Form IDs absolute, including the parents Lexeme ID