Page MenuHomePhabricator

Investigation: If and how form IDs like F1 and L1-F1 should co-exist in the code base
Closed, ResolvedPublic

Description

Decision should be documented here

Details

Related Gerrit Patches:
mediawiki/extensions/WikibaseLexeme : masterMake all Form IDs absolute, including the parents Lexeme ID

Event Timeline

Change 391244 had a related patch set uploaded (by Thiemo Mättig (WMDE); owner: Thiemo Mättig (WMDE)):
[mediawiki/extensions/WikibaseLexeme@master] Make all Form IDs absolute, including the parents Lexeme ID

https://gerrit.wikimedia.org/r/391244

thiemowmde moved this task from Backlog to Review on the Wikidata-Sprint-2017-11-07 board.
WMDE-leszek added a subscriber: daniel.

Investigation concluded: IDs like L1-F1 are to be used everywhere in the code. @daniel and @thiemowmde claimed there is no motivation to have a different object that would only repesent F1-alike IDs, so it is not going to be introduced.

The patch https://gerrit.wikimedia.org/r/391244 was a direct result of this task. But since this ticket got closed before the patch was merged, the patch is "orphaned" now. How would anybody ever look at it again?

  1. It's in a chain of patches that block T180469: Make Forms and FormId implement Entity interfaces, which can't be closed without also reviewing the "orphaned" patch.
  2. Or somebody needs to create a Phabricator ticket for the sole purpose of splitting "investigation" and "realization" into two different tickets, assign the patch to that new ticket, move that to the sprint, probably discuss it first (because we never said we will actually work on this, or did we?), and probably close the ticket ten minutes later when the review is done. Holy cow.

we never said we will actually work on this, or did we?)

We said we will do this work. In the notes from the sprint start it reads that we will "make a decision and implement the decision".

Change 391244 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] Make all Form IDs absolute, including the parents Lexeme ID

https://gerrit.wikimedia.org/r/391244

thiemowmde closed this task as Resolved.Nov 21 2017, 11:10 AM
thiemowmde moved this task from Review to Done on the Wikidata-Sprint-2017-11-07 board.
thiemowmde removed a project: Patch-For-Review.