Page MenuHomePhabricator
Create Task
Maniphest T180469

Make Forms and FormId implement Entity interfaces
Closed, ResolvedPublic
Actions

Description

Form is supposed to implement the EntityDocument interface
FormId is supposed to implement the EntityId interface

Patch-For-Review:

Details

SubjectRepoBranchLines +/-
Make Form extend EntityDocumentmediawiki/extensions/WikibaseLexememaster+212 -2
Allow FormId to be prefixed, as required via EntityIdmediawiki/extensions/WikibaseLexememaster+20 -15
Make FormId extend EntityIdmediawiki/extensions/WikibaseLexememaster+38 -7
Customize query in gerrit

Related Objects
Search...

Event Timeline

WMDE-leszek created this task.Nov 14 2017, 2:14 PM
gerritbot added a comment.Nov 17 2017, 11:59 AM

Change 392032 had a related patch set uploaded (by Thiemo Mättig (WMDE); owner: Thiemo Mättig (WMDE)):
[mediawiki/extensions/WikibaseLexeme@master] Make FormId extend EntityId

https://gerrit.wikimedia.org/r/392032

gerritbot added a project: Patch-For-Review.Nov 17 2017, 11:59 AM

Change 392033 had a related patch set uploaded (by Thiemo Mättig (WMDE); owner: Thiemo Mättig (WMDE)):
[mediawiki/extensions/WikibaseLexeme@master] Make Form extend EntityDocument

https://gerrit.wikimedia.org/r/392033

thiemowmde mentioned this in rEWLEa8f9b07187c8: Make FormId extend EntityId.Nov 17 2017, 12:00 PM
thiemowmde mentioned this in rEWLE21e33d4fe489: Make Form extend EntityDocument.
thiemowmde moved this task from Backlog to Review on the Wikidata-Sprint-2017-11-07 board.Nov 17 2017, 12:13 PM
thiemowmde mentioned this in rEWLEdc8fd46ddfa7: Make Form extend EntityDocument.Nov 17 2017, 2:43 PM
thiemowmde mentioned this in T180464: Investigation: If and how form IDs like F1 and L1-F1 should co-exist in the code base.Nov 20 2017, 11:47 AM
WMDE-leszek mentioned this in rEWLEe78c23ff4f85: Make FormId extend EntityId.Nov 20 2017, 12:15 PM
WMDE-leszek mentioned this in rEWLE6314881e7466: Make Form extend EntityDocument.
thiemowmde mentioned this in rEWLEb34f6bb6d742: Make Form extend EntityDocument.Nov 20 2017, 3:54 PM
WMDE-leszek mentioned this in rEWLE37dacdc7f298: Make FormId extend EntityId.Nov 21 2017, 10:25 AM
WMDE-leszek assigned this task to thiemowmde.Nov 21 2017, 1:37 PM
WMDE-leszek added a project: Wikidata-Sprint-2017-11-22.Nov 21 2017, 2:59 PM
WMDE-leszek moved this task from Backlog to Review on the Wikidata-Sprint-2017-11-22 board.
thiemowmde mentioned this in rEWLE62910519a26d: Make Form extend EntityDocument.Nov 21 2017, 3:01 PM
gerritbot added a comment.Nov 21 2017, 4:46 PM

Change 392675 had a related patch set uploaded (by Thiemo Mättig (WMDE); owner: Thiemo Mättig (WMDE)):
[mediawiki/extensions/WikibaseLexeme@master] Allow FormId to be prefixed, as required via EntityId

https://gerrit.wikimedia.org/r/392675

thiemowmde mentioned this in rEWLE36f7904e13d6: Allow FormId to be prefixed, as required via EntityId.Nov 21 2017, 4:47 PM
thiemowmde mentioned this in rEWLE2257d9b605de: Make Form extend EntityDocument.
gerritbot added a comment.Nov 22 2017, 7:37 AM

Change 392032 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] Make FormId extend EntityId

https://gerrit.wikimedia.org/r/392032

gerritbot added a comment.Nov 22 2017, 7:37 AM

Change 392675 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] Allow FormId to be prefixed, as required via EntityId

https://gerrit.wikimedia.org/r/392675

thiemowmde added a project: User-thiemowmde.Nov 22 2017, 3:40 PM
thiemowmde moved this task from Incoming to Monitoring on the User-thiemowmde board.
thiemowmde updated the task description. (Show Details)Nov 22 2017, 3:53 PM
thiemowmde mentioned this in rEWLE9fe6f18b9d4d: Make Form extend EntityDocument.Nov 22 2017, 3:55 PM
gerritbot added a comment.Nov 22 2017, 4:18 PM

Change 392033 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] Make Form extend EntityDocument

https://gerrit.wikimedia.org/r/392033

WMDE-leszek moved this task from Review to Done on the Wikidata-Sprint-2017-11-22 board.Nov 22 2017, 4:35 PM
thiemowmde closed this task as Resolved.Nov 23 2017, 4:41 PM
thiemowmde removed projects: User-thiemowmde, Patch-For-Review.
thiemowmde updated the task description. (Show Details)
thiemowmde moved this task from incoming to in progress on the Wikidata board.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL