Page MenuHomePhabricator

it:voy needs Kartographer to shows ordered POI on specific template
Open, LowPublic

Description

Kartographer associates incremental POI according to their position inside the wikicode, but in it:voy we use some LUA templates that alphabetically order their content.
What we need is to implement the same LUA sort function inside Kartographer, to be used everytime those template are called otherwise there is a discrepancy between the POI numbers inside the article and the POI numbers shown in the map

Templates:

Module:

Details

Related Gerrit Patches:
mediawiki/extensions/Kartographer : masterAllow 2-digit numeric markers

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 29 2017, 8:04 AM
MaxSem added a subscriber: MaxSem.Nov 29 2017, 8:33 AM

You can already specify the marker symbol directly:

<mapframe width="350" height="350" zoom="13" longitude="-122.39953994750977" latitude="37.81032643553478">
{
  "type": "Feature",
  "geometry": { "type": "Point", "coordinates": [-122.3988, 37.8013] },
  "properties": {
    "marker-symbol": "3",
    "marker-size": "small",
    "marker-color": "0050d0"
  }
}
</mapframe>

One problem is that although the specification allows only one numeric character per marker, the tile server supports 2 however Kartographer is being true to the spec and doesn't permit 2 digits - that is, however, trivial to fix. Would this solution work for you?

Change 394020 had a related patch set uploaded (by MaxSem; owner: MaxSem):
[mediawiki/extensions/Kartographer@master] Allow 2-digit numeric markers

https://gerrit.wikimedia.org/r/394020

debt moved this task from Backlog to Needs review on the Maps-Sprint board.
debt added a subscriber: Fjalapeno.

@MaxSem can your patch be integrated into the LUA script mentioned above?
In the affirmative case it could be an efficient patch, otherwise the same LUA order function should be inserted inside the extension and activated any time the above templates are used inside the wiki-code.

MSantos added a subscriber: MSantos.Jul 3 2018, 4:41 PM
Mholloway triaged this task as Low priority.Sep 25 2018, 3:51 PM
Mholloway moved this task from Unsorted to Wikivoyage on the Maps (Kartographer) board.