Page MenuHomePhabricator

VE image search doesn't find images if the search query is entered too soon after the dialogue opens
Open, LowPublic1 Estimated Story Points

Description

I have encounter a problem with adding images to gallery using VisualEditor. The software was not behaving like that in the past. If I add manually the image name, VE ends with no result. Steps to reproduce are in this video, the problem starts to be evident at 1.24. https://www.youtube.com/watch?v=2FBs73T68GI

The only way, how to bypass this problem is delete preload string in search box and paste mine. Otherwise it ends like described before. Tested in both FF and Chrome, loged in, loggout.

I would remove this behaviour, because it eats time of an editor. If adding one gallery, its just a few seconds, but last time, we were doing this for hundreds of articles and than the time rise up.

Event Timeline

Deskana changed the task status from Open to Stalled.Dec 5 2017, 7:44 PM
Deskana added a subscriber: Deskana.

Here's what I tried to reproduce this problem:

  1. Go to a page on the Czech Wikipedia (e.g. random page took me to https://cs.wikipedia.org/wiki/Ipkg)
  2. Edit the page in the visual editor
  3. Click "Insert", then "More", then "Gallery"
  4. Paste "Loučová (009).jpg" into the search field

When I did the above, the image was shown. I see quite clearly in your video that you got no results, but I have no idea why.

Screen Shot 2017-12-05 at 19.39.49.png (744×1 px, 282 KB)

Are you experiencing this problem elsewhere, such as when trying to insert an image normally, or only when you try to insert in a gallery?

matej_suchanek renamed this task from VE doesnt find and existing image to VE doesn't find an existing image.Dec 7 2017, 5:52 PM

Yes, when I enter a single file it is also happening. I think it might be a couse of time. If I give it more time it works, if I past there inmediately the image name it doesnt work.

Deskana renamed this task from VE doesn't find an existing image to VE image search doesn't find images if the search query is entered too fast after the dialogue opens.Dec 13 2017, 11:05 AM
Deskana changed the task status from Stalled to Open.

Yes, when I enter a single file it is also happening. I think it might be a couse of time. If I give it more time it works, if I past there inmediately the image name it doesnt work.

I tried testing this again, and I think you're right. This problem appears to be caused by the user entering a search query too fast after the dialogue opens.

Deskana triaged this task as Medium priority.Dec 13 2017, 11:06 AM
Deskana set the point value for this task to 1.
Deskana moved this task from To Triage to TR1: Releases on the VisualEditor board.
Deskana lowered the priority of this task from Medium to Low.Apr 12 2018, 4:40 PM
Deskana moved this task from TR1: Releases to Freezer on the VisualEditor board.

This happens sometimes when you're just typing. For @NH, "too fast" sometimes seems to be more than one character per three seconds, which sounds incredibly annoying. See https://www.mediawiki.org/wiki/Topic:Uabedjl98qqt3gw1 for a description.

This happens sometimes when you're just typing. For @NH, "too fast" sometimes seems to be more than one character per three seconds, which sounds incredibly annoying. See https://www.mediawiki.org/wiki/Topic:Uabedjl98qqt3gw1 for a description.

So, I didn't title this bug as accurately as I could. It's not really got anything to do with speed. A better title would be "VE image search doesn't find images if the search query is entered too soon after the dialogue opens" (emphasis to indicate the change). Once the dialogue fully loads, there should be no issues with search. The issue reported by NH where the time between keystrokes affects his results sounds like a separate issue to me. (He may also be encountering this issue in addition to the other one, which confuses matters further.)

Deskana renamed this task from VE image search doesn't find images if the search query is entered too fast after the dialogue opens to VE image search doesn't find images if the search query is entered too soon after the dialogue opens.Apr 25 2018, 8:13 AM

This happens sometimes when you're just typing. For @NH, "too fast" sometimes seems to be more than one character per three seconds, which sounds incredibly annoying. See https://www.mediawiki.org/wiki/Topic:Uabedjl98qqt3gw1 for a description.

So, I didn't title this bug as accurately as I could. It's not really got anything to do with speed. A better title would be "VE image search doesn't find images if the search query is entered too soon after the dialogue opens" (emphasis to indicate the change). Once the dialogue fully loads, there should be no issues with search. The issue reported by NH where the time between keystrokes affects his results sounds like a separate issue to me. (He may also be encountering this issue in addition to the other one, which confuses matters further.)

Do you want it filed separately?

This can be reproduced every time when pasting an image name. Once it doesn't reproduce anymore, just edit a different article.

Couldn't it be fixed by starting a second search when the first one doesn't find anything (and before showing the "No results found" message to the user? Or maybe waiting for the search component to be fully loaded?