Page MenuHomePhabricator
Create Task
Maniphest T182270

Format tools (bold, italic, etc.) in toolbar don't work (regression in wmf.11)
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

The format tools (bold, italic, strikethrough, superscript, etc.) in the toolbar don't work. Selecting text and clicking one of these tools does not change the formatting of the text and does not cause a JS error or do anything else. The keyboard shortcuts (Ctrl+B, Ctrl+I, Ctrl+Shift+5, etc.) do still work.

Details

SubjectRepoBranchLines +/-
Update VE core submodule to master (cd6bce192)mediawiki/extensions/VisualEditormaster+1 -1
Update VE core submodule to 1.31.0-wmf.11 HEAD (56fe63b62)mediawiki/extensions/VisualEditorwmf/1.31.0-wmf.11+1 -1
Update VE core submodule to 1.31.0-wmf.11 HEAD (56fe63b62)mediawiki/extensions/VisualEditormaster+1 -1
Update VE core submodule to 1.31.0-wmf.11 HEAD (56fe63b62)mediawiki/extensions/VisualEditormaster+1 -1
Don't execute commands twiceVisualEditor/VisualEditorwmf/1.31.0-wmf.11+10 -7
Don't execute commands twiceVisualEditor/VisualEditormaster+10 -7
Customize query in gerrit

Related Objects

Event Timeline

Catrope created this task.Dec 7 2017, 12:56 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 7 2017, 12:56 AM
Catrope triaged this task as Unbreak Now! priority.Dec 7 2017, 12:56 AM
Restricted Application added subscribers: Liuxinyu970226, Jay8g, TerraCodes. · View Herald TranscriptDec 7 2017, 12:56 AM
dchan subscribed.Dec 7 2017, 3:35 AM

Oh, command.execute( surface ) is happening twice, and it so happens that the commands are self-inverse (toggling).

gerritbot subscribed.Dec 7 2017, 3:47 AM

Change 395919 had a related patch set uploaded (by Divec; owner: Divec):
[VisualEditor/VisualEditor@master] Don't execute commands twice

https://gerrit.wikimedia.org/r/395919

gerritbot added a project: Patch-For-Review.Dec 7 2017, 3:47 AM
Catrope added a comment.Dec 7 2017, 3:48 AM

Hah, that explains why buttons that open dialogs did work.

gerritbot added a comment.Dec 7 2017, 11:53 AM

Change 395919 merged by jenkins-bot:
[VisualEditor/VisualEditor@master] Don't execute commands twice

https://gerrit.wikimedia.org/r/395919

• Deskana set the point value for this task to 1.Dec 7 2017, 12:57 PM
• Deskana moved this task from To Triage to TR0: Interrupt on the VisualEditor board.
• Deskana subscribed.

Thanks @dchan!

Presumably this now needs a backport and SWAT deployment?

gerritbot added a comment.Dec 7 2017, 4:03 PM

Change 396034 had a related patch set uploaded (by Jforrester; owner: Divec):
[VisualEditor/VisualEditor@wmf/1.31.0-wmf.11] Don't execute commands twice

https://gerrit.wikimedia.org/r/396034

gerritbot added a comment.Dec 7 2017, 4:09 PM

Change 396039 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (cd6bce192)

https://gerrit.wikimedia.org/r/396039

gerritbot added a comment.Dec 7 2017, 4:18 PM

Change 396034 merged by Jforrester:
[VisualEditor/VisualEditor@wmf/1.31.0-wmf.11] Don't execute commands twice

https://gerrit.wikimedia.org/r/396034

gerritbot added a comment.Dec 7 2017, 4:24 PM

Change 396046 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to 1.31.0-wmf.11 HEAD (56fe63b62)

https://gerrit.wikimedia.org/r/396046

gerritbot added a comment.Dec 7 2017, 4:25 PM

Change 396046 abandoned by Jforrester:
Update VE core submodule to 1.31.0-wmf.11 HEAD (56fe63b62)

Reason:
Bah.

https://gerrit.wikimedia.org/r/396046

gerritbot added a comment.Dec 7 2017, 4:25 PM

Change 396048 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to 1.31.0-wmf.11 HEAD (56fe63b62)

https://gerrit.wikimedia.org/r/396048

gerritbot added a comment.Dec 7 2017, 4:26 PM

Change 396050 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/VisualEditor@wmf/1.31.0-wmf.11] Update VE core submodule to 1.31.0-wmf.11 HEAD (56fe63b62)

https://gerrit.wikimedia.org/r/396050

gerritbot added a comment.Dec 7 2017, 4:26 PM

Change 396048 abandoned by Jforrester:
Update VE core submodule to 1.31.0-wmf.11 HEAD (56fe63b62)

Reason:
Everything about switching to "clever" tracking in git review is terrible.

https://gerrit.wikimedia.org/r/396048

Jdforrester-WMF subscribed.Dec 7 2017, 4:27 PM
In T182270#3819882, @Deskana wrote:

Thanks @dchan!

Presumably this now needs a backport and SWAT deployment?

Yes.

Pull-through for master is https://gerrit.wikimedia.org/r/396039

Pull-through to wmf.11 for SWAT is https://gerrit.wikimedia.org/r/396050

gerritbot added a comment.Dec 7 2017, 5:26 PM

Change 396039 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (cd6bce192)

https://gerrit.wikimedia.org/r/396039

gerritbot added a comment.Dec 7 2017, 5:31 PM

Change 396050 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@wmf/1.31.0-wmf.11] Update VE core submodule to 1.31.0-wmf.11 HEAD (56fe63b62)

https://gerrit.wikimedia.org/r/396050

• Deskana closed this task as Resolved.Dec 7 2017, 5:45 PM
• Deskana claimed this task.
• Deskana added a subscriber: • demon.

This was backported. Thanks @demon for the deployment!

Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptDec 7 2017, 5:45 PM
ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2017-12-05 (1.31.0-wmf.11)).Dec 7 2017, 6:00 PM
Ryasmeen added projects: Verified, Verified-in-Phase0, Verified-in-Phase2.Dec 11 2017, 5:59 PM
Liuxinyu970226 unsubscribed.Dec 13 2017, 2:28 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL