Page MenuHomePhabricator

Format tools (bold, italic, etc.) in toolbar don't work (regression in wmf.11)
Closed, ResolvedPublic1 Story Points

Description

The format tools (bold, italic, strikethrough, superscript, etc.) in the toolbar don't work. Selecting text and clicking one of these tools does not change the formatting of the text and does not cause a JS error or do anything else. The keyboard shortcuts (Ctrl+B, Ctrl+I, Ctrl+Shift+5, etc.) do still work.

Event Timeline

Catrope created this task.Dec 7 2017, 12:56 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 7 2017, 12:56 AM
Catrope triaged this task as Unbreak Now! priority.Dec 7 2017, 12:56 AM
Restricted Application added subscribers: Liuxinyu970226, Jay8g, TerraCodes. · View Herald TranscriptDec 7 2017, 12:56 AM
dchan added a subscriber: dchan.Dec 7 2017, 3:35 AM

Oh, command.execute( surface ) is happening twice, and it so happens that the commands are self-inverse (toggling).

Change 395919 had a related patch set uploaded (by Divec; owner: Divec):
[VisualEditor/VisualEditor@master] Don't execute commands twice

https://gerrit.wikimedia.org/r/395919

Hah, that explains why buttons that open dialogs did work.

Change 395919 merged by jenkins-bot:
[VisualEditor/VisualEditor@master] Don't execute commands twice

https://gerrit.wikimedia.org/r/395919

Deskana set the point value for this task to 1.Dec 7 2017, 12:57 PM
Deskana moved this task from To Triage to TR0: Interrupt on the VisualEditor board.
Deskana added a subscriber: Deskana.

Thanks @dchan!

Presumably this now needs a backport and SWAT deployment?

Change 396034 had a related patch set uploaded (by Jforrester; owner: Divec):
[VisualEditor/VisualEditor@wmf/1.31.0-wmf.11] Don't execute commands twice

https://gerrit.wikimedia.org/r/396034

Change 396039 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (cd6bce192)

https://gerrit.wikimedia.org/r/396039

Change 396034 merged by Jforrester:
[VisualEditor/VisualEditor@wmf/1.31.0-wmf.11] Don't execute commands twice

https://gerrit.wikimedia.org/r/396034

Change 396046 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to 1.31.0-wmf.11 HEAD (56fe63b62)

https://gerrit.wikimedia.org/r/396046

Change 396046 abandoned by Jforrester:
Update VE core submodule to 1.31.0-wmf.11 HEAD (56fe63b62)

Reason:
Bah.

https://gerrit.wikimedia.org/r/396046

Change 396048 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to 1.31.0-wmf.11 HEAD (56fe63b62)

https://gerrit.wikimedia.org/r/396048

Change 396050 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/VisualEditor@wmf/1.31.0-wmf.11] Update VE core submodule to 1.31.0-wmf.11 HEAD (56fe63b62)

https://gerrit.wikimedia.org/r/396050

Change 396048 abandoned by Jforrester:
Update VE core submodule to 1.31.0-wmf.11 HEAD (56fe63b62)

Reason:
Everything about switching to "clever" tracking in git review is terrible.

https://gerrit.wikimedia.org/r/396048

Thanks @dchan!
Presumably this now needs a backport and SWAT deployment?

Yes.

Pull-through for master is https://gerrit.wikimedia.org/r/396039

Pull-through to wmf.11 for SWAT is https://gerrit.wikimedia.org/r/396050

Change 396039 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (cd6bce192)

https://gerrit.wikimedia.org/r/396039

Change 396050 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@wmf/1.31.0-wmf.11] Update VE core submodule to 1.31.0-wmf.11 HEAD (56fe63b62)

https://gerrit.wikimedia.org/r/396050

Deskana closed this task as Resolved.Dec 7 2017, 5:45 PM
Deskana claimed this task.
Deskana added a subscriber: demon.

This was backported. Thanks @demon for the deployment!

Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptDec 7 2017, 5:45 PM