Gerrit has fine-grained per-branch ACLs. I haven't been able to find documentation for access control in Phabricator. For feature parity with Gerrit, we'll at least need to lock down approval rights to certain user groups on a per-branch basis, with wildcard support (for all branches, grant approval rights to group X, but for branches of the form wmf/*, grant approval rights only to the deployers group).
|· · ·|
|Declined||None||T167 Align basics of current Gerrit code-review process with Differential|
|Resolved||mmodell||T183 Per-branch access control in code repositories|
|· · ·|
The main per-branch ACL we have right now is +2 and submit on wmf/* branches is limited to people in the wmf-deployment group, but +2 on all other branches is granted to the "mediawiki" group AFAIK.
The fun bit from IRC:
+ostriches> Although, if we do the Right Thing and move the deployment repo to a fork of MW and stop using submodules, we won't have need for those wmf/* branches everywhere.