Page MenuHomePhabricator
Create Task
Maniphest T185071

The tooltip and label for the publish (save) button do not match
Closed, ResolvedPublic
Actions

Description

[publishpage](https://translatewiki.net/wiki/MediaWiki:Publishpage/qqq) and [publishchanges](https://translatewiki.net/wiki/MediaWiki:Publishchanges/qqq) are used over [savearticle](https://translatewiki.net/wiki/MediaWiki:Savearticle/qqq) and [savechanges](https://translatewiki.net/wiki/MediaWiki:Savechanges/qqq) when [$wgEditSubmitButtonLabelPublish](https://www.mediawiki.org/wiki/Manual:$wgEditSubmitButtonLabelPublish) is true.

The tooltip should also be [tooltip-publish](https://translatewiki.net/wiki/MediaWiki:Tooltip-publish/qqq) over [tooltip-save](https://translatewiki.net/wiki/MediaWiki:Tooltip-save/qqq) to align the language (publish vs save).

Details

SubjectRepoBranchLines +/-
EditPage: Match the Save/Publish button's tooltip to its labelmediawiki/coremaster+12 -2
Customize query in gerrit

Related Objects
Search...

Event Timeline

JJMC89 created this task.Jan 17 2018, 5:49 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 17 2018, 5:49 AM
Kaartic subscribed.EditedJan 17 2018, 5:51 AM

How is this different from T183901: Reword post edit notification to reflect save->publish change on desktop ?

matmarex subscribed.Jan 17 2018, 4:21 PM

@Kaartic This task is about the tooltip on the save button:

image.png (101×493 px, 7 KB)

gerritbot subscribed.Jan 17 2018, 4:43 PM

Change 404718 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/core@master] EditPage: Match the Save/Publish button's tooltip to its label

https://gerrit.wikimedia.org/r/404718

gerritbot added a project: Patch-For-Review.Jan 17 2018, 4:43 PM
Jdforrester-WMF closed this task as Resolved.Jan 17 2018, 6:12 PM
Jdforrester-WMF assigned this task to matmarex.
Jdforrester-WMF triaged this task as Medium priority.
Jdforrester-WMF edited projects, added MW-1.31-release-notes (WMF-deploy-2018-02-06 (1.31.0-wmf.20)); removed Patch-For-Review.
gerritbot added a comment.Jan 17 2018, 6:23 PM

Change 404718 merged by jenkins-bot:
[mediawiki/core@master] EditPage: Match the Save/Publish button's tooltip to its label

https://gerrit.wikimedia.org/r/404718

JJMC89 added a subscriber: Jdforrester-WMF.Jan 17 2018, 11:38 PM

@matmarex @Jdforrester-WMF Are patches needed for extensions (e.g. EditEntityAction.php and ve.ui.MWSaveDialogAction.js)?

Jdforrester-WMF added a comment.Jan 18 2018, 12:09 AM
In T185071#3908121, @JJMC89 wrote:

@matmarex @Jdforrester-WMF Are patches needed for extensions (e.g. EditEntityAction.php and ve.ui.MWSaveDialogAction.js)?

Not for VE. For Wikidata, yes theoretically, but that page is only shown for undo operations (e.g. https://www.wikidata.org/w/index.php?title=Q23461410&action=edit&undoafter=603780727&undo=603798980) and I'm not sure it's worth it. Maybe open a task for that?

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits