Page MenuHomePhabricator

The tooltip and label for the publish (save) button do not match
Closed, ResolvedPublic


publishpage and publishchanges are used over savearticle and savechanges when $wgEditSubmitButtonLabelPublish is true.

The tooltip should also be tooltip-publish over tooltip-save to align the language (publish vs save).


Related Gerrit Patches:

Event Timeline

JJMC89 created this task.Jan 17 2018, 5:49 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 17 2018, 5:49 AM

@Kaartic This task is about the tooltip on the save button:

Change 404718 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/core@master] EditPage: Match the Save/Publish button's tooltip to its label

Jdforrester-WMF closed this task as Resolved.Jan 17 2018, 6:12 PM
Jdforrester-WMF assigned this task to matmarex.
Jdforrester-WMF triaged this task as Medium priority.

Change 404718 merged by jenkins-bot:
[mediawiki/core@master] EditPage: Match the Save/Publish button's tooltip to its label

@matmarex @Jdforrester-WMF Are patches needed for extensions (e.g. EditEntityAction.php and ve.ui.MWSaveDialogAction.js)?

Not for VE. For Wikidata, yes theoretically, but that page is only shown for undo operations (e.g. and I'm not sure it's worth it. Maybe open a task for that?