| TheDJ | |
| Jan 2 2018, 10:03 AM |
| F16438924: Screen Shot 2018-03-27 at 3.23.49 PM.png | |
| Mar 29 2018, 9:53 PM |
| F14756272: image.png | |
| Mar 8 2018, 6:05 PM |
| F12236443: Screenshot_2018-01-03-23-56-21.png | |
| Jan 4 2018, 5:19 AM |
I thought the word "saved" was replaced with "published" recently. I see most of the messages reflecting the change except the success message of VE. It still shows "Your edit was saved." and not "Your edit was published."
Reported: https://www.mediawiki.org/wiki/Topic:U4x93yxf8jom1pgc
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Declined | None | T163302 Consider to re-label "Save changes"/"Publish changes" to be "Save & Publish" | |||
| Resolved | Ladsgroup | T161367 Re-label the "Save" links to be "Publish" in structured data inline edit links on Wikidata.org | |||
| Resolved | Jdforrester-WMF | T131132 Re-label the "Save" button to be "Publish", to better indicate to users the outcomes of their action | |||
| Resolved | DLynch | T183901 Reword post edit notification to reflect save->publish change on desktop |
Here's another instance that probably has to be changed,
I guess it's related but different because the message shown is a little different
Change 348749 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/core@master] postEdit: Show a different success messsage on publish vs. save wikis
Change 348749 merged by jenkins-bot:
[mediawiki/core@master] postEdit: Show a different success messsage on publish vs. save wikis
When I save an edit on Wikipedia, it still says "Your edit was saved", not "Your edit was published". I am thus reopening this, which needs a more careful patch to be actually fixed.
Changes to code do not take immediate effect. Tasks are closed as resolved when the code is merged and will be automatically deployed. The change will go live next week.
Please ignore my above comment. I completely misread the ticket.
@GeoffreyT2000 is right; this isn't working, and it should be. The below screenshot is from the English Wikipedia.
Change 422174 had a related patch set uploaded (by DLynch; owner: DLynch):
[mediawiki/extensions/VisualEditor@master] DesktopArticleTarget: use -published message instead of -saved
This is the postedit-confirmation-saved message, which needs to get adjusted to postedit-confirmation-published in a few places.
Patch handles the VE cases.
There's also resources/src/mediawiki.action/mediawiki.action.view.postEdit.js which uses saved directly, if it's the value stored in the wgPostEdit config, which the classic EditPage setPostEditCookie does. Since that's entirely an old-editor path, I think, should it be updated as well or left alone?
Change 422174 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] DesktopArticleTarget: use -published message instead of -saved
I just noticed we haven't changed the wording of post edit notification for mobile VE to be "Published". Shouldn't we change it there as well?
I just noticed we haven't changed the wording of post edit notification for mobile VE to be "Published". Shouldn't we change it there as well?
@Ryasmeen You seem to be second person to report that on this task. T183901#3874213
I'm wondering this actually requires a separate task: T191104
This task was always about desktop because of the description, so this is resolved now.