Page MenuHomePhabricator

Can't insert templates in the visual and 2017 wikitext editor
Closed, ResolvedPublic1 Estimated Story Points

Description

Steps to reproduce:

  1. Load a page in the visual or 2017 wikitext editors
  2. Click "Insert"
  3. Click "Template"
  4. Type in the name of a template, e.g. "citation needed"
  5. Press enter or click on the item to choose the template

Expected behaviour:

  • "Add template" button is functional

Actual behaviour:

  • "Add template" button is greyed out and cannot be used

This is currently happening on all sites except Wikipedias.

Screen Shot 2018-01-18 at 17.30.31.png (1×1 px, 106 KB)

Event Timeline

Deskana triaged this task as Unbreak Now! priority.Jan 18 2018, 5:32 PM

Change 405023 had a related patch set uploaded (by DLynch; owner: DLynch):
[mediawiki/extensions/VisualEditor@master] Update TitleInput's getTitle to getMWTitle

https://gerrit.wikimedia.org/r/405023

Change 405023 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Update TitleInput's getTitle to getMWTitle

https://gerrit.wikimedia.org/r/405023

This patch is merged now, and now it needs a backport and SWAT deployment.

Change 405028 had a related patch set uploaded (by Deskana; owner: DLynch):
[mediawiki/extensions/VisualEditor@wmf/1.31.0-wmf.17] Update TitleInput's getTitle to getMWTitle

https://gerrit.wikimedia.org/r/405028

Change 405028 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@wmf/1.31.0-wmf.17] Update TitleInput's getTitle to getMWTitle

https://gerrit.wikimedia.org/r/405028

forgot to add the bug to the scap message so it'd show up here, but this is now deployed: https://tools.wmflabs.org/sal/log/AWEK1UGSkkJ8OkTwh3Dt

Deskana assigned this task to DLynch.
Deskana set the point value for this task to 1.

Resolvable?

Yep! Apologies for leaving it lying around.