Better test coverage for wikidiff2
Open, Needs TriagePublic
Actions

Assigned To

None

Authored By

	WMDE-Fisch
	Jan 23 2018, 4:12 PM

Description

We should add more edge cases to the wikidiff unittest patch to better evaluate our diff changes, and to exercise all code paths.

Need test coverage analysis
Identify any edge-case diffs which wouldn't be handled by simply getting to 100% code coverage.
Write tests until everything is covered.

Details

	Subject	Repo	Branch	Lines +/-
	Coverage report for PHP extensions	integration/config	master	+34 -0
	[WIP] Script to generate test coverage report	mediawiki/php/wikidiff2	master	+24 -0

Customize query in gerrit

Related Objects

Mentioned In: T235182: 20% things for 9.Oct sprint

Event Timeline

WMDE-Fisch created this task.Jan 23 2018, 4:12 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 23 2018, 4:12 PM

• Lea_WMDE moved this task from Proposed to Todo on the WMDE-TechWish board.Feb 6 2018, 2:53 PM

thiemowmde added a project: wikidiff2.Jun 12 2018, 4:18 PM

thiemowmde moved this task from Incoming to Show changes in moved text chunks on the TCB-Team (now WMDE-TechWish) board.

thiemowmde added a subscriber: • jkroll.

thiemowmde added a project: Test-Coverage.Jun 12 2018, 4:40 PM

thiemowmde added subscribers: • Lea_WMDE, Andrew-WMDE.

This patch was abandoned, https://gerrit.wikimedia.org/r/#/c/404294/

awight renamed this task from Add more cases to the wikidiff2 unittests to Better test coverage for wikidiff2.Oct 9 2019, 3:04 PM

awight updated the task description. (Show Details)

Change 542063 had a related patch set uploaded (by Awight; owner: Awight):
[mediawiki/php/wikidiff2@master] [WIP] Script to generate test coverage report

https://gerrit.wikimedia.org/r/542063

gerritbot added a project: Patch-For-Review.Oct 10 2019, 8:31 AM

Change 542071 had a related patch set uploaded (by Awight; owner: Awight):
[integration/config@master] [WIP] Coverage report for PHP extensions

https://gerrit.wikimedia.org/r/542071

Change 542063 abandoned by Awight:
[WIP] Script to generate test coverage report

Reason:
Moved to integration-config

https://gerrit.wikimedia.org/r/542063

@hashar If you're able to publish a new php70-compile image based on this patch, then I'll be able to smoke-test the Jenkins job and the publish step.

awight mentioned this in T235182: 20% things for 9.Oct sprint.Oct 10 2019, 3:11 PM

Change 542071 merged by jenkins-bot:
[integration/config@master] Coverage report for PHP extensions

https://gerrit.wikimedia.org/r/542071