Use OOUI dialog for CX suggestions
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Esanders
	Jan 29 2018, 4:27 PM

Description

CX uses a custom widget for modal poups when clicking on a suggestion:

It would better to use an OOUI dialog here (visual consistency, code de-duplication, better accessibility).

After https://gerrit.wikimedia.org/r/#/c/383570 this is the last remaining use of ext.cx.overlay.js.

Details

	Subject	Repo	Branch	Lines +/-
	SelectedSourcePage: Even out padding slightly when in a dialog	mediawiki/extensions/ContentTranslation	master	+14 -0
	Use OOUI dialog for CX suggestions	mediawiki/extensions/ContentTranslation	master	+80 -67

Customize query in gerrit

Related Objects

Mentioned In: T225299: When starting translation from suggestions, dialog does not fully fit sometimes

Event Timeline

Esanders created this task.Jan 29 2018, 4:27 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 29 2018, 4:27 PM

Removing the OOUI project, since it doesn't seem there are any bug reports or feature requests for OOUI here yet :)

matmarex unsubscribed.Jan 30 2018, 1:56 PM

Change 503648 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/ContentTranslation@master] Use OOUI dialog for CX suggestions

https://gerrit.wikimedia.org/r/503648

gerritbot added a project: Patch-For-Review.Apr 13 2019, 3:31 PM

Change 503649 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/ContentTranslation@master] SelectedSourcePage: Increase padding slightly when in a dialog

https://gerrit.wikimedia.org/r/503649

https://gerrit.wikimedia.org/r/503649 evens out the padding slightly in dialog mode:

Before	After

In T185900#5108929, @Esanders wrote:

https://gerrit.wikimedia.org/r/503649 evens out the padding slightly in dialog mode:

Before After

Looks good to me. Thanks!

Change 503648 merged by jenkins-bot:
[mediawiki/extensions/ContentTranslation@master] Use OOUI dialog for CX suggestions

https://gerrit.wikimedia.org/r/503648

Change 503649 merged by jenkins-bot:
[mediawiki/extensions/ContentTranslation@master] SelectedSourcePage: Even out padding slightly when in a dialog

https://gerrit.wikimedia.org/r/503649

ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.3; 2019-04-30).Apr 17 2019, 12:00 PM

santhosh triaged this task as Medium priority.Apr 18 2019, 4:15 AM

santhosh moved this task from Needs Triage to CX2 on the ContentTranslation board.

santhosh added a project: Language-Team (Language-2019-April-June).

santhosh moved this task from Backlog to Needs QA on the Language-Team (Language-2019-April-June) board.

• Petar.petkovic removed a project: Patch-For-Review.Apr 18 2019, 2:19 PM

• Petar.petkovic assigned this task to Esanders.Apr 19 2019, 10:07 AM

Etonkovidova moved this task from Needs QA to Recheck after deployment on the Language-Team (Language-2019-April-June) board.Apr 25 2019, 11:33 PM

Etonkovidova closed this task as Resolved.May 1 2019, 4:29 AM

Etonkovidova moved this task from Recheck after deployment to Done on the Language-Team (Language-2019-April-June) board.

• Petar.petkovic mentioned this in T225299: When starting translation from suggestions, dialog does not fully fit sometimes.Jun 7 2019, 11:25 AM