Page MenuHomePhabricator

Use OOUI dialog for CX suggestions
Closed, ResolvedPublic

Description

CX uses a custom widget for modal poups when clicking on a suggestion:

image.png (202×876 px, 34 KB)

It would better to use an OOUI dialog here (visual consistency, code de-duplication, better accessibility).

After https://gerrit.wikimedia.org/r/#/c/383570 this is the last remaining use of ext.cx.overlay.js.

Event Timeline

matmarex subscribed.

Removing the OOUI project, since it doesn't seem there are any bug reports or feature requests for OOUI here yet :)

Change 503648 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/ContentTranslation@master] Use OOUI dialog for CX suggestions

https://gerrit.wikimedia.org/r/503648

Change 503649 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/ContentTranslation@master] SelectedSourcePage: Increase padding slightly when in a dialog

https://gerrit.wikimedia.org/r/503649

https://gerrit.wikimedia.org/r/503649 evens out the padding slightly in dialog mode:

BeforeAfter
image.png (195×715 px, 32 KB)
image.png (217×714 px, 32 KB)

https://gerrit.wikimedia.org/r/503649 evens out the padding slightly in dialog mode:

BeforeAfter
image.png (195×715 px, 32 KB)
image.png (217×714 px, 32 KB)

Looks good to me. Thanks!

Change 503648 merged by jenkins-bot:
[mediawiki/extensions/ContentTranslation@master] Use OOUI dialog for CX suggestions

https://gerrit.wikimedia.org/r/503648

Change 503649 merged by jenkins-bot:
[mediawiki/extensions/ContentTranslation@master] SelectedSourcePage: Even out padding slightly when in a dialog

https://gerrit.wikimedia.org/r/503649