Page MenuHomePhabricator
Create Task
Maniphest T185934

Remove MobilePreferences from MobileFrontend
Closed, ResolvedPublic3 Estimated Story Points
Actions

Assigned To
ABorbaWMF
Authored By
Jdlrobson
Jan 29 2018, 8:32 PM
Tags
Referenced Files
F12944801: bs_realdroid_Mobile_Google Nexus 6-5.0-1440x2560.jpg
Feb 1 2018, 9:43 PM
F12944803: bs_realdroid_Mobile_Samsung Galaxy S5-4.4-1080x1920.jpg
Feb 1 2018, 9:43 PM
F12944802: bs_realios_Tablet_iPad Air 2-8.0.jpg
Feb 1 2018, 9:43 PM
F12944800: bs_realios_Mobile_iPhone X-11.0.jpg
Feb 1 2018, 9:43 PM
F12892438: localhost_8080_w_index.php_title=Special_Preferences(Nexus 5X) (5).png
Jan 30 2018, 4:30 PM
F12892443: localhost_8080_w_index.php_title=Special_Preferences(Nexus 5X) (4).png
Jan 30 2018, 4:30 PM
F12892420: localhost_8080_w_index.php_title=Special_Preferences(Nexus 5X) (3).png
Jan 30 2018, 4:30 PM
Subscribers
Aklapper
gerritbot
Jdlrobson
• Niedzielski
ovasileva
phuedx
pmiazga
Samwilson

Description

When speaking to @Samwilson during all hands he commented how MobileFrontend was creating problems for the global preferences work. When reviewing the state of the MobilePreferences code, I concluded that it's probably not necessary any more.

I suggest we load the core JavaScript on this page and remove our override in MobileFrontend. This will mean less code to maintain, we're unblock Sam's work.

The biggest issue with rendering the desktop preferences page on mobile is the horizontal menu at the top of the page (which does not scale well to a mobile skin) but given we do not link to preferences on mobile, making this horizontally scrollable should be an acceptable compromise.

QA steps

Visit https://en.wikipedia.beta.wmflabs.org/wiki/Special:Preferences and https://en.m.wikipedia.beta.wmflabs.org/wiki/Special:Preferences and verify the forms are functional (not necessarily usable/mobile friendly)

Details

SubjectRepoBranchLines +/-
Do not add non-existent skins.minerva.special.preferences.scriptsmediawiki/skins/MinervaNeuemaster+0 -5
Remove MobilePreferences in favor of coremediawiki/extensions/MobileFrontendmaster+0 -115
Customize query in gerrit

Event Timeline

Jdlrobson created this task.Jan 29 2018, 8:32 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 29 2018, 8:32 PM
gerritbot subscribed.Jan 29 2018, 8:32 PM

Change 406123 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/extensions/MobileFrontend@master] Remove MobilePreferences in favor of core

https://gerrit.wikimedia.org/r/406123

gerritbot added a project: Patch-For-Review.Jan 29 2018, 8:32 PM
gerritbot added a comment.Jan 29 2018, 8:53 PM

Change 406640 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/skins/MinervaNeue@master] Do not add non-existent skins.minerva.special.preferences.scripts

https://gerrit.wikimedia.org/r/406640

Samwilson added a comment.Jan 29 2018, 8:59 PM

Thanks @Jdlrobson.

Just to clarify, it's not blocking GlobalPreferences, it's just that because of GlobalPreferens we've deprecated some things that MobileFrontend uses. Much better to delete it rather than fixing it though! :-)

The other problem with the normal Special:Preferences is that it's a table-based layout, and so the label column can get pretty narrow on small screens and make some things pretty ugly. But as you say, it's unlikely to be used much on mobile — and ultimately (soon?) this will be fixed by switching to OOUI.

Samwilson added a project: Community-Tech-Sprint.Jan 30 2018, 1:09 AM
• Niedzielski subscribed.EditedJan 30 2018, 4:30 PM

Before (http://localhost:8080/w/index.php?title=Special:Preferences):

localhost_8080_w_index.php_title=Special_Preferences(Nexus 5X) (4).png (1×1 px, 143 KB)

With https://gerrit.wikimedia.org/r/#/c/406123/:

localhost_8080_w_index.php_title=Special_Preferences(Nexus 5X) (3).png (1×1 px, 212 KB)

With https://gerrit.wikimedia.org/r/#/c/406124/:

localhost_8080_w_index.php_title=Special_Preferences(Nexus 5X) (5).png (1×1 px, 236 KB)

pmiazga added a project: Web-Team-Backlog.Jan 30 2018, 5:09 PM
pmiazga added a project: Readers-Web-Kanbanana-Board-Old.
pmiazga moved this task from To Do to Needs More Work on the Readers-Web-Kanbanana-Board-Old board.Jan 30 2018, 5:12 PM
pmiazga subscribed.

Bringing into sprint for visibility

• Niedzielski set the point value for this task to 3.Jan 30 2018, 5:15 PM
Jdlrobson moved this task from Incoming to 2017-18 Q3 on the Web-Team-Backlog board.Jan 30 2018, 5:21 PM
Jdlrobson moved this task from Needs More Work to Doing on the Readers-Web-Kanbanana-Board-Old board.Jan 30 2018, 6:05 PM
Jdlrobson claimed this task.Jan 30 2018, 6:19 PM
Jdlrobson moved this task from Doing to Needs Code Review on the Readers-Web-Kanbanana-Board-Old board.

@pmiazga I'm not sure this "needs more work". All patches seem to have +1s now. Let me know if I'm missing something.

• Niedzielski added a comment.Jan 30 2018, 6:30 PM

@Jdlrobson, I left some optional feedback on a couple of the patches but functionally they're fine.

pmiazga removed a project: Patch-For-Review.Jan 31 2018, 6:30 PM
pmiazga moved this task from Needs Code Review to Needs QA on the Readers-Web-Kanbanana-Board-Old board.
Jdlrobson updated the task description. (Show Details)Jan 31 2018, 6:33 PM
Jdlrobson moved this task from Needs QA to Needs Code Review on the Readers-Web-Kanbanana-Board-Old board.Jan 31 2018, 6:37 PM

@pmiazga https://gerrit.wikimedia.org/r/#/c/406124 still needs review.

gerritbot added a comment.Jan 31 2018, 6:50 PM

Change 406123 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] Remove MobilePreferences in favor of core

https://gerrit.wikimedia.org/r/406123

ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2018-02-06 (1.31.0-wmf.20)).Jan 31 2018, 7:00 PM
gerritbot added a comment.Feb 1 2018, 12:41 AM

Change 406640 merged by jenkins-bot:
[mediawiki/skins/MinervaNeue@master] Do not add non-existent skins.minerva.special.preferences.scripts

https://gerrit.wikimedia.org/r/406640

phuedx added a project: Unplanned-Sprint-Work.Feb 1 2018, 10:09 AM
phuedx subscribed.

Reflecting reality.

pmiazga claimed this task.Feb 1 2018, 2:48 PM
pmiazga removed pmiazga as the assignee of this task.Feb 1 2018, 6:02 PM
pmiazga moved this task from Needs Code Review to Needs QA on the Readers-Web-Kanbanana-Board-Old board.
Jdlrobson assigned this task to ABorbaWMF.Feb 1 2018, 6:10 PM

Over to your Anthony.

ABorbaWMF moved this task from Needs QA to Ready for Signoff on the Readers-Web-Kanbanana-Board-Old board.Feb 1 2018, 9:43 PM

Looks good to me on Beta:

bs_realios_Mobile_iPhone X-11.0.jpg (520×240 px, 28 KB)

bs_realdroid_Mobile_Google Nexus 6-5.0-1440x2560.jpg (520×292 px, 33 KB)

bs_realdroid_Mobile_Samsung Galaxy S5-4.4-1080x1920.jpg (520×292 px, 36 KB)

bs_realios_Tablet_iPad Air 2-8.0.jpg (520×390 px, 44 KB)

ovasileva closed this task as Resolved.Feb 5 2018, 2:58 PM
ovasileva subscribed.

looks good!

Niharika moved this task from Ready to Q1 2018-19 on the Community-Tech-Sprint board.Feb 5 2018, 6:49 PM
• TBolliger edited projects, added Community-Tech; removed Community-Tech-Sprint.Feb 14 2018, 12:56 AM
• TBolliger moved this task from New & TBD Tickets to Archive on the Community-Tech board.Feb 14 2018, 1:12 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL