Page MenuHomePhabricator
Create Task
Maniphest T186884

parseWikitextFragment() expects exactly 3 parameters, 2 given in ApiVisualEditor
Closed, ResolvedPublic1 Estimated Story PointsPRODUCTION ERROR
Actions

Description

Spotted in production:

Warning: parseWikitextFragment() expects exactly 3 parameters, 2 given in /srv/mediawiki/php-1.31.0-wmf.20/extensions/VisualEditor/ApiVisualEditor.php on line 135

Details

SubjectRepoBranchLines +/-
ApiVisualEditor: Update getPreloadContent's parseWikitextFragment callmediawiki/extensions/VisualEditorwmf/1.31.0-wmf.20+1 -1
ApiVisualEditor: Update getPreloadContent's parseWikitextFragment callmediawiki/extensions/VisualEditormaster+1 -1
Customize query in gerrit

Related Objects
Search...

Event Timeline

• demon triaged this task as Medium priority.Feb 9 2018, 2:55 PM
• demon created this task.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 9 2018, 2:55 PM
Esanders added subscribers: DLynch, Esanders.Feb 9 2018, 5:29 PM

pinging @DLynch

• demon added a parent task: T183959: 1.31.0-wmf.20 deployment blockers.Feb 9 2018, 6:45 PM
DLynch added a comment.Feb 9 2018, 8:39 PM

@Esanders: It's duelling patches. Your https://gerrit.wikimedia.org/r/406770 merged at the end of January, but was originally written before I added getPreloadContent, so it didn't update the call to parseWikitextFragment in it. I can throw up a quick patch to update said call.

Jdforrester-WMF assigned this task to DLynch.Feb 9 2018, 8:41 PM
Jdforrester-WMF added a project: VisualEditor-MediaWiki.
Jdforrester-WMF subscribed.

Sounds good.

gerritbot subscribed.Feb 9 2018, 8:43 PM

Change 409439 had a related patch set uploaded (by DLynch; owner: DLynch):
[mediawiki/extensions/VisualEditor@master] ApiVisualEditor: Update getPreloadContent's parseWikitextFragment call

https://gerrit.wikimedia.org/r/409439

gerritbot added a project: Patch-For-Review.Feb 9 2018, 8:43 PM
gerritbot added a comment.Feb 10 2018, 5:14 PM

Change 409439 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] ApiVisualEditor: Update getPreloadContent's parseWikitextFragment call

https://gerrit.wikimedia.org/r/409439

gerritbot added a comment.Feb 11 2018, 12:49 AM

Change 409630 had a related patch set uploaded (by Jforrester; owner: DLynch):
[mediawiki/extensions/VisualEditor@wmf/1.31.0-wmf.20] ApiVisualEditor: Update getPreloadContent's parseWikitextFragment call

https://gerrit.wikimedia.org/r/409630

Jdforrester-WMF set the point value for this task to 1.Feb 11 2018, 1:26 AM
Jdforrester-WMF moved this task from To Triage to TR0: Interrupt on the VisualEditor board.
gerritbot added a comment.Feb 12 2018, 4:50 PM

Change 409630 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@wmf/1.31.0-wmf.20] ApiVisualEditor: Update getPreloadContent's parseWikitextFragment call

https://gerrit.wikimedia.org/r/409630

• demon closed this task as Resolved.Feb 12 2018, 4:54 PM
Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptFeb 12 2018, 4:54 PM
Ryasmeen moved this task from To be Verified to Non verifiable/Task on the User-Ryasmeen board.Mar 19 2018, 10:14 PM
• mmodell changed the subtype of this task from "Task" to "Production Error".Aug 28 2019, 11:09 PM
Maintenance_bot removed a project: Patch-For-Review.Aug 28 2019, 11:45 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL