Page MenuHomePhabricator

its-phabricator (gerritbot) sometimes not writing to tasks
Closed, ResolvedPublic

Description

Since we upgraded to 2.14, the bot seems to sometime not write to tasks like T188019 and other tasks.

This is probaly a bug (and maybe a regression some where in the code?)

Event Timeline

Paladox renamed this task from its-phabricaor sometimes not writing to tasks to its-phabricator (gerritbot) sometimes not writing to tasks.Feb 22 2018, 6:59 PM
Paladox triaged this task as High priority.

I filled this as high priority as something is wrong here. This bug must be some where. Im currently looking into what we can fix here.

I've managed to reproduce this problem.

If you revert a change and then add Bug: T 1 for example (exclude the space) then it reproduces the bug for me.

here's the logs from my local install

{P6732}

I don't think this is new - it's always failed if you add the Bug: field later, after the initial patch is created.

I don't think this is new - it's always failed if you add the Bug: field later, after the initial patch is created.

It always seemed to work.

I don't think this is new - it's always failed if you add the Bug: field later, after the initial patch is created.

Afair at some point it also worked when you added the Bug: field later or removed an extra whitespace between Bug: and the number, but i'm not 100% sure to claim anything.

@Dzahn will tell you later (when your free) what the issue is.

I know what the issue is now, but cannot disclose it due to the nature of the bug (in a open task).

Paladox set Security to Software security bug.Feb 22 2018, 10:00 PM
Paladox added a project: acl*security.
Paladox changed the visibility from "Public (No Login Required)" to "Custom Policy".

I found it to not be escaping the text when doing reverts, task similar to T140366

Upstream change, https://gerrit-review.googlesource.com/c/plugins/its-base/+/161730 (not everyone can view it as i have it in private to prevent any one being able to find out what the task and bug i filled upstream are).

I can add any one here who has an account upstream on gerrit-review. The change can be merged as private then opened up. But i guess i will only open it up once wmf has upgraded.

The change has been merged upstream now :)

Needs @demon to rebuild its-phabrivator and then we can change the config to use the new bar :)

I'm not sure if this is the same as my report in T190212:

If you revert a change and then add Bug: T 1 for example (exclude the space) then it reproduces the bug for me.

In both of the cases I saw, a Bug: T1 line was already present in the first patchset, and they were not reverts.

Change 420742 merged by Dzahn:
[operations/puppet@production] Gerrit: Fix its-phabricator soy templates

https://gerrit.wikimedia.org/r/420742

@matmarex it was because there was a string in the title, this should be fixed with the its-phabricator update we did today + deploy of https://gerrit.wikimedia.org/r/420742

Change 420922 had a related patch set uploaded (by Paladox; owner: Paladox):
[operations/puppet@production] Revert "Gerrit: Fix its-phabricator soy templates"

https://gerrit.wikimedia.org/r/420922

Change 420922 abandoned by Paladox:
Revert "Gerrit: Fix its-phabricator soy templates"

Reason:
Works.

https://gerrit.wikimedia.org/r/420922

Paladox claimed this task.

This works now :)

Oh, because of the quotes. Interesting. Thanks for the explanation.

Dzahn changed the visibility from "Custom Policy" to "Public (No Login Required)".Mar 20 2018, 10:48 PM