On https://stats.wikimedia.org/v2/#/all-projects the alert message about adblocker doesn't fit in its box on smaller screens.
Description
Description
Details
Details
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Fixed the adblocker alert message overflow for smaller screens | analytics/wikistats2 | master | +11 -7 |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | • fdans | T186812 Make the Wikistats 2 UI responsive | |||
| Resolved | sahil505 | T188208 The alert message about adblocker is not fully shown on smaller screens |
Event Timeline
Comment Actions
There are many ways to go about solving this bug. One is to provide a uniform left and right margin and adjust the class height a bit. Responsiveness checks out as well. Looks like this locally. @mforns
Comment Actions
Change 419977 had a related patch set uploaded (by Sahil505; owner: Sahil505):
[analytics/wikistats2@master] The alert message about adblocker is not fully shown on smaller screens
Comment Actions
@sahil505, thanks for taking care of this task!
Your fix looks good to me!
Maybe, now that we're using 2 lines, I would add a line break between the first and second sentences of the message.
This way, both lines would have more or less the same length. What do you think?
I will comment on your Gerrit patch.
Comment Actions
Thanks @mforns. I agree about the line break, will make it look a bit more uniform and cleaner. On it!
Comment Actions
Change 419977 merged by Mforns:
[analytics/wikistats2@master] Fixed the adblocker alert message overflow for smaller screens