Page MenuHomePhabricator

The alert message about adblocker is not fully shown on smaller screens
Closed, ResolvedPublic3 Estimated Story Points


On the alert message about adblocker doesn't fit in its box on smaller screens.

image.png (768×1 px, 180 KB)

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript
mforns moved this task from Incoming to Mentoring on the Analytics board.

There are many ways to go about solving this bug. One is to provide a uniform left and right margin and adjust the class height a bit. Responsiveness checks out as well. Looks like this locally. @mforns

Screen Shot 2018-03-14 at 4.49.04 AM.png (1×2 px, 553 KB)

Change 419977 had a related patch set uploaded (by Sahil505; owner: Sahil505):
[analytics/wikistats2@master] The alert message about adblocker is not fully shown on smaller screens

@sahil505, thanks for taking care of this task!
Your fix looks good to me!
Maybe, now that we're using 2 lines, I would add a line break between the first and second sentences of the message.
This way, both lines would have more or less the same length. What do you think?
I will comment on your Gerrit patch.

Thanks @mforns. I agree about the line break, will make it look a bit more uniform and cleaner. On it!

Change 419977 merged by Mforns:
[analytics/wikistats2@master] Fixed the adblocker alert message overflow for smaller screens

mforns set the point value for this task to 3.
mforns edited projects, added Analytics-Kanban; removed Analytics.
mforns moved this task from Next Up to Done on the Analytics-Kanban board.