Page MenuHomePhabricator

CX: Empty title error
Closed, ResolvedPublic

Description

As part of the system to communicate errors and warnings in Content Translation (T189488), we want to surface issues such as the title being empty, as illustrated below:

  • We'll show the error after the user edited the title (or initially if the user already loads a translation with such problem).
  • The publish button will be disabled while the issue remains.
  • An error marker will be shown next to the title.
  • The error details will include a "learn more" pointing to a documentation page about titles (if available in the language),

Message text:

Your translation needs a title
All pages need a name for users to find them. Please, give a name to your translation in order to publish it.

Event Timeline

Change 432540 had a related patch set uploaded (by Petar.petkovic; owner: Petar.petkovic):
[mediawiki/extensions/ContentTranslation@master] Connect issue card and target title

https://gerrit.wikimedia.org/r/432540

Change 432540 merged by jenkins-bot:
[mediawiki/extensions/ContentTranslation@master] Connect issue card and target title

https://gerrit.wikimedia.org/r/432540

The layout seems ok - though the X in the circle icon is not red.

@Petar.petkovic - there are two issues- (1) is most likely ok, but (2) seems not be implemented according to the specs.

(1)

We'll show the error after the user edited the title (or initially if the user already loads a translation with such problem).

The side panel error message is present only when the focus is on the title area

If I click anywhere outside the title area, the side panel error message is gone:

(2)

The publish button will be disabled while the issue remains.

The Publish icon is displayed as active all the time although the publishing is not possible.

thanks for the review and the relevant comments @Etonkovidova. My replies below:

The layout seems ok - though the X in the circle icon is not red.

This is a known limitation of the icon system. Using color icons helps making the connection between the error markers and the message (as defined in T189488), but for now we can use the black ones and look for improvements later.

@Petar.petkovic - there are two issues- (1) is most likely ok, but (2) seems not be implemented according to the specs.
(1)
If I click anywhere outside the title area, the side panel error message is gone:

This is something to improve on the general issue system. As illustrated in the examples at the bottom of T189488, the issue card summary should be present if there are issues and become expanded when the focus is on one of those:

@Petar.petkovic, do you prefer to use this ticket to fix this using this kind of issue as an example, or prefer a separate ticket?

(2)

The publish button will be disabled while the issue remains.

The Publish icon is displayed as active all the time although the publishing is not possible.

This is probably an adjustment to do on top of the basic enabling/disabling mechanism of the publish button (T196463). We can leave this part out of the scope for now.

@Petar.petkovic, do you prefer to use this ticket to fix this using this kind of issue as an example, or prefer a separate ticket?

For both issues @Etonkovidova marked with (1) and (2), I prefer separate tickets:

Etonkovidova closed this task as Resolved.EditedJun 6 2018, 6:01 PM

Thx @Pginer-WMF and @Petar.petkovic. I reviewed T189488 and T196463 - they the issue card and the publish button functionality has been described with great level of detail, so the existing issues will be addressed there. I am closing this task as Resolved.

Petar.petkovic moved this task from QA to Done on the Language-2018-Apr-June board.Jun 6 2018, 6:44 PM