Page MenuHomePhabricator
Create Task
Maniphest T190980

Improve RCFilters highlight circles CSS code output and align due to new base font-size
Closed, ResolvedPublic
Actions

Description

Issues identified with current LESS code (& after T97631 & T177432):

  • circle mixin cares about the specific colors, but repeats general properties/values in every color instead of a shared circle class
    • box-sizing
    • border-radius: 50%
  • sets margin instead of top/left, which would be in most cases sufficient and overwrite instead of adding another property Update 2018-04-07: Due to variance in usage, this doesn't make sense in time-budget vs saved output sense.
  • OOUI ButtonWidget sets opacity on icons, therefore the colors in .mw-rcfilters-ui-filterItemHighlightButton are not rendered correctly

image.png (572×1 px, 103 KB)

Details

SubjectRepoBranchLines +/-
RCFilters: Improve circle mixin and change to new standard icon sizemediawiki/coremaster+151 -125
RCFilters: Override frameless button opacity to show real highlight colormediawiki/coremaster+7 -3
Customize query in gerrit

Related Objects

Event Timeline

Volker_E created this task.Mar 29 2018, 12:17 AM
Restricted Application added a project: Collaboration-Team-Triage. · View Herald TranscriptMar 29 2018, 12:17 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
kaldari subscribed.Apr 3 2018, 5:47 PM

@Volker_E: You got this one?

Volker_E added a comment.EditedApr 3 2018, 5:59 PM

@kaldari Yes, I've had to focus on other, higher-prio follow-ups to T97361. Should have provided patch by tomorrow.

Volker_E added a project: Edit-Review-Improvements-Integrated-Filters.Apr 7 2018, 11:22 PM
gerritbot subscribed.Apr 8 2018, 5:48 AM

Change 424848 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[mediawiki/core@master] RCFilters: Improve circle mixin and change to new standard icon size

https://gerrit.wikimedia.org/r/424848

gerritbot added a project: Patch-For-Review.Apr 8 2018, 5:48 AM
Volker_E updated the task description. (Show Details)Apr 8 2018, 5:55 AM
Volker_E updated the task description. (Show Details)
• jmatazzoni moved this task from Untriaged to External on the Collaboration-Team-Triage board.Apr 10 2018, 5:01 PM
Restricted Application added a project: Growth-Team. · View Herald TranscriptOct 5 2018, 1:47 PM
Trizek-WMF moved this task from Inbox to External on the Growth-Team board.Oct 8 2018, 12:57 PM
Trizek-WMF subscribed.

Any updates? Is it solved?

Volker_E added a subscriber: • Catrope.Oct 8 2018, 3:35 PM

@Trizek-WMF That's not resolved yet, sorry. Slipped off my radar after running into some issues with my patch. Need to sit aside of @Etonkovidova or @Catrope to verify changes as they have the right setup.

gerritbot added a comment.Oct 8 2018, 4:18 PM

Change 465191 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[mediawiki/core@master] RCFilters: Override frameless button opacity to show real highlight color

https://gerrit.wikimedia.org/r/465191

gerritbot added a comment.Oct 9 2018, 9:55 PM

Change 465191 merged by jenkins-bot:
[mediawiki/core@master] RCFilters: Override frameless button opacity to show real highlight color

https://gerrit.wikimedia.org/r/465191

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)).Oct 9 2018, 10:00 PM
Volker_E updated the task description. (Show Details)Oct 9 2018, 10:04 PM
gerritbot added a comment.Oct 10 2018, 10:09 PM

Change 424848 merged by jenkins-bot:
[mediawiki/core@master] RCFilters: Improve circle mixin and change to new standard icon size

https://gerrit.wikimedia.org/r/424848

Volker_E removed a project: Patch-For-Review.Oct 10 2018, 10:10 PM
Volker_E updated the task description. (Show Details)

@Etonkovidova Over to you for QA please…

MBinder_WMF added a project: Growth-Team-Filtering.Apr 15 2021, 6:56 PM
Aklapper removed a project: Collaboration-Team-Triage.May 25 2021, 9:09 PM
Mooeypoo closed this task as Resolved.May 17 2023, 9:25 AM
Mooeypoo claimed this task.

This looks done to me, from 2018. Closing.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits