@Legoktm did I miss any screens?

Nope, I think that's it :)

I'm going to add a moderation interface as part of T133109: Add basic abuse prevention to UrlShortener but that's going to be admin-only and it'll just use the standard OOUIHTMLForm so it should be trivial to review as part of the patch itself.

Here is a quick review of these screens, we can discuss which of these, if any, need to become blockers, or tasks to resolve later.

• Tool sidebar
  • A & B:
  • C: Maybe we want to show the URL in an OOUI Popup, like Wikidata Query, and change the link to Shorten another URL which takes you to the special page.
• Special Page
  • A & B:
  • C: Error message too long, obscuring the input. Maybe use notice instead of inline label.
  • D: Too many notices, let's have one either for the form or the input. I prefer input.
  • E: Does this need a screen of it's own? Would it be better to show it on the same page like in -https://upload.wikimedia.org/wikipedia/commons/a/a7/UrlShortener.png

In T191592#4110943, @Legoktm wrote:

I'm going to add a moderation interface as part of T133109: Add basic abuse prevention to UrlShortener but that's going to be admin-only and it'll just use the standard OOUIHTMLForm so it should be trivial to review as part of the patch itself.

Yep, sounds good.

(my2c, I really like the sidebar option, but I am aware that some don't ever want that touched. Just noting the option should be closer anyway to Permanent link, imho. If only there was a way to put both on the same line. )

Change 496877 had a related patch set uploaded (by Ladsgroup; owner: Ladsgroup):
[mediawiki/extensions/UrlShortener@master] Move showing errors to below the input

https://gerrit.wikimedia.org/r/496877

Change 496877 had a related patch set uploaded (by Ladsgroup; owner: Ladsgroup):
[mediawiki/extensions/UrlShortener@master] Move showing errors to below the input

https://gerrit.wikimedia.org/r/496877

Change 496877 merged by jenkins-bot:
[mediawiki/extensions/UrlShortener@master] Move showing errors to below the input

https://gerrit.wikimedia.org/r/496877